Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75326/?format=api
{ "id": 75326, "url": "http://patches.dpdk.org/api/patches/75326/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200810024123.23387-1-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200810024123.23387-1-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200810024123.23387-1-wei.zhao1@intel.com", "date": "2020-08-10T02:41:23", "name": "net/ice: fix VF index check for DCF", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "52e28dbea5237236d690b10bbef4567d0adf794f", "submitter": { "id": 495, "url": "http://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200810024123.23387-1-wei.zhao1@intel.com/mbox/", "series": [ { "id": 11559, "url": "http://patches.dpdk.org/api/series/11559/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11559", "date": "2020-08-10T02:41:23", "name": "net/ice: fix VF index check for DCF", "version": 1, "mbox": "http://patches.dpdk.org/series/11559/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75326/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75326/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E94EA04C1;\n\tMon, 10 Aug 2020 05:08:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5CDCE2A5D;\n\tMon, 10 Aug 2020 05:07:59 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id C82232142;\n Mon, 10 Aug 2020 05:07:57 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Aug 2020 20:07:56 -0700", "from unknown (HELO localhost.localdomain.bj.intel.com)\n ([172.16.182.123])\n by orsmga005.jf.intel.com with ESMTP; 09 Aug 2020 20:07:54 -0700" ], "IronPort-SDR": [ "\n jKLc7QI/IyZcrpj2YA8pmd8C0717kHbFgPZkxPECfwCTV1UdnpX9AygkVG1lKYRdTaZRv9Um2z\n NwxhcU025+ZA==", "\n py215iT90dJKNeYA3EvrFd+wuHJH9JTDcDJ9vmhgZ0B7Amr6YpLKAA5m6gzA9Q1WhhoEhxg/yV\n TH49yxsJt6OQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9708\"; a=\"141333489\"", "E=Sophos;i=\"5.75,456,1589266800\"; d=\"scan'208\";a=\"141333489\"", "E=Sophos;i=\"5.75,456,1589266800\"; d=\"scan'208\";a=\"468890109\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, qi.z.zhang@intel.com, nannan.lu@intel.com,\n Wei Zhao <wei.zhao1@intel.com>", "Date": "Mon, 10 Aug 2020 10:41:23 +0800", "Message-Id": "<20200810024123.23387-1-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice: fix VF index check for DCF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vf index in rte_flow command need to check\nin order that larger the actual number.\n\nFixes: 829c3106812d (\"net/ice: enable switch flow on DCF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ice/ice_switch_filter.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c\nindex c4b00b6a2..e7e03d96b 100644\n--- a/drivers/net/ice/ice_switch_filter.c\n+++ b/drivers/net/ice/ice_switch_filter.c\n@@ -1405,6 +1405,16 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,\n \t\tcase RTE_FLOW_ACTION_TYPE_VF:\n \t\t\trule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;\n \t\t\tact_vf = action->conf;\n+\n+\t\t\tif (act_vf->id >= ad->real_hw.num_vfs &&\n+\t\t\t\t!act_vf->original) {\n+\t\t\t\trte_flow_error_set(error,\n+\t\t\t\t\tEINVAL, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\tactions,\n+\t\t\t\t\t\"Invalid vf id\");\n+\t\t\t\treturn -rte_errno;\n+\t\t\t}\n+\n \t\t\tif (act_vf->original)\n \t\t\t\trule_info->sw_act.vsi_handle =\n \t\t\t\t\tad->real_hw.avf.bus.func;\n@@ -1667,12 +1677,8 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,\n \telse\n \t\tret = ice_switch_parse_action(pf, actions, error, &rule_info);\n \n-\tif (ret) {\n-\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n-\t\t\t\t \"Invalid input action\");\n+\tif (ret)\n \t\tgoto error;\n-\t}\n \n \tif (meta) {\n \t\t*meta = sw_meta_ptr;\n", "prefixes": [] }