Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75300/?format=api
{ "id": 75300, "url": "http://patches.dpdk.org/api/patches/75300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200807155859.63888-4-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200807155859.63888-4-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200807155859.63888-4-ciara.power@intel.com", "date": "2020-08-07T15:58:50", "name": "[20.11,03/12] net/i40e: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2660c4bfa573de4d03ea004c3cd69ef5f4a44bd6", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200807155859.63888-4-ciara.power@intel.com/mbox/", "series": [ { "id": 11550, "url": "http://patches.dpdk.org/api/series/11550/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11550", "date": "2020-08-07T15:58:47", "name": "add max SIMD bitwidth to EAL", "version": 1, "mbox": "http://patches.dpdk.org/series/11550/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75300/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A13DAA04B0;\n\tFri, 7 Aug 2020 18:07:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9ED371C0B2;\n\tFri, 7 Aug 2020 18:06:33 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 0A8591C042\n for <dev@dpdk.org>; Fri, 7 Aug 2020 18:06:30 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Aug 2020 09:06:30 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga007.fm.intel.com with ESMTP; 07 Aug 2020 09:06:29 -0700" ], "IronPort-SDR": [ "\n kDzcWTLWHcQUAVqWr1bXycXpDKu13lWIe5lkWEh5RLxyOSUAQey63hO70zDiEgC9l63py30Ckp\n YtkOpfmk9uIg==", "\n H1qlQC8WO+zmOmhr/viaaXIdttV6LOUjtxz01omm7rYMeG1cAlQKMdMkWqy9NsGqxOGHqQDJD/\n o5Oyo+a4Y0yg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9705\"; a=\"171183026\"", "E=Sophos;i=\"5.75,446,1589266800\"; d=\"scan'208\";a=\"171183026\"", "E=Sophos;i=\"5.75,446,1589266800\"; d=\"scan'208\";a=\"275407890\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Ciara Power <ciara.power@intel.com>,\n Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>", "Date": "Fri, 7 Aug 2020 16:58:50 +0100", "Message-Id": "<20200807155859.63888-4-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200807155859.63888-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH 20.11 03/12] net/i40e: add checks for max SIMD\n\tbitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Beilei Xing <beilei.xing@intel.com>\nCc: Jeff Guo <jia.guo@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex fe7f9200c1..90f4e26fb8 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -3098,7 +3098,8 @@ static eth_rx_burst_t\n i40e_get_latest_rx_vec(bool scatter)\n {\n #if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)\n-\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2))\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\treturn scatter ? i40e_recv_scattered_pkts_vec_avx2 :\n \t\t\t\t i40e_recv_pkts_vec_avx2;\n #endif\n@@ -3115,7 +3116,8 @@ i40e_get_recommend_rx_vec(bool scatter)\n \t * use of AVX2 version to later plaforms, not all those that could\n \t * theoretically run it.\n \t */\n-\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F))\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\treturn scatter ? i40e_recv_scattered_pkts_vec_avx2 :\n \t\t\t\t i40e_recv_pkts_vec_avx2;\n #endif\n@@ -3154,7 +3156,8 @@ i40e_set_rx_function(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tif (ad->rx_vec_allowed) {\n+\tif (ad->rx_vec_allowed && rte_get_max_simd_bitwidth()\n+\t\t\t>= RTE_MAX_128_SIMD) {\n \t\t/* Vec Rx path */\n \t\tPMD_INIT_LOG(DEBUG, \"Vector Rx path will be used on port=%d.\",\n \t\t\t\tdev->data->port_id);\n@@ -3268,7 +3271,8 @@ static eth_tx_burst_t\n i40e_get_latest_tx_vec(void)\n {\n #if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)\n-\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2))\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\treturn i40e_xmit_pkts_vec_avx2;\n #endif\n \treturn i40e_xmit_pkts_vec;\n@@ -3283,7 +3287,8 @@ i40e_get_recommend_tx_vec(void)\n \t * use of AVX2 version to later plaforms, not all those that could\n \t * theoretically run it.\n \t */\n-\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F))\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\treturn i40e_xmit_pkts_vec_avx2;\n #endif\n \treturn i40e_xmit_pkts_vec;\n@@ -3311,7 +3316,9 @@ i40e_set_tx_function(struct rte_eth_dev *dev)\n \t}\n \n \tif (ad->tx_simple_allowed) {\n-\t\tif (ad->tx_vec_allowed) {\n+\t\tif (ad->tx_vec_allowed &&\n+\t\t\t\trte_get_max_simd_bitwidth()\n+\t\t\t\t>= RTE_MAX_128_SIMD) {\n \t\t\tPMD_INIT_LOG(DEBUG, \"Vector tx finally be used.\");\n \t\t\tif (ad->use_latest_vec)\n \t\t\t\tdev->tx_pkt_burst =\n", "prefixes": [ "20.11", "03/12" ] }