Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 75242,
    "url": "http://patches.dpdk.org/api/patches/75242/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200805154601.19609-4-steven.lariau@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200805154601.19609-4-steven.lariau@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200805154601.19609-4-steven.lariau@arm.com",
    "date": "2020-08-05T15:46:00",
    "name": "[3/4] test/stack: propagate errors to main core",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7c209a6e5eb8544c30c88b845031f415adab522d",
    "submitter": {
        "id": 1862,
        "url": "http://patches.dpdk.org/api/people/1862/?format=api",
        "name": "Steven Lariau",
        "email": "steven.lariau@arm.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200805154601.19609-4-steven.lariau@arm.com/mbox/",
    "series": [
        {
            "id": 11525,
            "url": "http://patches.dpdk.org/api/series/11525/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11525",
            "date": "2020-08-05T15:45:57",
            "name": "test/stack: improve multithreaded test",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/11525/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/75242/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/75242/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7465A0351;\n\tThu,  6 Aug 2020 12:27:55 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F6381C0D9;\n\tThu,  6 Aug 2020 12:27:38 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 3E5381BFFA\n for <dev@dpdk.org>; Wed,  5 Aug 2020 17:46:26 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCC851424;\n Wed,  5 Aug 2020 08:46:25 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.57.38.158])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E35613F7D7;\n Wed,  5 Aug 2020 08:46:24 -0700 (PDT)"
        ],
        "From": "Steven Lariau <steven.lariau@arm.com>",
        "To": "Gage Eads <gage.eads@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>",
        "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com,\n Steven Lariau <steven.lariau@arm.com>",
        "Date": "Wed,  5 Aug 2020 16:46:00 +0100",
        "Message-Id": "<20200805154601.19609-4-steven.lariau@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200805154601.19609-1-steven.lariau@arm.com>",
        "References": "<20200805154601.19609-1-steven.lariau@arm.com>",
        "X-Mailman-Approved-At": "Thu, 06 Aug 2020 12:27:33 +0200",
        "Subject": "[dpdk-dev] [PATCH 3/4] test/stack: propagate errors to main core",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Use rte_eal_wait_lcore to wait and get the return value for all cores.\nThis is used to propagate any error to the main core.\n\nSigned-off-by: Steven Lariau <steven.lariau@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_stack.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_stack.c b/app/test/test_stack.c\nindex c100d9faf..b9d6befd4 100644\n--- a/app/test/test_stack.c\n+++ b/app/test/test_stack.c\n@@ -322,8 +322,10 @@ static int\n test_stack_multithreaded(uint32_t flags)\n {\n \tstruct test_args args;\n+\tunsigned int lcore_id;\n \tstruct rte_stack *s;\n \trte_atomic64_t size;\n+\tint result = 0;\n \n \tif (rte_lcore_count() < 2) {\n \t\tprintf(\"Not enough cores for test_stack_multithreaded, expecting at least 2\\n\");\n@@ -346,10 +348,14 @@ test_stack_multithreaded(uint32_t flags)\n \n \tif (rte_eal_mp_remote_launch(stack_thread_push_pop, &args, CALL_MASTER))\n \t\trte_panic(\"Failed to launch tests\\n\");\n-\trte_eal_mp_wait_lcore();\n+\n+\tRTE_LCORE_FOREACH(lcore_id) {\n+\t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n+\t\t\tresult = -1;\n+\t}\n \n \trte_stack_free(s);\n-\treturn 0;\n+\treturn result;\n }\n \n static int\n",
    "prefixes": [
        "3/4"
    ]
}