Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75218/?format=api
{ "id": 75218, "url": "http://patches.dpdk.org/api/patches/75218/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200805144517.54689-5-amorenoz@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200805144517.54689-5-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200805144517.54689-5-amorenoz@redhat.com", "date": "2020-08-05T14:45:17", "name": "[v3,4/4] net/virtio: enable feature checking on virtio-user", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9b11d7f334401868f8c469b4dd21cf5033fdd1cb", "submitter": { "id": 1397, "url": "http://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200805144517.54689-5-amorenoz@redhat.com/mbox/", "series": [ { "id": 11508, "url": "http://patches.dpdk.org/api/series/11508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11508", "date": "2020-08-05T14:45:13", "name": "Add support for GET/SET_STATUS on virtio-user pmd", "version": 3, "mbox": "http://patches.dpdk.org/series/11508/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75218/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8CE3A053D;\n\tWed, 5 Aug 2020 16:46:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8E471C0B5;\n\tWed, 5 Aug 2020 16:45:40 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 00C191C0B3\n for <dev@dpdk.org>; Wed, 5 Aug 2020 16:45:38 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-193-Temf9Qc2NhazQCufeFJgVA-1; Wed, 05 Aug 2020 10:45:34 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0293106B250;\n Wed, 5 Aug 2020 14:45:33 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-113-105.ams2.redhat.com\n [10.36.113.105])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8B0DB88D6F;\n Wed, 5 Aug 2020 14:45:32 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1596638738;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=o/PVlK8hnpYgCPjOqQswlKaSOXFExMRPWPNHldnNezA=;\n b=DZYoXY3yYy9XFX1tMOg/BJwfbtkzAELn9oMEfi+5eeXAKMdH91SkFw9m6gCNPluK+IKT6R\n icGVIblVjdtZw9YooYjaDKkObTIKcILoXjdwyh6raJ6w5nM/ZbsUHA9+lYA7GXwD2kDw4A\n +DORrMJuKcf+ixtkX36AhdUin87a5XU=", "X-MC-Unique": "Temf9Qc2NhazQCufeFJgVA-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "zhihong.wang@intel.com, chenbo.xia@intel.com, maxime.coquelin@redhat.com,\n Adrian Moreno <amorenoz@redhat.com>", "Date": "Wed, 5 Aug 2020 16:45:17 +0200", "Message-Id": "<20200805144517.54689-5-amorenoz@redhat.com>", "In-Reply-To": "<20200805144517.54689-1-amorenoz@redhat.com>", "References": "<20200805144517.54689-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/4] net/virtio: enable feature checking on\n\tvirtio-user", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "virtio 1.0 introduced a mechanism for the driver to verify that the\nfeature bits it sets are accepted by the device. This mechanism consists\nin setting the VIRTIO_STATUS_FEATURE_OK status bit and re-reading it,\nwhich gives a chance for the device to clear it if the the features\nwere not accepted.\n\nThis is currently being done only in modern virtio-pci devices but since\nthe appropriate vhost-user messages have been added, it can also be done\nin virtio-user (vhost-user only).\n\nThis patch activates this mechanism on virtio-user.\n\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex dc0093bdf..9063bfeb2 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1355,12 +1355,13 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features)\n \tPMD_INIT_LOG(DEBUG, \"features after negotiate = %\" PRIx64,\n \t\thw->guest_features);\n \n-\tif (hw->modern) {\n-\t\tif (!vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) {\n-\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t\"VIRTIO_F_VERSION_1 features is not enabled.\");\n-\t\t\treturn -1;\n-\t\t}\n+\tif (hw->modern && !vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) {\n+\t\tPMD_INIT_LOG(ERR,\n+\t\t\t\"VIRTIO_F_VERSION_1 features is not enabled.\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (hw->modern || hw->virtio_user_dev) {\n \t\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_FEATURES_OK);\n \t\tif (!(vtpci_get_status(hw) & VIRTIO_CONFIG_STATUS_FEATURES_OK)) {\n \t\t\tPMD_INIT_LOG(ERR,\n", "prefixes": [ "v3", "4/4" ] }