Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75215/?format=api
{ "id": 75215, "url": "http://patches.dpdk.org/api/patches/75215/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200805144517.54689-3-amorenoz@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200805144517.54689-3-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200805144517.54689-3-amorenoz@redhat.com", "date": "2020-08-05T14:45:15", "name": "[v3,2/4] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d2c4474b2cc2e24873b5598b4f5fd80ef1363fa3", "submitter": { "id": 1397, "url": "http://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200805144517.54689-3-amorenoz@redhat.com/mbox/", "series": [ { "id": 11508, "url": "http://patches.dpdk.org/api/series/11508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11508", "date": "2020-08-05T14:45:13", "name": "Add support for GET/SET_STATUS on virtio-user pmd", "version": 3, "mbox": "http://patches.dpdk.org/series/11508/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75215/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6165EA053D;\n\tWed, 5 Aug 2020 16:45:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D4601C029;\n\tWed, 5 Aug 2020 16:45:36 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 7565C1BFFE\n for <dev@dpdk.org>; Wed, 5 Aug 2020 16:45:34 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-187-aF-0RtHGONy7pzEKQq6tlw-1; Wed, 05 Aug 2020 10:45:31 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9B9C80183C;\n Wed, 5 Aug 2020 14:45:30 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-113-105.ams2.redhat.com\n [10.36.113.105])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 769FF87E2A;\n Wed, 5 Aug 2020 14:45:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1596638733;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=JqyQ9TndSwII087xtRyhYD2OYNAnW460ziP4JUFWEmo=;\n b=R6s23CBeEO99GD0lED6d3PxbNunYCKz/JawSdZYfhgemKRIvRE/4ASdmcdV5Grm0FEOdDQ\n +LBjxnI/Tb0uvuPhd7tKAIO8uDZ8VSOtrWQg9ojBCm+SVO9MZozV7s3SAY4q8lkXzHcSdN\n 0rr8DZBxxKtceegBtTdMbvUDSpstt/Y=", "X-MC-Unique": "aF-0RtHGONy7pzEKQq6tlw-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "zhihong.wang@intel.com, chenbo.xia@intel.com, maxime.coquelin@redhat.com,\n Adrian Moreno <amorenoz@redhat.com>", "Date": "Wed, 5 Aug 2020 16:45:15 +0200", "Message-Id": "<20200805144517.54689-3-amorenoz@redhat.com>", "In-Reply-To": "<20200805144517.54689-1-amorenoz@redhat.com>", "References": "<20200805144517.54689-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/4] net/virtio: add VIRTIO_SET_STATUS support\n\tto Virtio-user", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nThis patch adds support for VHOST_USER_SET_STATUS\nrequest. It is used to make the backend aware of\nVirtio devices status update.\n\nIt is useful for the backend to know when the Virtio\ndriver is done with the Virtio device configuration.\n\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n drivers/net/virtio/virtio_user/vhost.h | 6 +++++\n drivers/net/virtio/virtio_user/vhost_user.c | 10 +++++++\n .../net/virtio/virtio_user/virtio_user_dev.c | 26 ++++++++++++++++++-\n .../net/virtio/virtio_user/virtio_user_dev.h | 1 +\n drivers/net/virtio/virtio_user_ethdev.c | 1 +\n 5 files changed, 43 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h\nindex 260e1c308..8f49ef457 100644\n--- a/drivers/net/virtio/virtio_user/vhost.h\n+++ b/drivers/net/virtio/virtio_user/vhost.h\n@@ -57,6 +57,10 @@ struct vhost_vring_addr {\n #define VHOST_USER_PROTOCOL_F_REPLY_ACK 3\n #endif\n \n+#ifndef VHOST_USER_PROTOCOL_F_STATUS\n+#define VHOST_USER_PROTOCOL_F_STATUS 16\n+#endif\n+\n enum vhost_user_request {\n \tVHOST_USER_NONE = 0,\n \tVHOST_USER_GET_FEATURES = 1,\n@@ -77,6 +81,8 @@ enum vhost_user_request {\n \tVHOST_USER_SET_PROTOCOL_FEATURES = 16,\n \tVHOST_USER_GET_QUEUE_NUM = 17,\n \tVHOST_USER_SET_VRING_ENABLE = 18,\n+\tVHOST_USER_SET_STATUS = 39,\n+\tVHOST_USER_GET_STATUS = 40,\n \tVHOST_USER_MAX\n };\n \ndiff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex ad48bafd4..337e51199 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -244,6 +244,8 @@ const char * const vhost_msg_strings[] = {\n \t[VHOST_USER_SET_VRING_ENABLE] = \"VHOST_SET_VRING_ENABLE\",\n \t[VHOST_USER_GET_PROTOCOL_FEATURES] = \"VHOST_USER_GET_PROTOCOL_FEATURES\",\n \t[VHOST_USER_SET_PROTOCOL_FEATURES] = \"VHOST_USER_SET_PROTOCOL_FEATURES\",\n+\t[VHOST_USER_SET_STATUS] = \"VHOST_SET_STATUS\",\n+\t[VHOST_USER_GET_STATUS] = \"VHOST_GET_STATUS\",\n };\n \n static int\n@@ -280,6 +282,14 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\tneed_reply = 1;\n \t\tbreak;\n \n+\tcase VHOST_USER_SET_STATUS:\n+\t\tif (!(dev->protocol_features &\n+\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\t\treturn 0;\n+\n+\t\tif (has_reply_ack)\n+\t\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n+\t\t/* Fallthrough */\n \tcase VHOST_USER_SET_FEATURES:\n \tcase VHOST_USER_SET_PROTOCOL_FEATURES:\n \tcase VHOST_USER_SET_LOG_BASE:\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 0a6991bcc..670fc9d40 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -424,7 +424,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n \n #define VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES\t\t\\\n \t(1ULL << VHOST_USER_PROTOCOL_F_MQ |\t\t\\\n-\t 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK)\n+\t 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK |\t\\\n+\t 1ULL << VHOST_USER_PROTOCOL_F_STATUS)\n \n int\n virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n@@ -783,3 +784,26 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx)\n \t\t__atomic_add_fetch(&vring->used->idx, 1, __ATOMIC_RELAXED);\n \t}\n }\n+\n+int\n+virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status)\n+{\n+\tint ret;\n+\tuint64_t arg = status;\n+\n+\t/* Vhost-user only for now */\n+\tif (!is_vhost_user_by_type(dev->path))\n+\t\treturn 0;\n+\n+\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\treturn 0;\n+\n+\tret = dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"VHOST_USER_SET_STATUS failed (%d): %s\", ret,\n+\t\t\t strerror(errno));\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h\nindex 554174e81..835ab64ae 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h\n@@ -72,4 +72,5 @@ void virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx);\n void virtio_user_handle_cq_packed(struct virtio_user_dev *dev,\n \t\t\t\t uint16_t queue_idx);\n uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs);\n+int virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status);\n #endif\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 6003f6d50..785882e06 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -272,6 +272,7 @@ virtio_user_set_status(struct virtio_hw *hw, uint8_t status)\n \telse if (status == VIRTIO_CONFIG_STATUS_RESET)\n \t\tvirtio_user_reset(hw);\n \tdev->status = status;\n+\tvirtio_user_send_status_update(dev, status);\n }\n \n static uint8_t\n", "prefixes": [ "v3", "2/4" ] }