Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75191/?format=api
{ "id": 75191, "url": "http://patches.dpdk.org/api/patches/75191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200804140738.35317-7-louise.kilheeney@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200804140738.35317-7-louise.kilheeney@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200804140738.35317-7-louise.kilheeney@intel.com", "date": "2020-08-04T14:07:35", "name": "[v4,6/9] app/test: support python3 only", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6f3b5a934cefd017253ed9c7bd751a70c254ad7", "submitter": { "id": 1621, "url": "http://patches.dpdk.org/api/people/1621/?format=api", "name": "Louise Kilheeney", "email": "louise.kilheeney@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200804140738.35317-7-louise.kilheeney@intel.com/mbox/", "series": [ { "id": 11492, "url": "http://patches.dpdk.org/api/series/11492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11492", "date": "2020-08-04T14:07:29", "name": "adding support for python 3 only.", "version": 4, "mbox": "http://patches.dpdk.org/series/11492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75191/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4750FA053A;\n\tTue, 4 Aug 2020 16:09:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2C401C0CD;\n\tTue, 4 Aug 2020 16:08:10 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 7933B1C0B6\n for <dev@dpdk.org>; Tue, 4 Aug 2020 16:08:08 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Aug 2020 07:08:08 -0700", "from silpixa00389033.ir.intel.com (HELO\n silpixa00389033.ger.corp.intel.com) ([10.237.223.171])\n by orsmga006.jf.intel.com with ESMTP; 04 Aug 2020 07:08:06 -0700" ], "IronPort-SDR": [ "\n 4PZj2uP2fj7cDQfKMrnlDTcNSwqS8pT2mwXmJ4dmCQKcB5TcqLap28BmglMW8AdWOfGOF3gPdo\n 5+PB3JguwaIA==", "\n QD9ZCRga0Am8q5UF8EqoF6G5YNxz/Zf+uKtP+/es/lrhXNONeJj2V7AYEXwObydhq6DyZKwFDn\n ri1Razxxmdsg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9702\"; a=\"237173556\"", "E=Sophos;i=\"5.75,434,1589266800\"; d=\"scan'208\";a=\"237173556\"", "E=Sophos;i=\"5.75,434,1589266800\"; d=\"scan'208\";a=\"292578232\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Louise Kilheeney <louise.kilheeney@intel.com>", "To": "dev@dpdk.org", "Cc": "anatoly.burakov@intel.com, bruce.richardson@intel.com,\n robin.jarry@6wind.com, Louise Kilheeney <louise.kilheeney@intel.com>", "Date": "Tue, 4 Aug 2020 15:07:35 +0100", "Message-Id": "<20200804140738.35317-7-louise.kilheeney@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200804140738.35317-1-louise.kilheeney@intel.com>", "References": "<20200522132320.26373-1-louise.kilheeney@intel.com>\n <20200804140738.35317-1-louise.kilheeney@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 6/9] app/test: support python3 only", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Changed script to explicitly use python3 only to avoid\nmaintaining python 2 and removed deprecation notice.\n\nSigned-off-by: Louise Kilheeney <louise.kilheeney@intel.com>\n---\n app/test/autotest.py | 7 +------\n app/test/autotest_data.py | 1 +\n app/test/autotest_runner.py | 21 ++++++++-------------\n app/test/autotest_test_funcs.py | 1 +\n mk/rte.sdktest.mk | 4 ++--\n 5 files changed, 13 insertions(+), 21 deletions(-)", "diff": "diff --git a/app/test/autotest.py b/app/test/autotest.py\nindex cf7584ccd7..9eef1efbe5 100644\n--- a/app/test/autotest.py\n+++ b/app/test/autotest.py\n@@ -1,9 +1,8 @@\n-#!/usr/bin/env python\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n # Script that uses either test app or qemu controlled by python-pexpect\n-from __future__ import print_function\n import autotest_data\n import autotest_runner\n import sys\n@@ -17,10 +16,6 @@ def usage():\n usage()\n sys.exit(1)\n \n-if sys.version_info.major < 3:\n- print(\"WARNING: Python 2 is deprecated for use in DPDK, and will not work in future releases.\", file=sys.stderr)\n- print(\"Please use Python 3 instead\", file=sys.stderr)\n-\n target = sys.argv[2]\n \n test_whitelist = None\ndiff --git a/app/test/autotest_data.py b/app/test/autotest_data.py\nindex 4b7da45e09..097638941f 100644\n--- a/app/test/autotest_data.py\n+++ b/app/test/autotest_data.py\n@@ -1,3 +1,4 @@\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \ndiff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py\nindex 95e74c760d..998fe57a55 100644\n--- a/app/test/autotest_runner.py\n+++ b/app/test/autotest_runner.py\n@@ -1,10 +1,10 @@\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n # The main logic behind running autotests in parallel\n \n-from __future__ import print_function\n-import StringIO\n+import io\n import csv\n from multiprocessing import Pool, Queue\n import pexpect\n@@ -50,11 +50,7 @@ def first_cpu_on_node(node_nr):\n map(os.path.basename, cpu_path)\n )\n )\n- # for compatibility between python 3 and 2 we need to make interable out\n- # of filter return as it returns list in python 2 and a generator in 3\n- m = next(iter(cpu_name))\n- return int(m.group(1))\n-\n+ return int(next(cpu_name).group(1))\n \n pool_child = None # per-process child\n \n@@ -78,7 +74,7 @@ def pool_init(queue, result_queue):\n cmdline = \"%s %s\" % (cmdline, prefix_cmdline)\n \n # prepare logging of init\n- startuplog = StringIO.StringIO()\n+ startuplog = io.StringIO()\n \n # run test app\n try:\n@@ -86,8 +82,7 @@ def pool_init(queue, result_queue):\n print(\"\\n%s %s\\n\" % (\"=\" * 20, prefix), file=startuplog)\n print(\"\\ncmdline=%s\" % cmdline, file=startuplog)\n \n- pool_child = pexpect.spawn(cmdline, logfile=startuplog)\n-\n+ pool_child = pexpect.spawn(cmdline, logfile=startuplog, encoding='utf-8')\n # wait for target to boot\n if not wait_prompt(pool_child):\n pool_child.close()\n@@ -138,7 +133,7 @@ def run_test(target, test):\n # create log buffer for each test\n # in multiprocessing environment, the logging would be\n # interleaved and will create a mess, hence the buffering\n- logfile = StringIO.StringIO()\n+ logfile = io.StringIO()\n pool_child.logfile = logfile\n \n # make a note when the test started\n@@ -210,9 +205,9 @@ def __init__(self, cmdline, target, blacklist, whitelist, n_processes):\n # parse the binary for available test commands\n binary = cmdline.split()[0]\n stripped = 'not stripped' not in \\\n- subprocess.check_output(['file', binary])\n+ subprocess.check_output(['file', binary]).decode()\n if not stripped:\n- symbols = subprocess.check_output(['nm', binary]).decode('utf-8')\n+ symbols = subprocess.check_output(['nm', binary]).decode()\n self.avail_cmds = re.findall('test_register_(\\w+)', symbols)\n else:\n self.avail_cmds = None\ndiff --git a/app/test/autotest_test_funcs.py b/app/test/autotest_test_funcs.py\nindex 26688b7132..775dfd1dc5 100644\n--- a/app/test/autotest_test_funcs.py\n+++ b/app/test/autotest_test_funcs.py\n@@ -1,3 +1,4 @@\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \ndiff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk\nindex ad7ef138f0..81eff0c08f 100644\n--- a/mk/rte.sdktest.mk\n+++ b/mk/rte.sdktest.mk\n@@ -49,7 +49,7 @@ test test-fast test-perf test-drivers test-dump:\n \t@mkdir -p $(AUTOTEST_DIR) ; \\\n \tcd $(AUTOTEST_DIR) ; \\\n \tif [ -f $(RTE_OUTPUT)/app/test ]; then \\\n-\t\tpython $(RTE_SDK)/app/test/autotest.py \\\n+\t\tpython3 $(RTE_SDK)/app/test/autotest.py \\\n \t\t\t$(RTE_OUTPUT)/app/test \\\n \t\t\t$(RTE_TARGET) \\\n \t\t\t$(BLACKLIST) $(WHITELIST); \\\n@@ -66,7 +66,7 @@ coverage:\n \t\tpython3 $(RTE_SDK)/test/cmdline_test/cmdline_test.py \\\n \t\t\t$(RTE_OUTPUT)/app/cmdline_test; \\\n \t\tulimit -S -n 100 ; \\\n-\t\tpython $(RTE_SDK)/app/test/autotest.py \\\n+\t\tpython3 $(RTE_SDK)/app/test/autotest.py \\\n \t\t\t$(RTE_OUTPUT)/app/test \\\n \t\t\t$(RTE_TARGET) \\\n \t\t\t$(BLACKLIST) $(WHITELIST) ; \\\n", "prefixes": [ "v4", "6/9" ] }