Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75037/?format=api
{ "id": 75037, "url": "http://patches.dpdk.org/api/patches/75037/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200730120900.108232-4-yang_y_yi@163.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200730120900.108232-4-yang_y_yi@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200730120900.108232-4-yang_y_yi@163.com", "date": "2020-07-30T12:09:00", "name": "[V1,3/3] vhost: use new free_cb interface to fix mbuf free issue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8a1dd25b349d28481804315d8543a80c81fa78d6", "submitter": { "id": 1806, "url": "http://patches.dpdk.org/api/people/1806/?format=api", "name": "yang_y_yi", "email": "yang_y_yi@163.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200730120900.108232-4-yang_y_yi@163.com/mbox/", "series": [ { "id": 11418, "url": "http://patches.dpdk.org/api/series/11418/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11418", "date": "2020-07-30T12:08:59", "name": "Fix external mbuf free issue in GSO case", "version": 1, "mbox": "http://patches.dpdk.org/series/11418/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75037/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/75037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 319C6A052B;\n\tThu, 30 Jul 2020 14:09:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9FFC61C00D;\n\tThu, 30 Jul 2020 14:09:09 +0200 (CEST)", "from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4])\n by dpdk.org (Postfix) with ESMTP id 7FFD910A3\n for <dev@dpdk.org>; Thu, 30 Jul 2020 14:09:04 +0200 (CEST)", "from yangyi0100.home.langchao.com (unknown [61.48.210.155])\n by smtp4 (Coremail) with SMTP id HNxpCgBXekNcuCJfZo1vIA--.3698S5;\n Thu, 30 Jul 2020 20:09:02 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=lFDu0\n tBdjS+Pgn1WClXzcYpD7IRxZ1x0v3sOwg3KcrI=; b=YWRNUYZJRlvWIshMTsyfq\n VrflWZUCmlLD0ORjK6CiPg46Ukckx9cYyoQbUNj943W5e927X0NIDtkY+IMmVaZy\n lMrVlwERYnYznZ4O0MPEtXUv4bi7iQ6Pt6cj8TiO88FRQYCrfTBaAZbvcprZYPaP\n 8obQxOGmomfljEgM+uif3U=", "From": "yang_y_yi@163.com", "To": "dev@dpdk.org", "Cc": "jiayu.hu@intel.com, thomas@monjalon.net, yangyi01@inspur.com,\n yang_y_yi@163.com", "Date": "Thu, 30 Jul 2020 20:09:00 +0800", "Message-Id": "<20200730120900.108232-4-yang_y_yi@163.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20200730120900.108232-1-yang_y_yi@163.com>", "References": "<20200730120900.108232-1-yang_y_yi@163.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "HNxpCgBXekNcuCJfZo1vIA--.3698S5", "X-Coremail-Antispam": "1Uf129KBjvJXoW7ZrWfXF1DZF1Utw4UArykAFb_yoW8Ar45pF\n 43Gry5Ar1rJr4xKrsxCr4fK3Z3Kayvk3W7CrZa9w1F9r4xX34xXFykKFWrur13Kr97Ar43\n XF40qF1UK3WUuFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jBeHgUUUUU=", "X-Originating-IP": "[61.48.210.155]", "X-CM-SenderInfo": "51dqwsp1b1xqqrwthudrp/1tbiqBBxi1c7RBg70AAAsZ", "Subject": "[dpdk-dev] [PATCH V1 3/3] vhost: use new free_cb interface to fix\n\tmbuf free issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yi Yang <yangyi01@inspur.com>\n\nNew free_cb interface can help fix original external\nmbuf free issue in GSO case, it still can be compatible\nwith normal non-GSO case. dpdkvhostuser port can work\nboth in GSO case and in non-GSO case by this fix.\n\nSigned-off-by: Yi Yang <yangyi01@inspur.com>\n---\n lib/librte_vhost/virtio_net.c | 22 +++++++++++++++++++---\n 1 file changed, 19 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex e663fd4..3b69cbb 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -2136,10 +2136,20 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,\n \treturn NULL;\n }\n \n+struct shinfo_arg {\n+\tvoid *buf;\n+\tstruct rte_mbuf *mbuf;\n+};\n+\n static void\n-virtio_dev_extbuf_free(struct rte_mbuf * caller_m __rte_unused, void *opaque)\n+virtio_dev_extbuf_free(struct rte_mbuf *caller_m, void *opaque)\n {\n-\trte_free(opaque);\n+\tstruct shinfo_arg *arg = (struct shinfo_arg *)opaque;\n+\n+\trte_free(arg->buf);\n+\tif (caller_m != arg->mbuf)\n+\t\trte_pktmbuf_free(arg->mbuf);\n+\trte_free(arg);\n }\n \n static int\n@@ -2172,8 +2182,14 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,\n \n \t/* Initialize shinfo */\n \tif (shinfo) {\n+\t\tstruct shinfo_arg *arg = (struct shinfo_arg *)\n+\t\t\trte_malloc(NULL, sizeof(struct shinfo_arg),\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\n+\t\targ->buf = buf;\n+\t\targ->mbuf = pkt;\n \t\tshinfo->free_cb = virtio_dev_extbuf_free;\n-\t\tshinfo->fcb_opaque = buf;\n+\t\tshinfo->fcb_opaque = arg;\n \t\trte_mbuf_ext_refcnt_set(shinfo, 1);\n \t} else {\n \t\tshinfo = rte_pktmbuf_ext_shinfo_init_helper(buf, &buf_len,\n", "prefixes": [ "V1", "3/3" ] }