Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75036/?format=api
{ "id": 75036, "url": "http://patches.dpdk.org/api/patches/75036/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200730120900.108232-2-yang_y_yi@163.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200730120900.108232-2-yang_y_yi@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200730120900.108232-2-yang_y_yi@163.com", "date": "2020-07-30T12:08:58", "name": "[V1,1/3] gso: fix refcnt update issue for external mbuf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ac60a4281a4d4100416a42ce0a1f5b4b2a38fba9", "submitter": { "id": 1806, "url": "http://patches.dpdk.org/api/people/1806/?format=api", "name": "yang_y_yi", "email": "yang_y_yi@163.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200730120900.108232-2-yang_y_yi@163.com/mbox/", "series": [ { "id": 11418, "url": "http://patches.dpdk.org/api/series/11418/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11418", "date": "2020-07-30T12:08:59", "name": "Fix external mbuf free issue in GSO case", "version": 1, "mbox": "http://patches.dpdk.org/series/11418/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75036/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/75036/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DFEFEA052B;\n\tThu, 30 Jul 2020 14:09:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D1862BC7;\n\tThu, 30 Jul 2020 14:09:08 +0200 (CEST)", "from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4])\n by dpdk.org (Postfix) with ESMTP id 7B7871023\n for <dev@dpdk.org>; Thu, 30 Jul 2020 14:09:04 +0200 (CEST)", "from yangyi0100.home.langchao.com (unknown [61.48.210.155])\n by smtp4 (Coremail) with SMTP id HNxpCgBXekNcuCJfZo1vIA--.3698S3;\n Thu, 30 Jul 2020 20:09:02 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Z0xEf\n AcIlG7UazUOoxO0z8+F9G+0Lb/6Ky1JI6Ak4OA=; b=iYx6B9EoNPcrE4+G7nHf0\n /0znqkPXhl/eYXTCpHLUBa20+cq0h47L99zCWSvKrLQYyfHMgqGPXcywbCBVu27R\n H5TgMzP3BrI6TSNYpFVRvEAKBnM36IOhIHjTKoFjrX136Is3l2jTd9dxOk0gRzBQ\n 1wZwsHCT2ONicWtY5cPK/k=", "From": "yang_y_yi@163.com", "To": "dev@dpdk.org", "Cc": "jiayu.hu@intel.com, thomas@monjalon.net, yangyi01@inspur.com,\n yang_y_yi@163.com", "Date": "Thu, 30 Jul 2020 20:08:58 +0800", "Message-Id": "<20200730120900.108232-2-yang_y_yi@163.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20200730120900.108232-1-yang_y_yi@163.com>", "References": "<20200730120900.108232-1-yang_y_yi@163.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "HNxpCgBXekNcuCJfZo1vIA--.3698S3", "X-Coremail-Antispam": "1Uf129KBjvdXoW7JF1rJrWruF1UGF4fAFyxZrb_yoWDKFc_ua\n 4FkF1ktay7Jr4xZw43Jw4Yga1xurW7Aa18Ww4Igw45Xr4qgFsxu34DJr42qFWDu3yUGFWx\n WF43uFn2yr1FvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8wSdDUUUUU==", "X-Originating-IP": "[61.48.210.155]", "X-CM-SenderInfo": "51dqwsp1b1xqqrwthudrp/xtbB0h5xi1UMX9eJ+wAAsV", "Subject": "[dpdk-dev] [PATCH V1 1/3] gso: fix refcnt update issue for external\n\tmbuf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yi Yang <yangyi01@inspur.com>\n\nrte_gso_segment will segment original mbuf to multiple\nsmall size mbufs, every mbuf of them has two segments,\nthe second segment will attach to original mbuf, if\noriginal mbuf is external, rte_gso_segment should update\nrefcnt of mbuf->shinfo but not refcnt of mbuf. Otherwise,\noriginal mbuf will be invalid on doing sanity check\nbecause refcnt of mbuf is 0.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\n\nSigned-off-by: Yi Yang <yangyi01@inspur.com>\n---\n lib/librte_gso/rte_gso.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c\nindex 751b5b6..b5e8b2a 100644\n--- a/lib/librte_gso/rte_gso.c\n+++ b/lib/librte_gso/rte_gso.c\n@@ -83,7 +83,10 @@\n \tif (ret > 1) {\n \t\tpkt_seg = pkt;\n \t\twhile (pkt_seg) {\n-\t\t\trte_mbuf_refcnt_update(pkt_seg, -1);\n+\t\t\tif (RTE_MBUF_HAS_EXTBUF(pkt_seg))\n+\t\t\t\trte_mbuf_ext_refcnt_update(pkt_seg->shinfo, -1);\n+\t\t\telse\n+\t\t\t\trte_mbuf_refcnt_update(pkt_seg, -1);\n \t\t\tpkt_seg = pkt_seg->next;\n \t\t}\n \t} else if (ret < 0) {\n", "prefixes": [ "V1", "1/3" ] }