Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74983/?format=api
{ "id": 74983, "url": "http://patches.dpdk.org/api/patches/74983/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200729082905.19499-4-ophirmu@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200729082905.19499-4-ophirmu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200729082905.19499-4-ophirmu@mellanox.com", "date": "2020-07-29T08:29:05", "name": "[v1,3/3] app/testpmd: reduce tunnel parsing code duplication", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1738a87c59bd466f030f8f7ff7e3bc87a0ee7393", "submitter": { "id": 793, "url": "http://patches.dpdk.org/api/people/793/?format=api", "name": "Ophir Munk", "email": "ophirmu@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200729082905.19499-4-ophirmu@mellanox.com/mbox/", "series": [ { "id": 11387, "url": "http://patches.dpdk.org/api/series/11387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11387", "date": "2020-07-29T08:29:02", "name": "Add GENEVE protocol parsing to testpmd", "version": 1, "mbox": "http://patches.dpdk.org/series/11387/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74983/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74983/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 18F62A052B;\n\tWed, 29 Jul 2020 10:29:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 845371C043;\n\tWed, 29 Jul 2020 10:29:28 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr30053.outbound.protection.outlook.com [40.107.3.53])\n by dpdk.org (Postfix) with ESMTP id BCCAE1C012\n for <dev@dpdk.org>; Wed, 29 Jul 2020 10:29:24 +0200 (CEST)", "from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22)\n by AM4PR05MB3204.eurprd05.prod.outlook.com (2603:10a6:205:3::33) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16; Wed, 29 Jul\n 2020 08:29:24 +0000", "from AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972]) by AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972%7]) with mapi id 15.20.3216.034; Wed, 29 Jul 2020\n 08:29:23 +0000", "from mellanox.com (37.142.13.130) by\n AM0PR05CA0079.eurprd05.prod.outlook.com (2603:10a6:208:136::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16 via Frontend\n Transport; Wed, 29 Jul 2020 08:29:23 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hmTzrCtPqky/Rf3GAXDQVOZWag9Q6/aXZ+knI7F7kaurdLP27btxQ8fJd440hfEDhCR8t9L8O28Ma/Ip4k4GtZZXHofmsXg1+YeHKkckZwYfSEy2tE/u362lc+iyGW1/1jGUUjs5Az4YJdxyYp6GzV8PU37ecY9P71aHCwr+9NdyETWrreMgdyYmBMqvuSoWmyTxyTpMffLHmUzr4+W2xMz7rUzV4v9fu1qo3Aibx6fNTLwGq0nERrskIN39kF8f0QyzjtxC0C1mZVHvPknqaxO+oWsq1UX54NJfGYUWgtJuhpni5aU7JKg6e+0lyseh4zxwG0axalkpG1VjBkFEpA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=biA0WEWOYCyN0HB8hxjvtoZrD8kPEnn0VHnL/ztRMMo=;\n b=HnoUebZfZnXPUylZvI+we1/LnHcbvuym2O6CdgSvE5IWFWT3dRMhXq/dnk/PctEVzuuvuAbfV8vCi9u8ZujcBMzWbiiUpzzTGsnxX1Tr6imMwJtvdPnXnSKy3TzLWgk152k26vUdVda08IWd2Bp/W7w2xOg5/WishFtIyMRsk/cVlXeKEAxzc5YBW4o5zeQ5mEiOR2Vgc2M2iiHNwE4IeQivR2lLsSNOrZ21ZQFumbhIMB6hEEC+IZModvA4RoHqzIrqIlTOSa0aJo1Qp3oPKOvcO33U5qXnddmXCoqEJmsr9Pw7pRSB0BouzWdR+jET0m07HnNwEj9xKzhlx+x9og==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=biA0WEWOYCyN0HB8hxjvtoZrD8kPEnn0VHnL/ztRMMo=;\n b=kVXtVUU0EoBecKu402rhpDIyNKRCvizj1zE87tJVIsYBIXmylIbwmtvQO0NuYRBJ71AgMl4HbKU5OmIH5uL/vZIXyQykOHEN3UmOglm4YIx5bfprUNonSpzTwxyA/1Bp0f7SDTZUN6kVDBIkKbta08JcjJLnO5dMdK7dvunX2zA=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Ophir Munk <ophirmu@mellanox.com>", "To": "dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Cc": "Ophir Munk <ophirmu@mellanox.com>", "Date": "Wed, 29 Jul 2020 08:29:05 +0000", "Message-Id": "<20200729082905.19499-4-ophirmu@mellanox.com>", "X-Mailer": [ "git-send-email 2.8.4", "git-send-email 2.8.4" ], "In-Reply-To": "<20200729082905.19499-1-ophirmu@mellanox.com>", "References": "<20200729082905.19499-1-ophirmu@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR05CA0079.eurprd05.prod.outlook.com\n (2603:10a6:208:136::19) To AM0PR05MB4209.eurprd05.prod.outlook.com\n (2603:10a6:208:61::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "6d0bd19c-c0c5-4eb4-fc4f-08d833997f9a", "X-MS-TrafficTypeDiagnostic": "AM4PR05MB3204:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM4PR05MB3204026450B5A15E711E4F1AD1700@AM4PR05MB3204.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:260;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n outxKYndi03QxJV4ZMfNrR59pUXLhgBIaKLMxEWAdNpiLG8EOfs2wDnGiNfqbDRoHzEv7HSr3ALeC0OK+JONSAUrgkF/QLizqszffWQZbpQ9z3+rrbWKPrfdGN+wnwIfqEXOkQ6mq5d7e3adrEMBUkUJi5Oamxl5og+mHy8+ci0wbh9IQ5h7ni45jd50F5Z9qoVohtli53w9g29c8y77frRDVTZF9gtzeDhJ9QPgmVf+2J+Cg08RsmIfpEEJtgMVqihOAui3WvqhrLXqeX71MD70kcaYjmUp86oZYhcxMPHafXf+kL/HiteAYJq6H8bQ8DExN1opvZvEQgK/f2J76g==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(66946007)(66556008)(66476007)(16526019)(478600001)(186003)(2906002)(1076003)(26005)(8676002)(8936002)(5660300002)(2616005)(956004)(83380400001)(316002)(110136005)(4326008)(36756003)(6666004)(8886007)(55016002)(107886003)(52116002)(7696005)(86362001);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n t4Z7/iABGMu8u5F6nxJoc21oyLHi/+LsTxYkOKkikocuO9w+s2V7eHfqs7ggjWeeTvbmX4qm0Av/6gwBmRhbSQUdFgn8lf/ObLYC9YXjimEdh/YhSHH3lfQSmTbuHg8I34JlAnS6dUYiR69UGD6QEmoJPBxLTPloT8CNUIaKWKwuOu1K0c9cFmIIAKfX36VIJ2iiZdn2fYB/+AMiasRR8Rx8tgEKRyLWxiVj96SYtnzxt1tFCv0mWCs8WRJaW8xoDzYB1HXrR94jqdQRL4i7N0sfI8veS1HpVaAQo2n5nHdOHduZs+aRqn8E+IKr8ByP/BnhRhXNrr/y223gjUiX4MuqiSGtZ0Jw+p4reoobjEIGQicNzXvutsLrdxlByEv4kPoiuB52rtYglWJT70v5kLKzp8ybrbM0JGo64OhwLzyIHjVmV1ktM1qOOhnf4SdTr0giXhj7kyvke3CK5f6Lp1alr/vAhYeQnD8kZxX4NehTZQgRgzr4/Oe6UjsaBbxdtMmtqSWjqk0TCPC+rDNSqMvn0QyFyLg8rdEOQsCpWQwzxc3BXL56TM9T22Y+OWCorouy5hb2NXgxHCif2/KaEI0WErYxy8TBhOwhe7xGGQxRNdNugeYZ7PTabMYzixtwhixY3Qot40jOIsYoTb/aTQ==", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6d0bd19c-c0c5-4eb4-fc4f-08d833997f9a", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4209.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Jul 2020 08:29:23.8790 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 0QhthoFaVQVNOPRCUE/VMwy216uotSLv8yUuGTy9gmCYyyYdwhACG1EMzUadfxYQhHK5keFZJhbeqdGBABmfNw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR05MB3204", "Subject": "[dpdk-dev] [PATCH v1 3/3] app/testpmd: reduce tunnel parsing code\n\tduplication", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is a cleanup commit. It assembles all tunnel outer updates into one\nfunction call to avoid code duplications.\nIt defines RTE_VXLAN_GPE_DEFAULT_PORT (4790) in accordance with all\nother tunnel protocol definitions.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\n---\n app/test-pmd/csumonly.c | 72 +++++++++++++---------------------------------\n lib/librte_net/rte_vxlan.h | 1 +\n 2 files changed, 21 insertions(+), 52 deletions(-)", "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 5f29868..3a0e46e 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -63,7 +63,7 @@\n #define _htons(x) (x)\n #endif\n \n-uint16_t vxlan_gpe_udp_port = 4790;\n+uint16_t vxlan_gpe_udp_port = RTE_VXLAN_GPE_DEFAULT_PORT;\n uint16_t geneve_udp_port = RTE_GENEVE_DEFAULT_PORT;\n \n /* structure that caches offload info for the current packet */\n@@ -181,6 +181,17 @@ parse_ethernet(struct rte_ether_hdr *eth_hdr, struct testpmd_offload_info *info)\n \t}\n }\n \n+/* Fill in outer layers length */\n+static void\n+update_tunnel_outer(struct testpmd_offload_info *info)\n+{\n+\tinfo->is_tunnel = 1;\n+\tinfo->outer_ethertype = info->ethertype;\n+\tinfo->outer_l2_len = info->l2_len;\n+\tinfo->outer_l3_len = info->l3_len;\n+\tinfo->outer_l4_proto = info->l4_proto;\n+}\n+\n /*\n * Parse a GTP protocol header.\n * No optional fields and next extension header type.\n@@ -201,11 +212,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,\n \t udp_hdr->dst_port != _htons(RTE_GTPU_UDP_PORT))\n \t\treturn;\n \n-\tinfo->is_tunnel = 1;\n-\tinfo->outer_ethertype = info->ethertype;\n-\tinfo->outer_l2_len = info->l2_len;\n-\tinfo->outer_l3_len = info->l3_len;\n-\tinfo->outer_l4_proto = info->l4_proto;\n+\tupdate_tunnel_outer(info);\n \tinfo->l2_len = 0;\n \n \tgtp_hdr = (struct rte_gtp_hdr *)((char *)udp_hdr +\n@@ -257,11 +264,7 @@ parse_vxlan(struct rte_udp_hdr *udp_hdr,\n \t\tRTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0)\n \t\treturn;\n \n-\tinfo->is_tunnel = 1;\n-\tinfo->outer_ethertype = info->ethertype;\n-\tinfo->outer_l2_len = info->l2_len;\n-\tinfo->outer_l3_len = info->l3_len;\n-\tinfo->outer_l4_proto = info->l4_proto;\n+\tupdate_tunnel_outer(info);\n \n \teth_hdr = (struct rte_ether_hdr *)((char *)udp_hdr +\n \t\tsizeof(struct rte_udp_hdr) +\n@@ -291,11 +294,7 @@ parse_vxlan_gpe(struct rte_udp_hdr *udp_hdr,\n \n \tif (!vxlan_gpe_hdr->proto || vxlan_gpe_hdr->proto ==\n \t RTE_VXLAN_GPE_TYPE_IPV4) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\tipv4_hdr = (struct rte_ipv4_hdr *)((char *)vxlan_gpe_hdr +\n \t\t\t vxlan_gpe_len);\n@@ -305,11 +304,7 @@ parse_vxlan_gpe(struct rte_udp_hdr *udp_hdr,\n \t\tinfo->l2_len = 0;\n \n \t} else if (vxlan_gpe_hdr->proto == RTE_VXLAN_GPE_TYPE_IPV6) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\tipv6_hdr = (struct rte_ipv6_hdr *)((char *)vxlan_gpe_hdr +\n \t\t\t vxlan_gpe_len);\n@@ -319,11 +314,7 @@ parse_vxlan_gpe(struct rte_udp_hdr *udp_hdr,\n \t\tinfo->l2_len = 0;\n \n \t} else if (vxlan_gpe_hdr->proto == RTE_VXLAN_GPE_TYPE_ETH) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\teth_hdr = (struct rte_ether_hdr *)((char *)vxlan_gpe_hdr +\n \t\t\t vxlan_gpe_len);\n@@ -335,17 +326,6 @@ parse_vxlan_gpe(struct rte_udp_hdr *udp_hdr,\n \tinfo->l2_len += RTE_ETHER_VXLAN_GPE_HLEN;\n }\n \n-/* Fill in outer layers length */\n-static void\n-update_tunnel_outer(struct testpmd_offload_info *info)\n-{\n-\tinfo->is_tunnel = 1;\n-\tinfo->outer_ethertype = info->ethertype;\n-\tinfo->outer_l2_len = info->l2_len;\n-\tinfo->outer_l3_len = info->l3_len;\n-\tinfo->outer_l4_proto = info->l4_proto;\n-}\n-\n /* Parse a geneve header */\n static void\n parse_geneve(struct rte_udp_hdr *udp_hdr,\n@@ -412,11 +392,7 @@ parse_gre(struct simple_gre_hdr *gre_hdr, struct testpmd_offload_info *info)\n \t\tgre_len += GRE_EXT_LEN;\n \n \tif (gre_hdr->proto == _htons(RTE_ETHER_TYPE_IPV4)) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\tipv4_hdr = (struct rte_ipv4_hdr *)((char *)gre_hdr + gre_len);\n \n@@ -425,11 +401,7 @@ parse_gre(struct simple_gre_hdr *gre_hdr, struct testpmd_offload_info *info)\n \t\tinfo->l2_len = 0;\n \n \t} else if (gre_hdr->proto == _htons(RTE_ETHER_TYPE_IPV6)) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\tipv6_hdr = (struct rte_ipv6_hdr *)((char *)gre_hdr + gre_len);\n \n@@ -438,11 +410,7 @@ parse_gre(struct simple_gre_hdr *gre_hdr, struct testpmd_offload_info *info)\n \t\tinfo->l2_len = 0;\n \n \t} else if (gre_hdr->proto == _htons(RTE_ETHER_TYPE_TEB)) {\n-\t\tinfo->is_tunnel = 1;\n-\t\tinfo->outer_ethertype = info->ethertype;\n-\t\tinfo->outer_l2_len = info->l2_len;\n-\t\tinfo->outer_l3_len = info->l3_len;\n-\t\tinfo->outer_l4_proto = info->l4_proto;\n+\t\tupdate_tunnel_outer(info);\n \n \t\teth_hdr = (struct rte_ether_hdr *)((char *)gre_hdr + gre_len);\n \ndiff --git a/lib/librte_net/rte_vxlan.h b/lib/librte_net/rte_vxlan.h\nindex c23c10c..2ad6061 100644\n--- a/lib/librte_net/rte_vxlan.h\n+++ b/lib/librte_net/rte_vxlan.h\n@@ -22,6 +22,7 @@ extern \"C\" {\n \n /** VXLAN default port. */\n #define RTE_VXLAN_DEFAULT_PORT 4789\n+#define RTE_VXLAN_GPE_DEFAULT_PORT 4790\n \n /**\n * VXLAN protocol header.\n", "prefixes": [ "v1", "3/3" ] }