Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74971/?format=api
{ "id": 74971, "url": "http://patches.dpdk.org/api/patches/74971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200729063105.11299-3-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200729063105.11299-3-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200729063105.11299-3-feifei.wang2@arm.com", "date": "2020-07-29T06:31:05", "name": "[v1,2/2] test/ring: fix wrong param passed to the enqueue APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eafaafc24ec20a2e6b9cd68be83d517a5a09f7c5", "submitter": { "id": 1771, "url": "http://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200729063105.11299-3-feifei.wang2@arm.com/mbox/", "series": [ { "id": 11378, "url": "http://patches.dpdk.org/api/series/11378/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11378", "date": "2020-07-29T06:31:03", "name": "wrong pointer passed of ring", "version": 1, "mbox": "http://patches.dpdk.org/series/11378/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74971/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2401BA052B;\n\tWed, 29 Jul 2020 08:31:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 097E41C02E;\n\tWed, 29 Jul 2020 08:31:45 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 9E1C71C023;\n Wed, 29 Jul 2020 08:31:43 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24D561FB;\n Tue, 28 Jul 2020 23:31:43 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.213])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8764C3F71F;\n Tue, 28 Jul 2020 23:31:40 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Gavin Hu <gavin.hu@arm.com>, Olivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n stable@dpdk.org", "Date": "Wed, 29 Jul 2020 01:31:05 -0500", "Message-Id": "<20200729063105.11299-3-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200729063105.11299-1-feifei.wang2@arm.com>", "References": "<20200729063105.11299-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the\n\tenqueue APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When enqueue one element (object of type void*) to ring in the\nperformance test, a pointer (the object to be enqueued) should be\npassed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table\nof void *pointers (objects).\n\nFixes: a9fe152363e2 (\"test/ring: add custom element size functional tests\")\nCc: honnappa.nagarahalli@arm.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_ring.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_ring.h b/app/test/test_ring.h\nindex aa6ae67ca..d4b15af7c 100644\n--- a/app/test/test_ring.h\n+++ b/app/test/test_ring.h\n@@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int esize, unsigned int n,\n \tif ((esize) == -1)\n \t\tswitch (api_type) {\n \t\tcase (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE):\n-\t\t\treturn rte_ring_enqueue(r, obj);\n+\t\t\treturn rte_ring_enqueue(r, *obj);\n \t\tcase (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE):\n-\t\t\treturn rte_ring_sp_enqueue(r, obj);\n+\t\t\treturn rte_ring_sp_enqueue(r, *obj);\n \t\tcase (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE):\n-\t\t\treturn rte_ring_mp_enqueue(r, obj);\n+\t\t\treturn rte_ring_mp_enqueue(r, *obj);\n \t\tcase (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK):\n \t\t\treturn rte_ring_enqueue_bulk(r, obj, n, NULL);\n \t\tcase (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK):\n", "prefixes": [ "v1", "2/2" ] }