Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74958/?format=api
{ "id": 74958, "url": "http://patches.dpdk.org/api/patches/74958/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728191330.20864-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728191330.20864-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728191330.20864-5-stephen@networkplumber.org", "date": "2020-07-28T19:13:26", "name": "[v5,4/8] app/proc-info: add more info to show_ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fc0dfc139d0f6ed9cea3353b05ba9b39e358066c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728191330.20864-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 11371, "url": "http://patches.dpdk.org/api/series/11371/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11371", "date": "2020-07-28T19:13:22", "name": "app/proc-info enhancements", "version": 5, "mbox": "http://patches.dpdk.org/series/11371/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74958/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D070A052B;\n\tTue, 28 Jul 2020 21:14:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 159111C0AC;\n\tTue, 28 Jul 2020 21:13:53 +0200 (CEST)", "from mail-pj1-f67.google.com (mail-pj1-f67.google.com\n [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 1DEF41C00D\n for <dev@dpdk.org>; Tue, 28 Jul 2020 21:13:48 +0200 (CEST)", "by mail-pj1-f67.google.com with SMTP id lx9so454424pjb.2\n for <dev@dpdk.org>; Tue, 28 Jul 2020 12:13:48 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x66sm19045748pgb.12.2020.07.28.12.13.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Jul 2020 12:13:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=aqlSZ9jLKuxEHylb3JSTjYPwvQoT1r6AkVy+DoW0hBM=;\n b=F26NHpbckhfZEsUrSP5Za955Sjevs8dJMTQjoVf5PjFc6tRfmsKVQnqZ1WQA5Y7UXs\n fa4HkZ7nq3oSpmBAQCScwRDls397k78DW3z3yuWt66MNZnmK21zEckmIrxZjDbhNVGcK\n Eio472CE4DEGuMlPaVtMI1IVf+q+CnF/h8DQVp9ZnJk4yZhni/fHDFHfRK+4KWXSS/V8\n 1XOVsfpAA2T85CjgDkPJH6kjq3H7edYAXNLD+dSxm+iZXkj5Z841MB87GbtgAgq0e1ce\n y/iMC4Yz3eGe7hqhzyErZxqskfMk4fGyc5XJl4YSjcKcdUfsVwQzhgGSfqhGKYOnS1mk\n qgAw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=aqlSZ9jLKuxEHylb3JSTjYPwvQoT1r6AkVy+DoW0hBM=;\n b=DYa0G3ZN6WIV73MqOBoUArHwwy1ac6axgEsFWKP1qbqmpeSLFvcemqvswnCPwXZ8YR\n UwZgQN9bsEp6e/y0JKv+HbhuW8rJEgp4VTxAAJw34qagADz5GQwDvp8eY/WoKxlNgLWQ\n KYrFUGhIE+sRU3YlKXfCpccnJcK86khiS2M4RiTRXC9KpLewifS77Bd/hQeT4hExkvHn\n IlbkwS5WJ3Nl7uNzFQIZ7zHTG8uNCGlIwJ22eOO36Bu5tLZqIeRu8NqIFs1QSteRm2un\n JUKYJCiE5cdW5sRy5TTpa7+JU+A9kozra2TSLeE2jEHGYV52siEVpUjiMJMhPQ8smny4\n p8pw==", "X-Gm-Message-State": "AOAM532VslcEH0etHtlF2N0NPw52FECPF/qMclaoNWKSg/PGjaqWHrGb\n h3PUmsMgeUf+ff4RmIkFwupXh2EZqpC74A==", "X-Google-Smtp-Source": "\n ABdhPJzO7giEyWS3vU38b30CiypG7h+L2t/SwoHInE5tkgvmF3QNrkJlz1Am7cq83dV4Lc8CVkDiEA==", "X-Received": "by 2002:a17:90b:3713:: with SMTP id\n mg19mr5735503pjb.3.1595963626852;\n Tue, 28 Jul 2020 12:13:46 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 28 Jul 2020 12:13:26 -0700", "Message-Id": "<20200728191330.20864-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200728191330.20864-1-stephen@networkplumber.org>", "References": "<20200506193741.24117-1-stephen@networkplumber.org>\n <20200728191330.20864-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 4/8] app/proc-info: add more info to show_ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Revise the display of port information to include more data\nand be more human friendly.\n\n * Display units for port speed, and decode link fields.\n * Show driver and device information\n * Show MAC address\n * Show flow control information\n * Combine lines if possible\n * Show all multicast mode\n * Show queue mempool name\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n app/proc-info/main.c | 100 +++++++++++++++++++++++++++++++++----------\n 1 file changed, 78 insertions(+), 22 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex e4914191bef9..28838be882b9 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -669,6 +669,8 @@ show_port(void)\n \t\tstruct rte_eth_dev_info dev_info;\n \t\tstruct rte_eth_rxq_info queue_info;\n \t\tstruct rte_eth_rss_conf rss_conf;\n+\t\tstruct rte_eth_fc_conf fc_conf;\n+\t\tstruct rte_ether_addr mac;\n \n \t\tmemset(&rss_conf, 0, sizeof(rss_conf));\n \n@@ -676,32 +678,86 @@ show_port(void)\n \t\tSTATS_BDR_STR(5, bdr_str);\n \t\tprintf(\" - generic config\\n\");\n \n-\t\tprintf(\"\\t -- Socket %d\\n\", rte_eth_dev_socket_id(i));\n+\t\tret = rte_eth_dev_info_get(i, &dev_info);\n+\t\tif (ret != 0) {\n+\t\t\tprintf(\"Error during getting device info: %s\\n\",\n+\t\t\t\tstrerror(-ret));\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tprintf(\"\\t -- driver %s device %s socket %d\\n\",\n+\t\t dev_info.driver_name, dev_info.device->name,\n+\t\t rte_eth_dev_socket_id(i));\n+\n \t\tret = rte_eth_link_get(i, &link);\n \t\tif (ret < 0) {\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\tuint32_t speed = link.link_speed;\n+\t\t\tchar suffix = 'M';\n+\t\t\tconst char *duplex, *autoneg, *status;\n+\n+\t\t\tif (speed > 1000) {\n+\t\t\t\tsuffix = 'G';\n+\t\t\t\tspeed /= 1000;\n+\t\t\t}\n+\n+\t\t\tif (link.link_duplex == ETH_LINK_FULL_DUPLEX)\n+\t\t\t\tduplex = \"full\";\n+\t\t\telse\n+\t\t\t\tduplex = \"half\";\n+\n+\t\t\tif (link.link_autoneg == ETH_LINK_AUTONEG)\n+\t\t\t\tautoneg = \"auto neg\";\n+\t\t\telse\n+\t\t\t\tautoneg = \"fixed\";\n+\n+\t\t\tif (link.link_status == ETH_LINK_UP)\n+\t\t\t\tstatus = \"up\";\n+\t\t\telse\n+\t\t\t\tstatus = \"down\";\n+\n+\t\t\tprintf(\"\\t -- link speed %u%cbps (%s), duplex %s, %s\\n\",\n+\t\t\t speed, suffix, autoneg, duplex, status);\n+\t\t}\n+\n+\t\tret = rte_eth_dev_flow_ctrl_get(i, &fc_conf);\n+\t\tif (ret == 0 && fc_conf.mode != RTE_FC_NONE) {\n+\t\t\tprintf(\"\\t -- flow control mode %s%s high %u low %u pause %u%s%s\\n\",\n+\t\t\t fc_conf.mode == RTE_FC_RX_PAUSE ? \"rx \" :\n+\t\t\t fc_conf.mode == RTE_FC_TX_PAUSE ? \"tx \" :\n+\t\t\t fc_conf.mode == RTE_FC_FULL ? \"full\" : \"???\",\n+\t\t\t fc_conf.autoneg ? \" auto\" : \"\",\n+\t\t\t fc_conf.high_water,\n+\t\t\t fc_conf.low_water,\n+\t\t\t fc_conf.pause_time,\n+\t\t\t fc_conf.send_xon ? \" xon\" : \"\",\n+\t\t\t fc_conf.mac_ctrl_frame_fwd ? \" mac_ctrl\" : \"\");\n \t\t}\n-\t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n-\t\t\t\trte_eth_promiscuous_get(i));\n+\n+\t\tret = rte_eth_macaddr_get(i, &mac);\n+\t\tif (ret == 0) {\n+\t\t\tchar ebuf[RTE_ETHER_ADDR_FMT_SIZE];\n+\t\t\trte_ether_format_addr(ebuf, sizeof(ebuf), &mac);\n+\t\t\tprintf(\"\\t -- mac %s\\n\", ebuf);\n+\t\t}\n+\n+\n+\t\tret = rte_eth_promiscuous_get(i);\n+\t\tif (ret >= 0)\n+\t\t\tprintf(\"\\t -- promiscuous mode %s\\n\",\n+\t\t\t ret > 0 ? \"enabled\" : \"disabled\");\n+\n+\t\tret = rte_eth_allmulticast_get(i);\n+\t\tif (ret >= 0)\n+\t\t\tprintf(\"\\t -- all multicast mode %s\\n\",\n+\t\t\t ret > 0 ? \"enabled\" : \"disabled\");\n+\n \t\tret = rte_eth_dev_get_mtu(i, &mtu);\n \t\tif (ret == 0)\n \t\t\tprintf(\"\\t -- mtu (%d)\\n\", mtu);\n \n-\t\tret = rte_eth_dev_info_get(i, &dev_info);\n-\t\tif (ret != 0) {\n-\t\t\tprintf(\"Error during getting device (port %u) info: %s\\n\",\n-\t\t\t\ti, strerror(-ret));\n-\t\t\treturn;\n-\t\t}\n-\n \t\tprintf(\" - queue\\n\");\n \t\tfor (j = 0; j < dev_info.nb_rx_queues; j++) {\n \t\t\tret = rte_eth_rx_queue_info_get(i, j, &queue_info);\n@@ -709,12 +765,12 @@ show_port(void)\n \t\t\t\tprintf(\"\\t -- queue %d rx scatter %d\"\n \t\t\t\t\t\t\" descriptors %d\"\n \t\t\t\t\t\t\" offloads 0x%\"PRIx64\n-\t\t\t\t\t\t\" mempool socket %d\\n\",\n-\t\t\t\t\t\tj,\n-\t\t\t\t\t\tqueue_info.scattered_rx,\n-\t\t\t\t\t\tqueue_info.nb_desc,\n-\t\t\t\t\t\tqueue_info.conf.offloads,\n-\t\t\t\t\t\tqueue_info.mp->socket_id);\n+\t\t\t\t\t\t\" mempool name %s socket %d\\n\",\n+\t\t\t\t j, queue_info.scattered_rx,\n+\t\t\t\t queue_info.nb_desc,\n+\t\t\t\t queue_info.conf.offloads,\n+\t\t\t\t queue_info.mp->name,\n+\t\t\t\t queue_info.mp->socket_id);\n \t\t\t}\n \t\t}\n \n", "prefixes": [ "v5", "4/8" ] }