Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74956/?format=api
{ "id": 74956, "url": "http://patches.dpdk.org/api/patches/74956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728191330.20864-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728191330.20864-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728191330.20864-3-stephen@networkplumber.org", "date": "2020-07-28T19:13:24", "name": "[v5,2/8] app/proc-info: eliminate useless borders", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f3f83a0df40e79128db1de1aa0c308e1408c58b", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728191330.20864-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 11371, "url": "http://patches.dpdk.org/api/series/11371/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11371", "date": "2020-07-28T19:13:22", "name": "app/proc-info enhancements", "version": 5, "mbox": "http://patches.dpdk.org/series/11371/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74956/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 93060A052B;\n\tTue, 28 Jul 2020 21:14:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 437C01C012;\n\tTue, 28 Jul 2020 21:13:48 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 9D8EC1BFF3\n for <dev@dpdk.org>; Tue, 28 Jul 2020 21:13:45 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id z188so3656139pfc.6\n for <dev@dpdk.org>; Tue, 28 Jul 2020 12:13:45 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x66sm19045748pgb.12.2020.07.28.12.13.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Jul 2020 12:13:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=1iSNtlfJy6gteAYsSYrqpxFpYkOwC+ZDBEYUD2FQ/IY=;\n b=q73f+Y/b34Sjak12zJprqloRQr7zM7IFzZw2hup35H9VzW2WotuPwJWLhZ0/0pYJTU\n z6d/putCSMCI27i4qSmHGyv0WQSLMiuYHG0RKt+YH1o1NyPfSdjOq9gtYb7jQzT93DuY\n VDpO1C+lbe3BEGiAT8K65338eWnR83kVuAvzbpCR6KWvLSXClpVGOXliMgzvbw9EOK2I\n o1werQtzN4PPN3OItuGW2IRpm5fxMrhh8dkJE517FCGTM5ZPwWXw9Jp/DdbTHn9NBDDr\n j28vgU0aritPkLTU/InsqL4Z+/yh7JwMmH/Z0gDaHySgWknsWj2jK8jqGzBmCywaicev\n keeQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=1iSNtlfJy6gteAYsSYrqpxFpYkOwC+ZDBEYUD2FQ/IY=;\n b=Ae9NHv03KrTJb8IE2vbvtrPE5NFDH48N49A/F32H0I5bmkIaeK+fltoytKQqBgACqU\n 40N/20eTS+jeydcquad7gQ0Qw2liBR8L/k/nxsi57Kjrga23qpTb20n0wg8e4rHCiecx\n 15iLDH8xFz2WS3DkHf2s3tXFiEPjLc844ganqot8UF+uMl/KuvmwOrG1jXedAwQm8Hx+\n KMlPtHq3ksV3LyeVJy3UF3SNpxOOO5urVu4JcIgsHhz7rxn21C0Po2DpsRTkj0iGf4u7\n 4gd6iH/ilwKp/4W68y1L1STxH9acZ0rxmKcarhcOhp8o5CjYeLY8eassl1F3Ufa86o4c\n tonQ==", "X-Gm-Message-State": "AOAM531s76ZWS5ft/gUa//tlW52tUspHDPmwChh+yE6BcwqU8f5/T5vM\n PXjycAHNoiBsbFKRoTrE/2EgQIIHeXp7Hg==", "X-Google-Smtp-Source": "\n ABdhPJzrKLRxUnUzO9hnP6rCQv6b9SAbkVUgq8jIbD7V5OhQMhvIsF8jELW0hAonftbOO5ZcB01P9A==", "X-Received": "by 2002:a63:182:: with SMTP id 124mr24286309pgb.288.1595963624114;\n Tue, 28 Jul 2020 12:13:44 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 28 Jul 2020 12:13:24 -0700", "Message-Id": "<20200728191330.20864-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200728191330.20864-1-stephen@networkplumber.org>", "References": "<20200506193741.24117-1-stephen@networkplumber.org>\n <20200728191330.20864-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 2/8] app/proc-info: eliminate useless borders", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Printing extra borders does not improve readability, and is just\nunnecessary. Putting TSC hz in header also makes no sense here.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n app/proc-info/main.c | 35 +++++++----------------------------\n 1 file changed, 7 insertions(+), 28 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex 69e3000616c0..049818bad51f 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -660,8 +660,7 @@ show_port(void)\n \tuint16_t i = 0;\n \tint ret = 0, j, k;\n \n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - Port PMD %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - Port PMD \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tRTE_ETH_FOREACH_DEV(i) {\n@@ -673,7 +672,7 @@ show_port(void)\n \n \t\tmemset(&rss_conf, 0, sizeof(rss_conf));\n \n-\t\tsnprintf(bdr_str, MAX_STRING_LEN, \" Port (%u)\", i);\n+\t\tsnprintf(bdr_str, MAX_STRING_LEN, \" Port %u \", i);\n \t\tSTATS_BDR_STR(5, bdr_str);\n \t\tprintf(\" - generic config\\n\");\n \n@@ -754,8 +753,6 @@ show_port(void)\n \t\t}\n #endif\n \t}\n-\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n static void\n@@ -841,8 +838,7 @@ show_tm(void)\n \tunsigned int j, k;\n \tuint16_t i = 0;\n \n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - TM PMD %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - TM PMD \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tRTE_ETH_FOREACH_DEV(i) {\n@@ -1038,8 +1034,6 @@ show_tm(void)\n \t\t\t\tstats.leaf.n_bytes_dropped[RTE_COLOR_RED]);\n \t\t}\n \t}\n-\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n static void\n@@ -1085,8 +1079,7 @@ show_crypto(void)\n {\n \tuint8_t crypto_dev_count = rte_cryptodev_count(), i;\n \n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - CRYPTO PMD %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - CRYPTO PMD \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tfor (i = 0; i < crypto_dev_count; i++) {\n@@ -1121,15 +1114,12 @@ show_crypto(void)\n \t\t\t\tstats.dequeue_err_count);\n \t\t}\n \t}\n-\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n static void\n show_ring(char *name)\n {\n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - RING %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - RING \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tif (name != NULL) {\n@@ -1160,7 +1150,6 @@ show_ring(char *name)\n \t}\n \n \trte_ring_list_dump(stdout);\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n static void\n@@ -1168,8 +1157,7 @@ show_mempool(char *name)\n {\n \tuint64_t flags = 0;\n \n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - MEMPOOL %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" show - MEMPOOL \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tif (name != NULL) {\n@@ -1206,13 +1194,11 @@ show_mempool(char *name)\n \t\t\t\trte_mempool_avail_count(ptr),\n \t\t\t\trte_mempool_in_use_count(ptr));\n \n-\t\t\tSTATS_BDR_STR(50, \"\");\n \t\t\treturn;\n \t\t}\n \t}\n \n \trte_mempool_list_dump(stdout);\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n static void\n@@ -1230,8 +1216,7 @@ mempool_itr_obj(struct rte_mempool *mp, void *opaque,\n static void\n iter_mempool(char *name)\n {\n-\tsnprintf(bdr_str, MAX_STRING_LEN, \" iter - MEMPOOL %\"PRIu64,\n-\t\t\trte_get_tsc_hz());\n+\tsnprintf(bdr_str, MAX_STRING_LEN, \" iter - MEMPOOL \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n \tif (name != NULL) {\n@@ -1241,12 +1226,9 @@ iter_mempool(char *name)\n \t\t\tuint32_t ret = rte_mempool_obj_iter(ptr,\n \t\t\t\t\tmempool_itr_obj, NULL);\n \t\t\tprintf(\"\\n - iterated %u objects\\n\", ret);\n-\t\t\tSTATS_BDR_STR(50, \"\");\n \t\t\treturn;\n \t\t}\n \t}\n-\n-\tSTATS_BDR_STR(50, \"\");\n }\n \n int\n@@ -1347,8 +1329,5 @@ main(int argc, char **argv)\n \tif (ret)\n \t\tprintf(\"Error from rte_eal_cleanup(), %d\\n\", ret);\n \n-\tstrlcpy(bdr_str, \" \", MAX_STRING_LEN);\n-\tSTATS_BDR_STR(50, bdr_str);\n-\n \treturn 0;\n }\n", "prefixes": [ "v5", "2/8" ] }