Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74936/?format=api
{ "id": 74936, "url": "http://patches.dpdk.org/api/patches/74936/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9b51e0a97aa6be6c9e64ed4f1e7cc1a2f0553f4d.1595936682.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9b51e0a97aa6be6c9e64ed4f1e7cc1a2f0553f4d.1595936682.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9b51e0a97aa6be6c9e64ed4f1e7cc1a2f0553f4d.1595936682.git.wangyunjian@huawei.com", "date": "2020-07-28T13:11:12", "name": "[1/2] net/ice: fix memory leak when releasing vsi", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a66627949b7d97b2b0e5febed18bb94fd6922f8d", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9b51e0a97aa6be6c9e64ed4f1e7cc1a2f0553f4d.1595936682.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 11360, "url": "http://patches.dpdk.org/api/series/11360/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11360", "date": "2020-07-28T13:10:36", "name": "fixes for ice driver", "version": 1, "mbox": "http://patches.dpdk.org/series/11360/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74936/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 601C8A052B;\n\tTue, 28 Jul 2020 15:11:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D9C21C00E;\n\tTue, 28 Jul 2020 15:11:33 +0200 (CEST)", "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id 056531C00D;\n Tue, 28 Jul 2020 15:11:31 +0200 (CEST)", "from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 1191393690DB0E73F2E4;\n Tue, 28 Jul 2020 21:11:29 +0800 (CST)", "from localhost (10.174.185.168) by DGGEMS405-HUB.china.huawei.com\n (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 28 Jul 2020\n 21:11:18 +0800" ], "From": "wangyunjian <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<qiming.yang@intel.com>, <qi.z.zhang@intel.com>,\n <jerry.lilijun@huawei.com>, <xudingke@huawei.com>, Yunjian Wang\n <wangyunjian@huawei.com>, <stable@dpdk.org>", "Date": "Tue, 28 Jul 2020 21:11:12 +0800", "Message-ID": "\n <9b51e0a97aa6be6c9e64ed4f1e7cc1a2f0553f4d.1595936682.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "In-Reply-To": "<cover.1595936682.git.wangyunjian@huawei.com>", "References": "<cover.1595936682.git.wangyunjian@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.185.168]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/ice: fix memory leak when releasing vsi", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nAt the end of the vsi release, we should free the 'rss_lut'\nand 'rss_key' for the vsi.\n\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/ice/ice_ethdev.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 3534d18ca..5f3882826 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2280,9 +2280,10 @@ ice_release_vsi(struct ice_vsi *vsi)\n \tstruct ice_hw *hw;\n \tstruct ice_vsi_ctx vsi_ctx;\n \tenum ice_status ret;\n+\tint error = 0;\n \n \tif (!vsi)\n-\t\treturn 0;\n+\t\treturn error;\n \n \thw = ICE_VSI_TO_HW(vsi);\n \n@@ -2295,12 +2296,13 @@ ice_release_vsi(struct ice_vsi *vsi)\n \tret = ice_free_vsi(hw, vsi->idx, &vsi_ctx, false, NULL);\n \tif (ret != ICE_SUCCESS) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to free vsi by aq, %u\", vsi->vsi_id);\n-\t\trte_free(vsi);\n-\t\treturn -1;\n+\t\terror = -1;\n \t}\n \n+\trte_free(vsi->rss_lut);\n+\trte_free(vsi->rss_key);\n \trte_free(vsi);\n-\treturn 0;\n+\treturn error;\n }\n \n void\n", "prefixes": [ "1/2" ] }