Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74932/?format=api
{ "id": 74932, "url": "http://patches.dpdk.org/api/patches/74932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728115406.20141-1-ophirmu@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728115406.20141-1-ophirmu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728115406.20141-1-ophirmu@mellanox.com", "date": "2020-07-28T11:54:06", "name": "[v1] net/mlx4: return EAGAIN on premature disable interrupt calls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ef8b2047013eda3eaab5420f51e2554755eeb17c", "submitter": { "id": 793, "url": "http://patches.dpdk.org/api/people/793/?format=api", "name": "Ophir Munk", "email": "ophirmu@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728115406.20141-1-ophirmu@mellanox.com/mbox/", "series": [ { "id": 11357, "url": "http://patches.dpdk.org/api/series/11357/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11357", "date": "2020-07-28T11:54:06", "name": "[v1] net/mlx4: return EAGAIN on premature disable interrupt calls", "version": 1, "mbox": "http://patches.dpdk.org/series/11357/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74932/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F6BEA052B;\n\tTue, 28 Jul 2020 13:54:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAF882B9C;\n\tTue, 28 Jul 2020 13:54:23 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46])\n by dpdk.org (Postfix) with ESMTP id 71CC623D\n for <dev@dpdk.org>; Tue, 28 Jul 2020 13:54:22 +0200 (CEST)", "from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22)\n by AM0PR05MB6065.eurprd05.prod.outlook.com (2603:10a6:208:133::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.22; Tue, 28 Jul\n 2020 11:54:21 +0000", "from AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972]) by AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972%7]) with mapi id 15.20.3216.034; Tue, 28 Jul 2020\n 11:54:21 +0000", "from mellanox.com (37.142.13.130) by\n AM0PR10CA0118.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::35) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.21 via Frontend Transport; Tue, 28 Jul 2020 11:54:20 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Zr7xTITy53Pe3XH9owA+bttu+lB9eVJW1w6bAGO/WBG1JZSzIVi2sBhObXS9jE+zb9DumJdT2U3VY+ritSRx+L6Hmxr9KtFn6KY4keVstOKPspN8KwpfhxQeI27awX+EMdTkwyFdzpzdINK/bv8B1Y0hnNh5MJkXw8v5t6b3GebMi/61p4ItRizeNeR/29ppBw4HC5c7p/nUP1ZFXJ2obT/lT/u+zmh0gfRDZhhqcFTeRH8KcyhPlfz5Alfa181Y/5hurkZs5X6M9KyUQj0IqVdh90PGx6V3bpKeO9pSBJTB/cEJZNsM9ZuJxbACSwFpeCboKsEFOa58rIlgfgJdIQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jw3x2C7e+M1UsOYTSg9nlX/n1AgaQkvTkfSBMeNEK5k=;\n b=m4+KdYQd7oAk7Y81k2wiuIqSK0qF6QZbN8crxbS+c72EHxqJRDMmi3PsyxMCaDplpa5FCKajxAKDCcH9od/iywMMWcqhiCV+W2M2jlrKk3d3j2PStgmT8e5Wv/M7Fwc7fqq+OahFsUMbXwN+qXe6dQjBBlDHFK7vEALjzjleR8Gz9eqr5hW+RJRSgLdl2/hGwVh1TSPpV1GS2aixUpK6cQwMS/f0/NJBgNTOJaUgURuhFA7VUyF4HJGHPTyti5T/nL2qMVW+9ZGXG8xHI+zKWv1RJD2AXxQeplbwJMWBQTn3IIbqQLkjhmsxdnvEioG1BlvTxuQP7KzCIML/tn6f1w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jw3x2C7e+M1UsOYTSg9nlX/n1AgaQkvTkfSBMeNEK5k=;\n b=SaeDz+CBQ0ynGdInertepbglzpGw2el2Wkd4vFDlSSiCf2JJFkj3z/jlkIB2gZ4HpcPbAew79N0bOdpBpeXdIi0xzGQ7V74F3rAJCnd22iTvYP0mvDydcP0/8XtVHvIlcNM1Qc4MkZnQgWPmGiUx5Sb8n0nDftDWSQZr5P3tZLo=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Ophir Munk <ophirmu@mellanox.com>", "To": "dev@dpdk.org", "Cc": "Raslan Darawsheh <rasland@mellanox.com>,\n Ophir Munk <ophirmu@mellanox.com>,\n Matan Azrad <matan@mellanox.com>", "Date": "Tue, 28 Jul 2020 11:54:06 +0000", "Message-Id": "<20200728115406.20141-1-ophirmu@mellanox.com>", "X-Mailer": [ "git-send-email 2.8.4", "git-send-email 2.8.4" ], "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR10CA0118.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:208:e6::35) To AM0PR05MB4209.eurprd05.prod.outlook.com\n (2603:10a6:208:61::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "0c1b69e2-ce87-4783-e8b5-08d832ecf71c", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB6065:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB606550A9406F087FBA3D534DD1730@AM0PR05MB6065.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8882;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n wiabsVs1osY5gjdfhynVxKkg8NCOqnGs6bH8StzFpzqSneuIxWRFySwBJNjERYx1IXUJAg5ND1US1YBD31xXmufiHbcER7pSWTEzPW66KSRKo64yTtyzbkrDx4AFE9xCkVEaUl0MZVmBrNbTV5B7S5DZe7k0M4yFI6bQ6Bo2ZAzMceMq2iP4R0Ot4PlP4RM0t7bdVqMqKs6F/GyyD8eu6jSZXKe1fPacXieU8+j5G1liLQi2LIPRJs0eeZIEyOISZpu12jYol/J7EQboRW0+QyIXh/9JVjNRfL/SKTGb8kdIrCwPofIk7imvCTP/30BpBY6qnoWNyONgP/LxHvfgag==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(55016002)(478600001)(4326008)(316002)(107886003)(2906002)(8936002)(54906003)(8676002)(2616005)(83380400001)(66476007)(66946007)(6916009)(6666004)(5660300002)(26005)(16526019)(186003)(8886007)(1076003)(7696005)(52116002)(66556008)(956004)(86362001)(36756003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n YbdZaqJzKH0AyFZNAXZpvLXgYHF71NyjUUaibyAYquH11YBAB7ry1fi4GZ/w5kZK+uiEGFzHMMqW17P866Id7deyhBFS0SWjpsHIRa9AyMreYPssAsPKYMbqJCuIbvY6v32NOT9Ywvs7xdg8yxb6oghawxLgHgbOM/BjDRN7jcH9PlKPo9QFYxXzHBdRTaehQQcmU3E0kIwBRio6sicoThLGc+W35I5y366NTJ9OV2Ks8/B4iLRYcOph4NZoMZU6ieWk/xRWk56/jkYjyIJR5Z4Si2g8DL00i8BQ2jRyWdAYshdvk6Gc4Hv/LC611uw5+0iC5Ohy2Wcc9c3QJWDThJ6ubNnm6gEjC+1m8kCOTfKeHqc7JYKj8FAQeyDsrQyMZZ5Pv+wrsr8Rupu/HkwaYf8ZRhThDaiUwS4RzrVHC4f6IR3yZM1swnUc0cs+cz+WTMmrmvbmmpvgRqaHwpvjSY4dLpb5VHDLb0X++ScSaIY=", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0c1b69e2-ce87-4783-e8b5-08d832ecf71c", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4209.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Jul 2020 11:54:21.4671 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n II9V4JJaLxk/vR8vXz2H9sQVl1t0n2AVg1s6pDeEVEBKhwFsPnuprqcAbi6htzZATZFbZhU7Q/sydVoE7/dcYQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB6065", "Subject": "[dpdk-dev] [PATCH v1] net/mlx4: return EAGAIN on premature disable\n\tinterrupt calls", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RXQ interrupts under Linux are based on the epoll mechanism. An\nexpected order of operations is as follows:\n1. Call rte_eth_dev_rx_intr_enable(), to arm the CQ for receiving events\non data input.\n2. Block on rte_epoll_wait() with an array of file descriptors\nrepresenting the CQ events. Upon data arrival the kernel will signal an\ninput event on the corresponding CQ fd.\n3. Call rte_eth_dev_rx_intr_disable() after the event was received and\ncontinue in polling mode. The mlx4 implementation of\nrte_eth_dev_rx_intr_disable() is to get the CQ event and ack it.\n\nIn practice applications may wake up from rte_epoll_wait() due to\ntimeout with no event to ack but still call\nrte_eth_dev_rx_intr_disable() unconditionally. In such cases the call\nshould return EAGAIN (since the file descriptors are non-blocked), as\nopposed to EINVAL which indicates a real failure. In case of EAGAIN the\nPMD should not warn on \"unable to disable interrupt on rx queue\".\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\n---\n drivers/net/mlx4/mlx4_intr.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c\nindex 020fc25..19af935 100644\n--- a/drivers/net/mlx4/mlx4_intr.c\n+++ b/drivers/net/mlx4/mlx4_intr.c\n@@ -326,13 +326,20 @@ mlx4_rx_intr_disable(struct rte_eth_dev *dev, uint16_t idx)\n \t} else {\n \t\tret = mlx4_glue->get_cq_event(rxq->cq->channel, &ev_cq,\n \t\t\t\t\t &ev_ctx);\n-\t\tif (ret || ev_cq != rxq->cq)\n+\t\t/** For non-zero ret save the errno (may be EAGAIN\n+\t\t * which means the get_cq_event function was called before\n+\t\t * receiving one).\n+\t\t */\n+\t\tif (ret)\n+\t\t\tret = errno;\n+\t\telse if (ev_cq != rxq->cq)\n \t\t\tret = EINVAL;\n \t}\n \tif (ret) {\n \t\trte_errno = ret;\n-\t\tWARN(\"unable to disable interrupt on rx queue %d\",\n-\t\t idx);\n+\t\tif (ret != EAGAIN)\n+\t\t\tWARN(\"unable to disable interrupt on rx queue %d\",\n+\t\t\t idx);\n \t} else {\n \t\trxq->mcq.arm_sn++;\n \t\tmlx4_glue->ack_cq_events(rxq->cq, 1);\n", "prefixes": [ "v1" ] }