Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74930/?format=api
{ "id": 74930, "url": "http://patches.dpdk.org/api/patches/74930/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728092406.9259-4-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728092406.9259-4-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728092406.9259-4-ruifeng.wang@arm.com", "date": "2020-07-28T09:24:06", "name": "[v2,3/3] crypto/armv8: remove redundant assert definition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8564893a4db9929896263b4d09668dcf87b18c58", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728092406.9259-4-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 11355, "url": "http://patches.dpdk.org/api/series/11355/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11355", "date": "2020-07-28T09:24:03", "name": "armv8 crypto PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/11355/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74930/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74930/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E00DCA052B;\n\tTue, 28 Jul 2020 11:25:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65B191C0D7;\n\tTue, 28 Jul 2020 11:25:16 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 5DF4F1BFF3\n for <dev@dpdk.org>; Tue, 28 Jul 2020 11:25:15 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8453D6E;\n Tue, 28 Jul 2020 02:25:14 -0700 (PDT)", "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.119])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B33A63F66E;\n Tue, 28 Jul 2020 02:25:12 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>", "Cc": "akhil.goyal@nxp.com, david.marchand@redhat.com, dev@dpdk.org,\n honnappa.nagarahalli@arm.com, nd@arm.com", "Date": "Tue, 28 Jul 2020 17:24:06 +0800", "Message-Id": "<20200728092406.9259-4-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200728092406.9259-1-ruifeng.wang@arm.com>", "References": "<20200727085810.168970-1-ruifeng.wang@arm.com>\n <20200728092406.9259-1-ruifeng.wang@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 3/3] crypto/armv8: remove redundant assert\n\tdefinition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No need to define assert function in PMD since RTE provides the same.\nRemove private definition and use RTE_VERIFY instead.\n\nSuggested-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/crypto/armv8/armv8_pmd_private.h | 8 --------\n drivers/crypto/armv8/rte_armv8_pmd.c | 2 +-\n 2 files changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/armv8/armv8_pmd_private.h\nindex 709b3d536..66b03fb92 100644\n--- a/drivers/crypto/armv8/armv8_pmd_private.h\n+++ b/drivers/crypto/armv8/armv8_pmd_private.h\n@@ -30,14 +30,6 @@ extern int crypto_armv8_log_type;\n \t\t\tRTE_STR(CRYPTODEV_NAME_ARMV8_PMD),\t\\\n \t\t\t__func__, __LINE__, ## args)\n \n-#define ARMV8_CRYPTO_ASSERT(con)\t\t\t\t\\\n-do {\t\t\t\t\t\t\t\t\\\n-\tif (!(con)) {\t\t\t\t\t\t\\\n-\t\trte_panic(\"condition failed, line %u\",\t\t\\\n-\t\t\t__LINE__);\t\t\t\t\\\n-\t}\t\t\t\t\t\t\t\\\n-} while (0)\n-\n #define NBBY\t\t8\t\t/* Number of bits in a byte */\n #define BYTE_LENGTH(x)\t((x) / NBBY)\t/* Number of bytes in x (round down) */\n \ndiff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c\nindex a2b08d818..c95729db5 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd.c\n@@ -630,7 +630,7 @@ process_armv8_chained_op(struct armv8_crypto_qp *qp, struct rte_crypto_op *op,\n \targ.cipher.key = sess->cipher.key.data;\n \t/* Acquire combined mode function */\n \tcrypto_func = sess->crypto_func;\n-\tARMV8_CRYPTO_ASSERT(crypto_func != NULL);\n+\tRTE_VERIFY(crypto_func != NULL);\n \terror = crypto_func(csrc, cdst, clen, asrc, adst, alen, &arg);\n \tif (error != 0) {\n \t\top->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n", "prefixes": [ "v2", "3/3" ] }