Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74928/?format=api
{ "id": 74928, "url": "http://patches.dpdk.org/api/patches/74928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728092406.9259-2-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728092406.9259-2-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728092406.9259-2-ruifeng.wang@arm.com", "date": "2020-07-28T09:24:04", "name": "[v2,1/3] crypto/armv8: remove log debug option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "27bc671d0cb5612b93089120ce412b8cffe4a686", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728092406.9259-2-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 11355, "url": "http://patches.dpdk.org/api/series/11355/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11355", "date": "2020-07-28T09:24:03", "name": "armv8 crypto PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/11355/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74928/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC5E9A052B;\n\tTue, 28 Jul 2020 11:24:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBCA61C10A;\n\tTue, 28 Jul 2020 11:24:52 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 3A3091C0DB;\n Tue, 28 Jul 2020 11:24:51 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF5F830E;\n Tue, 28 Jul 2020 02:24:50 -0700 (PDT)", "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.119])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1D17F3F66E;\n Tue, 28 Jul 2020 02:24:47 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ruifeng Wang <ruifeng.wang@arm.com>", "Cc": "akhil.goyal@nxp.com, david.marchand@redhat.com, dev@dpdk.org,\n honnappa.nagarahalli@arm.com, nd@arm.com, stable@dpdk.org", "Date": "Tue, 28 Jul 2020 17:24:04 +0800", "Message-Id": "<20200728092406.9259-2-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200728092406.9259-1-ruifeng.wang@arm.com>", "References": "<20200727085810.168970-1-ruifeng.wang@arm.com>\n <20200728092406.9259-1-ruifeng.wang@arm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/3] crypto/armv8: remove log debug option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Typo in debug log switch macro caused debug log cannot be enabled.\nSince no log used in data path, remove the debug option entirely\nand have logs always enabled.\n\nResolved compilation error when debug log is enabled:\nrte_armv8_pmd.c: In function ‘process_armv8_chained_op’:\nrte_armv8_pmd.c:633:22: error: expected ‘)’ before ‘crypto_func’\n ARMV8_CRYPTO_ASSERT(crypto_func != NULL);\n ^\n\nFixes: 169ca3db550c (\"crypto/armv8: add PMD optimized for ARMv8 processors\")\nCc: stable@dpdk.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n config/common_base | 1 -\n drivers/crypto/armv8/armv8_pmd_private.h | 11 ++---------\n 2 files changed, 2 insertions(+), 10 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex f76585f16..c70b8f68b 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -605,7 +605,6 @@ CONFIG_RTE_CRYPTO_MAX_DEVS=64\n # Compile PMD for ARMv8 Crypto device\n #\n CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO=n\n-CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n\n \n #\n # Compile NXP CAAM JR crypto Driver\ndiff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/armv8/armv8_pmd_private.h\nindex e08d0df78..19940809b 100644\n--- a/drivers/crypto/armv8/armv8_pmd_private.h\n+++ b/drivers/crypto/armv8/armv8_pmd_private.h\n@@ -15,7 +15,6 @@\n \t\t\tRTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \\\n \t\t\t__func__, __LINE__, ## args)\n \n-#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG\n #define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \\\n \tRTE_LOG(INFO, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n \t\t\tRTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \\\n@@ -29,17 +28,11 @@\n #define ARMV8_CRYPTO_ASSERT(con)\t\t\t\t\\\n do {\t\t\t\t\t\t\t\t\\\n \tif (!(con)) {\t\t\t\t\t\t\\\n-\t\trte_panic(\"%s(): \"\t\t\t\t\\\n-\t\t con \"condition failed, line %u\", __func__);\t\\\n+\t\trte_panic(\"condition failed, line %u\",\t\t\\\n+\t\t\t__LINE__);\t\t\t\t\\\n \t}\t\t\t\t\t\t\t\\\n } while (0)\n \n-#else\n-#define ARMV8_CRYPTO_LOG_INFO(fmt, args...)\n-#define ARMV8_CRYPTO_LOG_DBG(fmt, args...)\n-#define ARMV8_CRYPTO_ASSERT(con)\n-#endif\n-\n #define NBBY\t\t8\t\t/* Number of bits in a byte */\n #define BYTE_LENGTH(x)\t((x) / NBBY)\t/* Number of bytes in x (round down) */\n \n", "prefixes": [ "v2", "1/3" ] }