Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74921/?format=api
{ "id": 74921, "url": "http://patches.dpdk.org/api/patches/74921/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200728063439.23114-23-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200728063439.23114-23-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200728063439.23114-23-ajit.khaparde@broadcom.com", "date": "2020-07-28T06:34:39", "name": "[v4,22/22] net/bnxt: fix build error with extra cflags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e3834e1dfbb9ef50eec3c0630bce719d1792c491", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200728063439.23114-23-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 11349, "url": "http://patches.dpdk.org/api/series/11349/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11349", "date": "2020-07-28T06:34:17", "name": "bnxt patches", "version": 4, "mbox": "http://patches.dpdk.org/series/11349/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74921/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74921/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6364CA0521;\n\tTue, 28 Jul 2020 08:39:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A6F6E1C1FC;\n\tTue, 28 Jul 2020 08:35:55 +0200 (CEST)", "from mail-wm1-f99.google.com (mail-wm1-f99.google.com\n [209.85.128.99]) by dpdk.org (Postfix) with ESMTP id BC3AF1C0BC\n for <dev@dpdk.org>; Tue, 28 Jul 2020 08:35:33 +0200 (CEST)", "by mail-wm1-f99.google.com with SMTP id f18so17000379wml.3\n for <dev@dpdk.org>; Mon, 27 Jul 2020 23:35:33 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id r16sm30828wmh.29.2020.07.27.23.35.31\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 27 Jul 2020 23:35:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=9pLkqIBt1N/Wcwpd8QY6ki6GoJEoytzyw7DXr/qd+ww=;\n b=XnKUdg5sYY0JIaFkIXoKJkfOufRl0In5BNOm12EKHVBZi/PmZBdWaUrFE336wD6fS3\n aP3Fut6EBCHVc47IUPxJ4f4W8gLR26pbvVSjrFY9ltXM+ohwZhUtxmZlk2z0qiVBec3g\n c1tsz+Hh7TJfRtuwfI3B7yB9lO/jJ9GRR1Q2A=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=9pLkqIBt1N/Wcwpd8QY6ki6GoJEoytzyw7DXr/qd+ww=;\n b=Tuv8U0nDF4lPKwoRX78y1hl2ywqRSpLHIynhp3x7LvJ8yw0SWS+iXirlXR4WPqK7Ap\n aevyaQfmW5TkdtvEt7cGlyYTbfc6u+q/0Tzz/SnYQ7hqT9A1aTR51A2dGF5ch7qYnBxk\n rwwtydWUt5wgDS2fy+pZVb7jOm0nyL2wTr4qUgKN2IvXLqCP8V+n6UviyN1ame66yt7d\n m0FmR1kCPOgfDpyChTgyyZi9s2o/v+rhG30OzbVpOZTjiM3OGjn/8Fe5JYl1DRhrlN5Y\n GYKEX1Ez3k0fvM369T8pCiWWZwdAFGgC3uAR3DbDNiCrSbKHy01V/yfGI8jB48E4exNM\n 7n1g==", "X-Gm-Message-State": "AOAM533w7BZg9CBkvrE5uuK7niX0fmtAGSIVRABrVB7+NqSXiOjdCVTh\n GoYCgdtdEKz9dS8eEUZQnRM08zyvLaw9WMu4rDpaM7E1ct3m6LoXKAy3bNfipHj6Wz9aa9sxjlN\n WzdtpCnFtLi7IQyKjUi0FM+/7bqWIFVIbzvwIWze6I1DpUXYyx+XHzPvKvxaqWOodqW6SoKLEAg\n 28yw==", "X-Google-Smtp-Source": "\n ABdhPJxLi4unO1yLnsfkRsXHdNhei393Il6rXpnYrFwqswU+RrjgQqRKJTcoTJrUh4rSRs17MZ6ADgWJsAMz", "X-Received": "by 2002:a1c:24d5:: with SMTP id k204mr58859wmk.159.1595918133283;\n Mon, 27 Jul 2020 23:35:33 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stephen@networkplumber.org,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Mon, 27 Jul 2020 23:34:39 -0700", "Message-Id": "<20200728063439.23114-23-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200728063439.23114-1-ajit.khaparde@broadcom.com>", "References": "\n <CACZ4nht+F+XvmJ0_TvYCQTfUEwan3dmCNer9wRuRQsOetFtodQ@mail.gmail.com>\n <20200728063439.23114-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 22/22] net/bnxt: fix build error with extra\n\tcflags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we compile PMD with CFLAGS set to -O -g, build fails because of\nuninitialized error. This patch fixes it.\n\nFixes: 1e46b3962620 (\"net/bnxt: fill cfa action in Tx descriptor\")\n\nBugzilla ID: 509\n\nCc: stephen@networkplumber.org\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 1113aca44..c7a2de67c 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -111,7 +111,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \tuint32_t outer_tpid_bd = 0;\n \tstruct tx_bd_long *txbd;\n \tstruct tx_bd_long_hi *txbd1 = NULL;\n-\tuint32_t vlan_tag_flags, cfa_action;\n+\tuint32_t vlan_tag_flags;\n \tbool long_bd = false;\n \tunsigned short nr_bds = 0;\n \tstruct rte_mbuf *m_seg;\n@@ -187,13 +187,6 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd->flags_type |= TX_BD_LONG_TYPE_TX_BD_LONG;\n \t\tvlan_tag_flags = 0;\n \n-\t\tif (BNXT_TRUFLOW_EN(txq->bp)) {\n-\t\t\tif (txq->vfr_tx_cfa_action)\n-\t\t\t\tcfa_action = txq->vfr_tx_cfa_action;\n-\t\t\telse\n-\t\t\t\tcfa_action = txq->bp->tx_cfa_action;\n-\t\t}\n-\n \t\t/* HW can accelerate only outer vlan in QinQ mode */\n \t\tif (tx_buf->mbuf->ol_flags & PKT_TX_QINQ_PKT) {\n \t\t\tvlan_tag_flags = TX_BD_LONG_CFA_META_KEY_VLAN_TAG |\n@@ -222,8 +215,10 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd1->lflags = 0;\n \t\ttxbd1->cfa_meta = vlan_tag_flags;\n \n-\t\tif (BNXT_TRUFLOW_EN(txq->bp))\n-\t\t\ttxbd1->cfa_action = cfa_action;\n+\t\tif (txq->vfr_tx_cfa_action)\n+\t\t\ttxbd1->cfa_action = txq->vfr_tx_cfa_action;\n+\t\telse\n+\t\t\ttxbd1->cfa_action = txq->bp->tx_cfa_action;\n \n \t\tif (tx_pkt->ol_flags & PKT_TX_TCP_SEG) {\n \t\t\tuint16_t hdr_size;\n", "prefixes": [ "v4", "22/22" ] }