Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74865/?format=api
{ "id": 74865, "url": "http://patches.dpdk.org/api/patches/74865/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200727174715.330117-6-parav@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200727174715.330117-6-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200727174715.330117-6-parav@mellanox.com", "date": "2020-07-27T17:47:10", "name": "[v12,05/10] regex/mlx5: fix segmentation fault during error unwinding", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3abd0131eaf70c3ffa564fd6c9f6b32c36d62b70", "submitter": { "id": 1780, "url": "http://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200727174715.330117-6-parav@mellanox.com/mbox/", "series": [ { "id": 11333, "url": "http://patches.dpdk.org/api/series/11333/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11333", "date": "2020-07-27T17:47:05", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 12, "mbox": "http://patches.dpdk.org/series/11333/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74865/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/74865/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F686A053E;\n\tMon, 27 Jul 2020 19:48:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1830B1C0CA;\n\tMon, 27 Jul 2020 19:47:58 +0200 (CEST)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr140081.outbound.protection.outlook.com [40.107.14.81])\n by dpdk.org (Postfix) with ESMTP id 0C9C71C0BD\n for <dev@dpdk.org>; Mon, 27 Jul 2020 19:47:54 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM0PR05MB6227.eurprd05.prod.outlook.com (2603:10a6:208:10f::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Mon, 27 Jul\n 2020 17:47:52 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020\n 17:47:52 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n DM5PR15CA0049.namprd15.prod.outlook.com (2603:10b6:3:ae::11) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.20 via Frontend Transport; Mon, 27 Jul 2020 17:47:51 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=XJlOVVWR5yUv0tsKlFzo+OgUHbuELrEbXrSf/7KXt7iPpEViWEKMRiAvYTKqpvoo1lGQCYhOI73w1B+AfBo32Og7yVeIlH8SjwvMciPDokRmgm/yZ3iWuR0yot4JDFgbh0CxkZVzCLCEUXtvo37nxPCeCmEvRIylai3wrY621GfIXjojSPu6b6mBknIsm44h8UqzJ6sYKpnI9i8dvJQTKAjBtzOitlGbP+oRJrZ5wLlcA1iAILU6Owq3511oiVPwjpXCSbInri+851xJQz01g/YJXNS218huoRz9OLRm2Xozw7ndbwPtGThBcXJmNUnel2Qpry54WQFlgduRhsIZMg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=R5ekeH0puSZW7SLNupwWh4oCACuINI0zNj5viw7VciA=;\n b=ALlZR/tf6XFGlxjyc+gRf8pnhRSKlInI4Sp/BisdU5M5NJFfbXO9ludsdvRcrS0VUF5EgVBqYY3BnIVIU5l/ooAHD/I9+BFupTiOSdf828G2tFyctLc1ixz1UG3gdDn+VOIB9P4bdxk7iLiFHWK6lhoEwfiWP7DySy8iNePLtTrkDiHkMLzHm3SEwJYEOTym8SmmG+L/ss5xqJGu4jov4hPW6aAWM9c+tmZU7g4XzA/1xoEMpGkWGgDtgySDjKcFNJSTJ7IyGmIQXbQqQcgn0KcZcvBKLwFfnvZJX8Gwz8T6Y3Wyp85rWR8nGOT1OxFVK+99T8ZgCmoqF/r40irijQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=R5ekeH0puSZW7SLNupwWh4oCACuINI0zNj5viw7VciA=;\n b=HJhKqx7cF/JaXRBWM34oBu8MY4QC433KmEIW645geI0tYvjqSnxN0UHUgK2MD1nDzuNeqKdknPmuVDXNLvv8Til8sGj4aBDuNk8aUoZJclRobSMNl7eiffcsFEp8AykAhbN06iBE0fTZHvHesOaec58gAlXh94zDAgSw1QX3v4s=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>", "Date": "Mon, 27 Jul 2020 20:47:10 +0300", "Message-Id": "<20200727174715.330117-6-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200727174715.330117-1-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200727174715.330117-1-parav@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "DM5PR15CA0049.namprd15.prod.outlook.com\n (2603:10b6:3:ae::11) To AM0PR05MB4866.eurprd05.prod.outlook.com\n (2603:10a6:208:c0::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "8b70c398-f671-40a9-8133-08d832552fab", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB6227:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB6227A158EFE2DC3E9843E4AAD1720@AM0PR05MB6227.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:386;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 0Slp4MJF+eI8gxB99dDDri39dkDxadbrvbROC54PPVfWIG6S7D4c2siQLRPrEK/Quh82gQ32tJJqghnPluhPHSz96o/zlV0GCjmOhzVpiiuRBUIZeRZn/CTa2cxJPlqLlXLAxfv06nPPlaBkJTummTsZgNcAF7CoP8wd5EfauUZvfDH1Us4clh7anofIyOzKouv2YaaIwizBJC40tsykv8lj6IYIwCa2VwmwnA+lSicb2QjaHG7EP4A1Y6rp7NPX9sMhYLtrDOxAo5u2O1B4+HIWYC6FjBOImKYUwrGX8j6a2PJgxdschXiURXxDChTDFhWNUjCJlsi7Au1LED+FNw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(52116002)(6506007)(2906002)(316002)(6486002)(1076003)(5660300002)(8936002)(8676002)(478600001)(6666004)(6512007)(26005)(16526019)(186003)(66946007)(66556008)(66476007)(86362001)(2616005)(956004)(107886003)(4326008)(83380400001)(36756003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n 7D+AtCLr4CCyXG4uvvBB1Mq7k6/oHL6cJTIJzkRheXjUPE5p3WBDjOM8C7bzEOOtcNnGjOWA1ENFThJXulkOd/iNQPh7/gz+JJt7M8xt3TrF4OVFksiFYc2KnsUV5u98jN+sCNkb6Mt5NEd+gJIH+GC1qHWrCJlnX1HJ+8QCJetTIgLqabH5YFxB59qACBsJ+TCkFqrAZaDtKV2418mDuktAeY+BOV9gSeH2/gXNSkzes7aB9Zb08duLXWYLbyWJHnb7j2MGspD3Lt0f4/9VvlDnc2K8uCPVpkc+58Q8efaDzNgxNSUgbnabacn6ViBwO+pkccSOq7TLm41ad0dLe/9vXFBvYus5jPMAt9kkwsdwTkOAWN0XuzHAEGm9hlUOqQYJ4XYlJ2zNTqLkKcTt4UfTOQoT0ja/qrbaqY+GeCOXpvb+t7Ztg/V+Q5d7RClMF66BKDVZs4M/n2//UXTGRgjlcD4ttO40ocsgO10HpgBENdR7CYZjDyVr6ZehEZTq", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8b70c398-f671-40a9-8133-08d832552fab", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Jul 2020 17:47:52.7962 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n FksYOeKAxM2VnqTrXykvEDRib3CI6sG5QEFS3W7cO66yX5jb9i4FyZTp2X7WKfRRemWcFTDVHQKxBlOCIXM2+w==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB6227", "Subject": "[dpdk-dev] [PATCH v12 05/10] regex/mlx5: fix segmentation fault\n\tduring error unwinding", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When fail to initialize the device, avoid segmentation fault while\naccessing uninitialized priv.\n\nFixes: cfc672a90b74 (\"regex/mlx5: support probing\")\n\nSigned-off-by: Parav Pandit <parav@mellanox.com>\n---\nChangelog:\nv9->v10:\n - Corrected type in commit log\nv7->v8:\n - Rebased\n - new patch\n---\n drivers/regex/mlx5/mlx5_regex.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c\nindex 1ca5bfe9b..36ae9f809 100644\n--- a/drivers/regex/mlx5/mlx5_regex.c\n+++ b/drivers/regex/mlx5/mlx5_regex.c\n@@ -137,17 +137,17 @@ mlx5_regex_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Unable to read HCA capabilities.\");\n \t\trte_errno = ENOTSUP;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t} else if (!attr.regex || attr.regexp_num_of_engines == 0) {\n \t\tDRV_LOG(ERR, \"Not enough capabilities to support RegEx, maybe \"\n \t\t\t\"old FW/OFED version?\");\n \t\trte_errno = ENOTSUP;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t}\n \tif (mlx5_regex_engines_status(ctx, 2)) {\n \t\tDRV_LOG(ERR, \"RegEx engine error.\");\n \t\trte_errno = ENOMEM;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t}\n \tpriv = rte_zmalloc(\"mlx5 regex device private\", sizeof(*priv),\n \t\t\t RTE_CACHE_LINE_SIZE);\n@@ -200,6 +200,7 @@ mlx5_regex_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tmlx5_glue->devx_free_uar(priv->uar);\n \tif (priv->regexdev)\n \t\trte_regexdev_unregister(priv->regexdev);\n+dev_error:\n \tif (ctx)\n \t\tmlx5_glue->close_device(ctx);\n \tif (priv)\n", "prefixes": [ "v12", "05/10" ] }