Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74786/?format=api
{ "id": 74786, "url": "http://patches.dpdk.org/api/patches/74786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200724143906.7453-11-parav@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200724143906.7453-11-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724143906.7453-11-parav@mellanox.com", "date": "2020-07-24T14:39:06", "name": "[v10,10/10] common/mlx5: remove class check from class drivers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6883cf88957a9b323d191111f2ef4589d0072606", "submitter": { "id": 1780, "url": "http://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200724143906.7453-11-parav@mellanox.com/mbox/", "series": [ { "id": 11291, "url": "http://patches.dpdk.org/api/series/11291/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11291", "date": "2020-07-24T14:38:56", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 10, "mbox": "http://patches.dpdk.org/series/11291/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74786/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/74786/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B44EA0527;\n\tFri, 24 Jul 2020 16:41:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B9BE91C0D7;\n\tFri, 24 Jul 2020 16:39:53 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45])\n by dpdk.org (Postfix) with ESMTP id D26BA1C10A\n for <dev@dpdk.org>; Fri, 24 Jul 2020 16:39:45 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM0PR05MB4962.eurprd05.prod.outlook.com (2603:10a6:208:c3::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 24 Jul\n 2020 14:39:44 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020\n 14:39:44 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n SA9PR10CA0025.namprd10.prod.outlook.com (2603:10b6:806:a7::30) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.23 via Frontend Transport; Fri, 24 Jul 2020 14:39:42 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Uwmc7hDNOXsF9HVNoEoABg93sLoRqcvdIDs4QQJhqPVyZR9is01kskJuOJry+be5iO+wAWViJ+AXUJsynVCIEyOZj1ABXjkXi/bDrR0wy+raEr0LD5CV/MjvygoqpYzLq3/JdSObhNL7DRwGX6R3xnUQv86mMpAB1YYv8I2jCfFqgveBKBYrwfKL8PLRhaZ/ftlVbSmbUuor15LMtTnsyb9mUlFsO+nzQVfMtYcuLBMJKu7v34GyMS5KIzwxZE8VPyn/ZW3lcxRKPQowecd3TKTSdqflTTKC4esNLNjgAZ24nWpt2OAWgaKm/IxVB9Xoja3MozNaxfld53ndV1gODg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7RRTCf2cFt1yYGpc94tcUcshT/4Ysfkpd/B2GqYUzMc=;\n b=WNwfcu0erBu87lDJTyCJvX1Gev1BC/dzo0IQBAvo1Z51w6Iu89zOHiDkq9guzgNlEYp9BnEPJdRu8S75diosHeIJuN5uXyZ0ucuao+fARIyi7VyGwiAs9hczXfxflg6qyW0q1KkgRJWz1Q9SMxdptB4yHVhbkOMQiB68jU8EfeEnwbIjBOzlLPfx3uuQ7AztiCvQIcQNgtqnRAKgJo7fSkoKuvN6/Z/CEgum9DUL64oZajWTVsKcIiAcEQM4W4b+0fpxqhKepsLEVCZrkyz8OOXMOEu1OGkC+xnZWw18xjBZ/obT2bbQiXvDvx3IcduecSmSOE9XvhseVoSh60SajQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7RRTCf2cFt1yYGpc94tcUcshT/4Ysfkpd/B2GqYUzMc=;\n b=DcS+BF3Ao4EUKLVg3XYvjvm7ewkzCvfGSH3XdIo+XpMmv520MeJ024QVJhk2ZC5H/0RJvvZUvAAUNtNGqN2PjzILAHyFMLCv9wHHYc797qocdIjYvtGLWVdLUEhFsFiiCc2lxhCdAHd9VPQJIVjIaZnrF6IsiZUd5X1VqIEtRHg=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>", "Date": "Fri, 24 Jul 2020 17:39:06 +0300", "Message-Id": "<20200724143906.7453-11-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200724143906.7453-1-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724143906.7453-1-parav@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SA9PR10CA0025.namprd10.prod.outlook.com\n (2603:10b6:806:a7::30) To AM0PR05MB4866.eurprd05.prod.outlook.com\n (2603:10a6:208:c0::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "79cdcc03-1e91-4132-ef3f-08d82fdf67bd", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB4962:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB49623C61003BBB9F359BB1D9D1770@AM0PR05MB4962.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7219;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ebykJy6BYS4ZBAD2lnHdmb1bFk4onn6PNgvTXKfkXO90YwoX8bkdnCzvnjTctNnrugwOrXSv1YhFr9ZhTzZ65R5uqC615CdUveSBh1l85tHwLodAowBf6wlfa5TkrWODs4eLu2QPT05bgMC82qwtGXEPqMV2lLEFUFjgoTRfw4GerOD/XFymAhXGyrGo4SlRUhpbSSRmIlGXdqZqabrQpPtVlTJ1TPlHFX4m8L4hojbwvCQU7F/bQxfwc5QCQogemNmoyQUexxLbAdf5rCi7OqAK5oeU8T9zL5p8USypRs2PB+oOMUsIslgzh0ccgUTD", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(8936002)(36756003)(1076003)(4326008)(26005)(52116002)(2616005)(956004)(316002)(6506007)(478600001)(16526019)(66946007)(86362001)(6512007)(83380400001)(8676002)(66476007)(66556008)(186003)(6486002)(5660300002)(107886003)(2906002)(6666004);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n 0eXTEYtMrmb9bQRub3+E2/y73VhRzRd7zxncuqIYi5nYb2eOlZWZovfYv35KJ5RsBpU3GHyQZCObo0Ft8YkKs8GOCWbT4wD0KcMuUhK+yfog2RVN9UCKYOA/Z48NCNFDDaRL425zZ96n6tldBos0ihsMqKnuKh3XyCDfbgzIKBgopIzpvDDmiMoXlQh/A8f5SJsrBgeeFAAI/7BT0OBRbJjZRSjvTCawDHsNV/EvFd3olGXOswYWvyeM/BY+ueYbyhFQnd8tXHO5Kr4+AI8zvrB0DF65y0M8HaNFkI2IUNVCT9kEokmtpuyKT71GFRfHkCFpfVjZMgnQoPvtX6PGuwigt/ubQnvE2bBbbulucJ1dhjMzVGRtZ31K56IoVIlwpVlrqtu/KuxjYpSSqGG0DCFXlKSfab0++SzcP3K2z820iRw5rm4pUel398o3i1Ow27EK9+jk/bBjvoIJogRFfWdH5dQAJ8Du9YQfZ9OvvJQLeSceNoBaGoVWd/661x7C", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 79cdcc03-1e91-4132-ef3f-08d82fdf67bd", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Jul 2020 14:39:44.0636 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n GfGW+eb4uspOL3lI/BGWpG5jZ+Iz8Y3hL7PMtaTMPydM96rBU/gqddVkwDo3/+6oAKyBT/9zcPUq8XpUqRmFHw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4962", "Subject": "[dpdk-dev] [PATCH v10 10/10] common/mlx5: remove class check from\n\tclass drivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that mlx5_pci PMD checks for enabled classes and performs\nprobe(), remove() of associated classes, individual class driver\ndoes not need to check if other driver is enabled.\n\nSigned-off-by: Parav Pandit <parav@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/common/mlx5/mlx5_common.c | 37 -------------------\n drivers/common/mlx5/mlx5_common.h | 2 -\n .../common/mlx5/rte_common_mlx5_version.map | 3 +-\n drivers/net/mlx5/linux/mlx5_os.c | 5 ---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 5 ---\n 5 files changed, 1 insertion(+), 51 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex fd818ef24..06f0a6400 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -20,43 +20,6 @@ int mlx5_common_logtype;\n \n uint8_t haswell_broadwell_cpu;\n \n-static int\n-mlx5_class_check_handler(__rte_unused const char *key, const char *value,\n-\t\t\t void *opaque)\n-{\n-\tenum mlx5_class *ret = opaque;\n-\n-\tif (strcmp(value, \"vdpa\") == 0) {\n-\t\t*ret = MLX5_CLASS_VDPA;\n-\t} else if (strcmp(value, \"net\") == 0) {\n-\t\t*ret = MLX5_CLASS_NET;\n-\t} else {\n-\t\tDRV_LOG(ERR, \"Invalid mlx5 class %s. Maybe typo in device\"\n-\t\t\t\" class argument setting?\", value);\n-\t\t*ret = MLX5_CLASS_INVALID;\n-\t}\n-\treturn 0;\n-}\n-\n-enum mlx5_class\n-mlx5_class_get(struct rte_devargs *devargs)\n-{\n-\tstruct rte_kvargs *kvlist;\n-\tconst char *key = MLX5_CLASS_ARG_NAME;\n-\tenum mlx5_class ret = MLX5_CLASS_NET;\n-\n-\tif (devargs == NULL)\n-\t\treturn ret;\n-\tkvlist = rte_kvargs_parse(devargs->args, NULL);\n-\tif (kvlist == NULL)\n-\t\treturn ret;\n-\tif (rte_kvargs_count(kvlist, key))\n-\t\trte_kvargs_process(kvlist, key, mlx5_class_check_handler, &ret);\n-\trte_kvargs_free(kvlist);\n-\treturn ret;\n-}\n-\n-\n /* In case this is an x86_64 intel processor to check if\n * we should use relaxed ordering.\n */\ndiff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex 864e82ff0..2cdb226f3 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -247,8 +247,6 @@ struct mlx5_klm {\n \n LIST_HEAD(mlx5_dbr_page_list, mlx5_devx_dbr_page);\n \n-__rte_internal\n-enum mlx5_class mlx5_class_get(struct rte_devargs *devargs);\n __rte_internal\n void mlx5_translate_port_name(const char *port_name_in,\n \t\t\t struct mlx5_switch_info *port_info_out);\ndiff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map\nindex 73cf72548..7729d0dd0 100644\n--- a/drivers/common/mlx5/rte_common_mlx5_version.map\n+++ b/drivers/common/mlx5/rte_common_mlx5_version.map\n@@ -1,9 +1,8 @@\n INTERNAL {\n \tglobal:\n \n-\tmlx5_class_get;\n-\n \tmlx5_common_init;\n+\n \tmlx5_common_verbs_reg_mr;\n \tmlx5_common_verbs_dereg_mr;\n \ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 97d7b0e7b..fc339affa 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1524,11 +1524,6 @@ mlx5_os_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tunsigned int dev_config_vf;\n \tint ret;\n \n-\tif (mlx5_class_get(pci_dev->device.devargs) != MLX5_CLASS_NET) {\n-\t\tDRV_LOG(DEBUG, \"Skip probing - should be probed by other mlx5\"\n-\t\t\t\" driver.\");\n-\t\treturn 1;\n-\t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\tmlx5_pmd_socket_init();\n \tret = mlx5_init_once();\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex ffe2f00ac..c0b87bcc0 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -680,11 +680,6 @@ mlx5_vdpa_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct mlx5_hca_attr attr;\n \tint ret;\n \n-\tif (mlx5_class_get(pci_dev->device.devargs) != MLX5_CLASS_VDPA) {\n-\t\tDRV_LOG(DEBUG, \"Skip probing - should be probed by other mlx5\"\n-\t\t\t\" driver.\");\n-\t\treturn 1;\n-\t}\n \tibv = mlx5_vdpa_get_ib_device_match(&pci_dev->addr);\n \tif (!ibv) {\n \t\tDRV_LOG(ERR, \"No matching IB device for PCI slot \"\n", "prefixes": [ "v10", "10/10" ] }