Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74771/?format=api
{ "id": 74771, "url": "http://patches.dpdk.org/api/patches/74771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200724142403.6132-7-parav@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200724142403.6132-7-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724142403.6132-7-parav@mellanox.com", "date": "2020-07-24T14:23:59", "name": "[v9,06/10] common/mlx5: avoid using class constructor priority", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f3b03f04a2c0fa225bfaf8321a34402c8cff02f0", "submitter": { "id": 1780, "url": "http://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200724142403.6132-7-parav@mellanox.com/mbox/", "series": [ { "id": 11290, "url": "http://patches.dpdk.org/api/series/11290/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11290", "date": "2020-07-24T14:23:54", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 9, "mbox": "http://patches.dpdk.org/series/11290/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74771/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/74771/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E70E3A0526;\n\tFri, 24 Jul 2020 16:25:31 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 801201C0BC;\n\tFri, 24 Jul 2020 16:24:43 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84])\n by dpdk.org (Postfix) with ESMTP id AD2FE1C0B3\n for <dev@dpdk.org>; Fri, 24 Jul 2020 16:24:37 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM4PR05MB3203.eurprd05.prod.outlook.com (2603:10a6:205:6::28) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Fri, 24 Jul\n 2020 14:24:35 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020\n 14:24:35 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n DM6PR02CA0136.namprd02.prod.outlook.com (2603:10b6:5:1b4::38) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.21 via Frontend Transport; Fri, 24 Jul 2020 14:24:34 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CMKx8bI5U8x1mVVktTLmBRDmqJX65KURDC/siwxIXbC4LUTbLq7vYz2s/7zAtiM3lit1PqgFukdpLoevohpBtMxOZUCiphEk56jjvo6KrmNXUsK1yihhrU34+JhIiDE9oiO+jkYXyvv8LQnuitdKdytCyPcQraiZxESWLoIJWldM2dbDjhATPwHthEPkoqeAdkoigyJsT+bCzF1sqcntoiHmzEbNOTKSggj1DgSLduM7DFFawhp0eTASfRjHxpbK017oLhljzFd5jHZu2FiI4qrrQ7150O3DL9ZkQB8sM2zD+6X6IUHM4u26xvFaI76YbZSEZPc6w3FJFQZRBGNC8A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uE1aG3m3rW+suXJngbZxLa6tmSK5I5Xc8kW4y3TDwWw=;\n b=k3OTMIc8i5Pe4sYjnEaOynTtZZXvOEKXHgQ9TC5xLKtlrjF8YnluuDvdlMAgFuNzEdaodvtu77Oq9fHg+EszJrTZ3K5fVsthn+rRmK5xr6fOR1KuPpJ+tF864irLlH3FHmf1Afm+HhC06dOihNAeruSK3d/Wyt9HWUbV89A1bELQQvOvnfjGbjKdwIjtT3h67q15qf3SJppex8WegKbZQDgNPLUlhQL4ZmZYUXKls3Lxf2E/bPtqFECDhX46PrK8mUBQe4Bv1t230hUvv0dQ+Ah5YTW//1SfxBuF84xTMBZMBvl9q//+6vx1Xc8duWcVv9RAeJFGzzRnjaAMfbRRxA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uE1aG3m3rW+suXJngbZxLa6tmSK5I5Xc8kW4y3TDwWw=;\n b=PVMSNXsWkgkCGztHuTlDae6uZwWrjoJUmLL6bN1wNy+wyshVqCUI2CiUZKQB6MlSF6OBHVnU60IHUphGn/1ThURtUsGqITSOEfMbnh3kOeHBQ9Z7q2ze5+0F9bdZFt9R7GY/rGX3npNWv2ssW2Pgd4t24e0+FmeqSVw97m0k6zs=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>,\n David Marchand <david.marchand@redhat.com>", "Date": "Fri, 24 Jul 2020 17:23:59 +0300", "Message-Id": "<20200724142403.6132-7-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200724142403.6132-1-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724142403.6132-1-parav@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "DM6PR02CA0136.namprd02.prod.outlook.com\n (2603:10b6:5:1b4::38) To AM0PR05MB4866.eurprd05.prod.outlook.com\n (2603:10a6:208:c0::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "a8ec0ad0-72ff-470f-e6db-08d82fdd4a7c", "X-MS-TrafficTypeDiagnostic": "AM4PR05MB3203:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM4PR05MB3203BEE2AA6E2F44F8A6228BD1770@AM4PR05MB3203.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:216;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n FRX9UZ/Odio2bZE+9p8YLQka0+9RntrN8Ri72AeeOzAdIFhcDnqQa8GIeeKV3jDOMY7tujBZZopvNmqotmbELXWn8BhIGxFllHwhsLTMN95LGr1YSc0YUih/XEHns/CFRtTqiZic4q3HApIqQdMThjX8ruwFyREs+X+fHdJKaCZ+K1QZBVG0n70vLu9THpB+68F7UoIEr/CiO6CAeUppf2M7DFt1O/CtrZv8ZZhsMlJUQ8BPoAphvDgpzl91FPCEeYxNjswivapj+jqyRANZ85EWbOnAuxA7utJQ/C0cxz/wOCT/Je/eQCM/Xe6sygf+", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(5660300002)(86362001)(2616005)(956004)(6512007)(2906002)(66946007)(66476007)(66556008)(316002)(6506007)(4326008)(16526019)(186003)(26005)(8936002)(54906003)(478600001)(8676002)(6666004)(52116002)(6486002)(83380400001)(1076003)(36756003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n Q4GTgOfMh0KoHrDdiciAEFKjT9Yh7zf69VF7ech+nc2UH7n3liKPnZW+zzLmA8ikESdmvJykga2ga/cobu/r+S3u/4tcGn2exMGTEdp3lLYgnHOc3OV0gpip7vrcdUQ+FrKoY/YJUJtIzpntcEz4MQqZRgOljdxJQ0I+NbVzP4Epns86dDZYyuoXZ8qBoIm6sUM60RLL1rO6NQIxiBhrpCGxE05531xurK9o+6NUUeAdBPd3Mre5N5CVdVNtM5UPlLISCcZJ2VNsY1I0oQ++hSNh3n4LK6b39hywIDOfXf2chowFPidr/e12eQ8yuiw2oOjne7YBbZGoJ3otM07Asm3B5rjbuGS5NzxmE1nWuPpMC9TaG4jUPcwYmXDWMJzOCFUt/X+I0FCGpoEtIAzZQY3AjeA7PqaMPHojfeY0nXBN9c8R1ZUAeUbrs39jk81vHQI7RNxpzuJ+nSs3FapMnum/A6cVJa1vtqXhO5cOggaZxjCMaDGkwnEg0XXxYLLJ", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a8ec0ad0-72ff-470f-e6db-08d82fdd4a7c", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Jul 2020 14:24:35.8281 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 31yV5s6xDG7OdVApTp+8idVXxtNCjGswlTcd4mKzdkLvw1pbz98vfic3gXqzlTtLsrEnUpi0LJBemxYBQy6Rwg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR05MB3203", "Subject": "[dpdk-dev] [PATCH v9 06/10] common/mlx5: avoid using class\n\tconstructor priority", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mlx5_common is shared library between mlx5 net, VDPA and regex PMD.\nIt is better to use common initialization helper instead of using\nRTE_PRIORITY_CLASS priority.\n\nReviewed-by: David Marchand <david.marchand@redhat.com>\nSuggested-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Parav Pandit <parav@mellanox.com>\n---\nChangelog:\nv7->v8:\n - new patch\n---\n drivers/common/mlx5/mlx5_common.c | 13 +++++++++++--\n drivers/common/mlx5/mlx5_common.h | 3 +++\n drivers/common/mlx5/rte_common_mlx5_version.map | 1 +\n drivers/net/mlx5/mlx5.c | 1 +\n drivers/regex/mlx5/mlx5_regex.c | 1 +\n drivers/vdpa/mlx5/mlx5_vdpa.c | 1 +\n 6 files changed, 18 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex 1a67a1b16..2b336bb2d 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -86,12 +86,21 @@ RTE_INIT_PRIO(mlx5_log_init, LOG)\n \t\trte_log_set_level(mlx5_common_logtype, RTE_LOG_NOTICE);\n }\n \n+static bool mlx5_common_initialized;\n+\n /**\n- * Initialization routine for run-time dependency on glue library.\n+ * One time innitialization routine for run-time dependency on glue library\n+ * for multiple PMDs. Each mlx5 PMD that depends on mlx5_common module,\n+ * must invoke in its constructor.\n */\n-RTE_INIT_PRIO(mlx5_glue_init, CLASS)\n+void\n+mlx5_common_init(void)\n {\n+\tif (mlx5_common_initialized)\n+\t\treturn;\n+\n \tmlx5_glue_constructor();\n+\tmlx5_common_initialized = true;\n }\n \n /**\ndiff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex a811eb6c9..ebe4e9ced 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -260,4 +260,7 @@ int32_t mlx5_release_dbr(struct mlx5_dbr_page_list *head, uint32_t umem_id,\n \t\t\t uint64_t offset);\n extern uint8_t haswell_broadwell_cpu;\n \n+__rte_internal\n+void mlx5_common_init(void);\n+\n #endif /* RTE_PMD_MLX5_COMMON_H_ */\ndiff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map\nindex 132a0695f..65f25252a 100644\n--- a/drivers/common/mlx5/rte_common_mlx5_version.map\n+++ b/drivers/common/mlx5/rte_common_mlx5_version.map\n@@ -3,6 +3,7 @@ INTERNAL {\n \n \tmlx5_class_get;\n \n+\tmlx5_common_init;\n \tmlx5_common_verbs_reg_mr;\n \tmlx5_common_verbs_dereg_mr;\n \ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 647ada339..037703d2e 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -2111,6 +2111,7 @@ RTE_LOG_REGISTER(mlx5_logtype, pmd.net.mlx5, NOTICE)\n */\n RTE_INIT(rte_mlx5_pmd_init)\n {\n+\tmlx5_common_init();\n \t/* Build the static tables for Verbs conversion. */\n \tmlx5_set_ptype_table();\n \tmlx5_set_cksum_table();\ndiff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c\nindex 36ae9f809..4e0367052 100644\n--- a/drivers/regex/mlx5/mlx5_regex.c\n+++ b/drivers/regex/mlx5/mlx5_regex.c\n@@ -258,6 +258,7 @@ static struct rte_pci_driver mlx5_regex_driver = {\n \n RTE_INIT(rte_mlx5_regex_init)\n {\n+\tmlx5_common_init();\n \tif (mlx5_glue)\n \t\trte_pci_register(&mlx5_regex_driver);\n }\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 67e77b11a..85dbcf956 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -846,6 +846,7 @@ RTE_LOG_REGISTER(mlx5_vdpa_logtype, pmd.vdpa.mlx5, NOTICE)\n */\n RTE_INIT(rte_mlx5_vdpa_init)\n {\n+\tmlx5_common_init();\n \tif (mlx5_glue)\n \t\trte_pci_register(&mlx5_vdpa_driver);\n }\n", "prefixes": [ "v9", "06/10" ] }