Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74540/?format=api
{ "id": 74540, "url": "http://patches.dpdk.org/api/patches/74540/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721095140.719297-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721095140.719297-2-bruce.richardson@intel.com", "date": "2020-07-21T09:51:21", "name": "[20.11,01/20] raw/ioat: add a flag to control copying handle parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7172b26b5e3d7a027ea1afba50842c8ca1fc5ee3", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11200, "url": "http://patches.dpdk.org/api/series/11200/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11200", "date": "2020-07-21T09:51:20", "name": "raw/ioat: enhancements and new hardware support", "version": 1, "mbox": "http://patches.dpdk.org/series/11200/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74540/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/74540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3689BA0526;\n\tTue, 21 Jul 2020 11:52:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18A121BFFD;\n\tTue, 21 Jul 2020 11:52:07 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 48B8D1BFD1\n for <dev@dpdk.org>; Tue, 21 Jul 2020 11:52:05 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 02:52:04 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.36])\n by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2020 02:52:02 -0700" ], "IronPort-SDR": [ "\n 2lhDHgqnIPrNPMfsUczKaKazbOuC7j/ytJxateUGtk+4LxVl5tyxK6quEVaQob1jbV+BxVWNbg\n BOpYCuGu8wug==", "\n 2C2L1o25rkvWPz7C4fDdwEbt2Rvdw92ua0NpWrQ/qJmekwySZFXq5HYSjPfTDLbvjAUP016Rtp\n 2EwmbqXJWqkg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"234952334\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"234952334\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"488023629\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "cheng1.jiang@intel.com, patrick.fu@intel.com, kevin.laatz@intel.com,\n Cheng Jiang <Cheng1.jiang@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 21 Jul 2020 10:51:21 +0100", "Message-Id": "<20200721095140.719297-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200721095140.719297-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11 01/20] raw/ioat: add a flag to control\n\tcopying handle parameters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Cheng Jiang <Cheng1.jiang@intel.com>\n\nAdd a flag which controls whether rte_ioat_enqueue_copy and\nrte_ioat_completed_copies function should process handle parameters. Not\ndoing so can improve the performance when handle parameters are not\nnecessary.\n\nSigned-off-by: Cheng Jiang <Cheng1.jiang@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/ioat_rawdev.c | 1 +\n drivers/raw/ioat/rte_ioat_rawdev.h | 45 ++++++++++++++++++++++--------\n 2 files changed, 35 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex 7f1a15436..53b33c1a7 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -58,6 +58,7 @@ ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config,\n \t\treturn -EINVAL;\n \n \tioat->ring_size = params->ring_size;\n+\tioat->hdls_disable = params->hdls_disable;\n \tif (ioat->desc_ring != NULL) {\n \t\trte_memzone_free(ioat->desc_mz);\n \t\tioat->desc_ring = NULL;\ndiff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h\nindex f765a6557..fd3a8fe14 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev.h\n@@ -34,7 +34,8 @@\n * an ioat rawdev instance.\n */\n struct rte_ioat_rawdev_config {\n-\tunsigned short ring_size;\n+\tunsigned short ring_size; /**< size of job submission descriptor ring */\n+\tbool hdls_disable; /**< when set, ignore user-supplied handle parameters */\n };\n \n /**\n@@ -52,6 +53,7 @@ struct rte_ioat_rawdev {\n \n \tunsigned short ring_size;\n \tstruct rte_ioat_generic_hw_desc *desc_ring;\n+\tbool hdls_disable;\n \t__m128i *hdls; /* completion handles for returning to user */\n \n \n@@ -84,10 +86,14 @@ struct rte_ioat_rawdev {\n * The length of the data to be copied\n * @param src_hdl\n * An opaque handle for the source data, to be returned when this operation\n- * has been completed and the user polls for the completion details\n+ * has been completed and the user polls for the completion details.\n+ * NOTE: If hdls_disable configuration option for the device is set, this\n+ * parameter is ignored.\n * @param dst_hdl\n * An opaque handle for the destination data, to be returned when this\n- * operation has been completed and the user polls for the completion details\n+ * operation has been completed and the user polls for the completion details.\n+ * NOTE: If hdls_disable configuration option for the device is set, this\n+ * parameter is ignored.\n * @param fence\n * A flag parameter indicating that hardware should not begin to perform any\n * subsequently enqueued copy operations until after this operation has\n@@ -121,8 +127,10 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst,\n \tdesc->u.control_raw = (uint32_t)((!!fence << 4) | (!(write & 0xF)) << 3);\n \tdesc->src_addr = src;\n \tdesc->dest_addr = dst;\n+\tif (!ioat->hdls_disable)\n+\t\tioat->hdls[write] = _mm_set_epi64x((int64_t)dst_hdl,\n+\t\t\t\t\t(int64_t)src_hdl);\n \n-\tioat->hdls[write] = _mm_set_epi64x((int64_t)dst_hdl, (int64_t)src_hdl);\n \trte_prefetch0(&ioat->desc_ring[ioat->next_write & mask]);\n \n \tioat->enqueued++;\n@@ -168,19 +176,29 @@ rte_ioat_get_last_completed(struct rte_ioat_rawdev *ioat, int *error)\n /**\n * Returns details of copy operations that have been completed\n *\n- * Returns to the caller the user-provided \"handles\" for the copy operations\n- * which have been completed by the hardware, and not already returned by\n- * a previous call to this API.\n+ * If the hdls_disable option was not set when the device was configured,\n+ * the function will return to the caller the user-provided \"handles\" for\n+ * the copy operations which have been completed by the hardware, and not\n+ * already returned by a previous call to this API.\n+ * If the hdls_disable option for the device was set on configure, the\n+ * max_copies, src_hdls and dst_hdls parameters will be ignored, and the\n+ * function returns the number of newly-completed operations.\n *\n * @param dev_id\n * The rawdev device id of the ioat instance\n * @param max_copies\n * The number of entries which can fit in the src_hdls and dst_hdls\n- * arrays, i.e. max number of completed operations to report\n+ * arrays, i.e. max number of completed operations to report.\n+ * NOTE: If hdls_disable configuration option for the device is set, this\n+ * parameter is ignored.\n * @param src_hdls\n- * Array to hold the source handle parameters of the completed copies\n+ * Array to hold the source handle parameters of the completed copies.\n+ * NOTE: If hdls_disable configuration option for the device is set, this\n+ * parameter is ignored.\n * @param dst_hdls\n- * Array to hold the destination handle parameters of the completed copies\n+ * Array to hold the destination handle parameters of the completed copies.\n+ * NOTE: If hdls_disable configuration option for the device is set, this\n+ * parameter is ignored.\n * @return\n * -1 on error, with rte_errno set appropriately.\n * Otherwise number of completed operations i.e. number of entries written\n@@ -205,6 +223,11 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \t\treturn -1;\n \t}\n \n+\tif (ioat->hdls_disable) {\n+\t\tread += count;\n+\t\tgoto end;\n+\t}\n+\n \tif (count > max_copies)\n \t\tcount = max_copies;\n \n@@ -222,7 +245,7 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \t\tsrc_hdls[i] = hdls[0];\n \t\tdst_hdls[i] = hdls[1];\n \t}\n-\n+end:\n \tioat->next_read = read;\n \tioat->completed += count;\n \treturn count;\n", "prefixes": [ "20.11", "01/20" ] }