Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74422/?format=api
{ "id": 74422, "url": "http://patches.dpdk.org/api/patches/74422/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200719071112.8540-7-ophirmu@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200719071112.8540-7-ophirmu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200719071112.8540-7-ophirmu@mellanox.com", "date": "2020-07-19T07:11:10", "name": "[v2,6/8] net/mlx5: header file cleanup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "587bb31ae7aeb9eb49f5b3e65f05f42090075c6b", "submitter": { "id": 793, "url": "http://patches.dpdk.org/api/people/793/?format=api", "name": "Ophir Munk", "email": "ophirmu@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200719071112.8540-7-ophirmu@mellanox.com/mbox/", "series": [ { "id": 11144, "url": "http://patches.dpdk.org/api/series/11144/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11144", "date": "2020-07-19T07:11:04", "name": "mlx5 PMD multi OS support - part #3", "version": 2, "mbox": "http://patches.dpdk.org/series/11144/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74422/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/74422/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4067EA052A;\n\tSun, 19 Jul 2020 09:12:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B77391C0B7;\n\tSun, 19 Jul 2020 09:11:43 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60053.outbound.protection.outlook.com [40.107.6.53])\n by dpdk.org (Postfix) with ESMTP id A3F141C031\n for <dev@dpdk.org>; Sun, 19 Jul 2020 09:11:32 +0200 (CEST)", "from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22)\n by AM0PR05MB4738.eurprd05.prod.outlook.com (2603:10a6:208:b7::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Sun, 19 Jul\n 2020 07:11:31 +0000", "from AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972]) by AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972%7]) with mapi id 15.20.3195.024; Sun, 19 Jul 2020\n 07:11:31 +0000", "from mellanox.com (37.142.13.130) by\n AM0PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:208:122::37) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend\n Transport; Sun, 19 Jul 2020 07:11:30 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ia2HpjWj76NkLGiY/zW2Eps0KXc87CuQqbzswZ0iV47TtLtH2dozLFAIbYj7JQxWmSc/4eGh1o4gPL3OOhE5BV+btBc55FKqTa1sYaXSSrOF3J6VT/NTpDTyfUxzrZ8xG3jzTdT8AD6rmeSUMX+2ZVqtwPDbpRbC5ttRwrs5EYP/fGOBdg1c0IVvy3XwxSHNtB1Dnfnp5mEstzSIDS7ZZ3tKwJ00rcioS7092sbC9Ky+kFHihOm1XkuaesAz30MNisF/aGOJ1EvzWyPv1GNjFNZc1xgMHPfGvohbaslxYNKr77gM7HVwhGdGlmGTPBdFskl3ops4W+hR0dulNEinmA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3H5Tcb9Lze0swhoDkZzNIUmO3NyLxwwHZpLInzhse+4=;\n b=MomZB1m1VMiyvnVgWVP5Le2Fzf6U1/iTGE3F8iE1pzmKvjmcx4mhxNwWMo/z5hoOyeFkMP3NzDVRMSowK6RaOZ8YksIj53HXVTQiHgnPUmjdQ/aDQ1O9eq+H8dvmzXjp2pu8yM2awiPHbKi3isu0XUDSOs03q+I5m59azOVLLL/3I02LeLamNLA/m2ZfnAore5K1fdYZdLvFGlDnmbelk+kDiK8PxlsoBNI/udNUTHdnm6iu/cB1A/w3XqmHbwzsKh+L1F1R2ShbVCDN04wqxZ+/notLVhXDN3M0buY88Ykl2sYLE5+26VMFdJR7m5bvjH7CzT2iTjpLn8ysIOtmEg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3H5Tcb9Lze0swhoDkZzNIUmO3NyLxwwHZpLInzhse+4=;\n b=qwYSt8zG4/+Y8t6GfAjKTbmXbmVOKvxtAJoz2LuIAXl3zf4OSumQUif+6uUfg5jynYg8DqQHdi9pwe8Q1PDKFu+qM20s1/PVU5Su7NE55HZPfVDUpaKIcWAsjSOvLtnt9VNhYpT/ekHiXLa6EftUUsuvVWami54VBTOvU3YoRiM=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Ophir Munk <ophirmu@mellanox.com>", "To": "dev@dpdk.org", "Cc": "Raslan Darawsheh <rasland@mellanox.com>,\n Ophir Munk <ophirmu@mellanox.com>,\n Matan Azrad <matan@mellanox.com>", "Date": "Sun, 19 Jul 2020 07:11:10 +0000", "Message-Id": "<20200719071112.8540-7-ophirmu@mellanox.com>", "X-Mailer": [ "git-send-email 2.8.4", "git-send-email 2.8.4" ], "In-Reply-To": "<20200719071112.8540-1-ophirmu@mellanox.com>", "References": "<20200714142102.30606-9-ophirmu@mellanox.com>\n <20200719071112.8540-1-ophirmu@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR04CA0024.eurprd04.prod.outlook.com\n (2603:10a6:208:122::37) To AM0PR05MB4209.eurprd05.prod.outlook.com\n (2603:10a6:208:61::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "1ba18446-52af-4f5a-7475-08d82bb2f68d", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB4738:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB4738E9FEDA0146E1CB6C67C4D17A0@AM0PR05MB4738.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6108;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n J5yXk1DLIp5j6fFntZ4vuISG7EKG3n/t/SI03KuRVQ/92qy70rboNfXqqBfrgbnDtYNyVNncbvFnJ7IzS+Mrb/LaH+nGOrH1tWIqtYoOOGo0D+uzFWrBvLf4KAh3IjFNfqaDsN+xo0AShiufe48Gi7OdTLN7PQNlzieSm/oVaZ3RKswZ2uXOVZR7aaL3noPvq/eD+IsS4f1HW7cxdKPkM3NsPfRnV2ih14Ajh5DOXZTd/MqCXg9f3I2pjr0MQTUEB6Fsej5gyUkSpF3aVeR6il5GcmWYXwz3MyvXS0LW5htwzEOStxpAEYPdZOlczS5r", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39850400004)(346002)(136003)(366004)(52116002)(107886003)(5660300002)(2906002)(316002)(36756003)(8886007)(6666004)(7696005)(6916009)(55016002)(8676002)(478600001)(2616005)(4326008)(66556008)(66476007)(186003)(26005)(66946007)(54906003)(83380400001)(1076003)(86362001)(16526019)(956004)(8936002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n RO279CnaQuWeDw4RPiX2xEOAsjWHStZBiJLT//aoimvAx9p4MAyJdPncKjCabT9++GDR5oTL6thYIm1SdWGFZBIBwsbJsnCl8wYi6OXV8Ofv/c/gjtrGV+fsgxuCcIlRe31zHAdAvOTHhQec6aUTE0I7hhNG0Cg5mXMeQuK9WcQN7v3YqSUjy6K46nbR0SfBY47i0uZWhli3zF1H0/bwKMAdxinJPMvp8hHJz67vi1dX5BKCjnDLQAGs+uiDW25nv2KuKUNM5Di5UPfmDVDSvrTcXZEbZ9O9ok75ygk/EVb+IN9JaNumuzWRjRmr9fCTEex2ru0A5qQ8ZfRDPR/kBU61wH8S07K+oj/sXTCMGQojdqhMVYqnk9rDbV756HLj5Mid62k7QXOnhGiOVKeKYnxWQFvEgK0Get23b3vLfbAGeCsvqJVJkpdm0nzcLMsUudBd3PKXv5sikfS8vMRHMhzj0FMhW5h61rf/7+p5VTBKKyPWJsSY6aX/lbVukWgr", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1ba18446-52af-4f5a-7475-08d82bb2f68d", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4209.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Jul 2020 07:11:31.5272 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n p0tQW58iWHBuYeRp9vOz0QaUnl8PuFnANu/pwefPqUBf3dbCq5096O77jUIRFChACdT8E4eUvPYAatXiwo9geg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4738", "Subject": "[dpdk-dev] [PATCH v2 6/8] net/mlx5: header file cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The cleanup refers to header file mlx5.h.\n1. Remove unused prototypes.\n2. Move prototypes under their correct title.\n3. Change functions to static and remove their prototye from the header\nfile.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/linux/mlx5_ethdev_os.c | 102 ++++++++++++++++----------------\n drivers/net/mlx5/mlx5.h | 18 +++---\n 2 files changed, 58 insertions(+), 62 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\nindex e79d576..1735157 100644\n--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n@@ -973,6 +973,57 @@ mlx5_is_removed(struct rte_eth_dev *dev)\n }\n \n /**\n+ * Analyze gathered port parameters via sysfs to recognize master\n+ * and representor devices for E-Switch configuration.\n+ *\n+ * @param[in] device_dir\n+ * flag of presence of \"device\" directory under port device key.\n+ * @param[inout] switch_info\n+ * Port information, including port name as a number and port name\n+ * type if recognized\n+ *\n+ * @return\n+ * master and representor flags are set in switch_info according to\n+ * recognized parameters (if any).\n+ */\n+static void\n+mlx5_sysfs_check_switch_info(bool device_dir,\n+\t\t\t struct mlx5_switch_info *switch_info)\n+{\n+\tswitch (switch_info->name_type) {\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_UNKNOWN:\n+\t\t/*\n+\t\t * Name is not recognized, assume the master,\n+\t\t * check the device directory presence.\n+\t\t */\n+\t\tswitch_info->master = device_dir;\n+\t\tbreak;\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_NOTSET:\n+\t\t/*\n+\t\t * Name is not set, this assumes the legacy naming\n+\t\t * schema for master, just check if there is\n+\t\t * a device directory.\n+\t\t */\n+\t\tswitch_info->master = device_dir;\n+\t\tbreak;\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_UPLINK:\n+\t\t/* New uplink naming schema recognized. */\n+\t\tswitch_info->master = 1;\n+\t\tbreak;\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_LEGACY:\n+\t\t/* Legacy representors naming schema. */\n+\t\tswitch_info->representor = !device_dir;\n+\t\tbreak;\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_PFHPF:\n+\t\t/* Fallthrough */\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_PFVF:\n+\t\t/* New representors naming schema. */\n+\t\tswitch_info->representor = 1;\n+\t\tbreak;\n+\t}\n+}\n+\n+/**\n * Get switch information associated with network interface.\n *\n * @param ifindex\n@@ -1051,57 +1102,6 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)\n }\n \n /**\n- * Analyze gathered port parameters via sysfs to recognize master\n- * and representor devices for E-Switch configuration.\n- *\n- * @param[in] device_dir\n- * flag of presence of \"device\" directory under port device key.\n- * @param[inout] switch_info\n- * Port information, including port name as a number and port name\n- * type if recognized\n- *\n- * @return\n- * master and representor flags are set in switch_info according to\n- * recognized parameters (if any).\n- */\n-void\n-mlx5_sysfs_check_switch_info(bool device_dir,\n-\t\t\t struct mlx5_switch_info *switch_info)\n-{\n-\tswitch (switch_info->name_type) {\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_UNKNOWN:\n-\t\t/*\n-\t\t * Name is not recognized, assume the master,\n-\t\t * check the device directory presence.\n-\t\t */\n-\t\tswitch_info->master = device_dir;\n-\t\tbreak;\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_NOTSET:\n-\t\t/*\n-\t\t * Name is not set, this assumes the legacy naming\n-\t\t * schema for master, just check if there is\n-\t\t * a device directory.\n-\t\t */\n-\t\tswitch_info->master = device_dir;\n-\t\tbreak;\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_UPLINK:\n-\t\t/* New uplink naming schema recognized. */\n-\t\tswitch_info->master = 1;\n-\t\tbreak;\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_LEGACY:\n-\t\t/* Legacy representors naming schema. */\n-\t\tswitch_info->representor = !device_dir;\n-\t\tbreak;\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_PFHPF:\n-\t\t/* Fallthrough */\n-\tcase MLX5_PHYS_PORT_NAME_TYPE_PFVF:\n-\t\t/* New representors naming schema. */\n-\t\tswitch_info->representor = 1;\n-\t\tbreak;\n-\t}\n-}\n-\n-/**\n * DPDK callback to retrieve plug-in module EEPROM information (type and size).\n *\n * @param dev\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 00ee2e3..147ff62 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -813,6 +813,10 @@ const uint32_t *mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev);\n int mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu);\n int mlx5_hairpin_cap_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_hairpin_cap *cap);\n+eth_rx_burst_t mlx5_select_rx_function(struct rte_eth_dev *dev);\n+struct mlx5_priv *mlx5_port_to_eswitch_info(uint16_t port, bool valid);\n+struct mlx5_priv *mlx5_dev_to_eswitch_info(struct rte_eth_dev *dev);\n+int mlx5_dev_configure_rss_reta(struct rte_eth_dev *dev);\n \n /* mlx5_ethdev_os.c */\n \n@@ -823,27 +827,17 @@ int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu);\n int mlx5_set_mtu(struct rte_eth_dev *dev, uint16_t mtu);\n int mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock);\n int mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete);\n-int mlx5_force_link_status_change(struct rte_eth_dev *dev, int status);\n int mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_fc_conf *fc_conf);\n int mlx5_dev_set_flow_ctrl(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_fc_conf *fc_conf);\n-void mlx5_dev_link_status_handler(void *arg);\n void mlx5_dev_interrupt_handler(void *arg);\n void mlx5_dev_interrupt_handler_devx(void *arg);\n-void mlx5_dev_interrupt_handler_uninstall(struct rte_eth_dev *dev);\n-void mlx5_dev_interrupt_handler_install(struct rte_eth_dev *dev);\n int mlx5_set_link_down(struct rte_eth_dev *dev);\n int mlx5_set_link_up(struct rte_eth_dev *dev);\n int mlx5_is_removed(struct rte_eth_dev *dev);\n-eth_tx_burst_t mlx5_select_tx_function(struct rte_eth_dev *dev);\n-eth_rx_burst_t mlx5_select_rx_function(struct rte_eth_dev *dev);\n-struct mlx5_priv *mlx5_port_to_eswitch_info(uint16_t port, bool valid);\n-struct mlx5_priv *mlx5_dev_to_eswitch_info(struct rte_eth_dev *dev);\n int mlx5_sysfs_switch_info(unsigned int ifindex,\n \t\t\t struct mlx5_switch_info *info);\n-void mlx5_sysfs_check_switch_info(bool device_dir,\n-\t\t\t\t struct mlx5_switch_info *switch_info);\n void mlx5_translate_port_name(const char *port_name_in,\n \t\t\t struct mlx5_switch_info *port_info_out);\n void mlx5_intr_callback_unregister(const struct rte_intr_handle *handle,\n@@ -852,7 +846,6 @@ int mlx5_get_module_info(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_dev_module_info *modinfo);\n int mlx5_get_module_eeprom(struct rte_eth_dev *dev,\n \t\t\t struct rte_dev_eeprom_info *info);\n-int mlx5_dev_configure_rss_reta(struct rte_eth_dev *dev);\n int mlx5_os_read_dev_stat(struct mlx5_priv *priv,\n \t\t\t const char *ctr_name, uint64_t *stat);\n int mlx5_os_read_dev_counters(struct rte_eth_dev *dev, uint64_t *stats);\n@@ -1043,4 +1036,7 @@ int mlx5_txpp_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\t unsigned int n, unsigned int n_used);\n void mlx5_txpp_interrupt_handler(void *cb_arg);\n \n+/* mlx5_rxtx.c */\n+\n+eth_tx_burst_t mlx5_select_tx_function(struct rte_eth_dev *dev);\n #endif /* RTE_PMD_MLX5_H_ */\n", "prefixes": [ "v2", "6/8" ] }