Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74384/?format=api
{ "id": 74384, "url": "http://patches.dpdk.org/api/patches/74384/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200717141451.11705-5-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200717141451.11705-5-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200717141451.11705-5-somnath.kotur@broadcom.com", "date": "2020-07-17T14:14:41", "name": "[04/14] net/bnxt: fix to avoid accumulation of flow counters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13681f1aa14fec83ff960aaf98f993b368a48eb6", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200717141451.11705-5-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 11136, "url": "http://patches.dpdk.org/api/series/11136/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11136", "date": "2020-07-17T14:14:37", "name": "bnxt patches", "version": 2, "mbox": "http://patches.dpdk.org/series/11136/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74384/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74384/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F38FA053B;\n\tFri, 17 Jul 2020 16:20:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B5921BFEF;\n\tFri, 17 Jul 2020 16:20:13 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 9846A2C38\n for <dev@dpdk.org>; Fri, 17 Jul 2020 16:20:07 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id BBDF9299AC7;\n Fri, 17 Jul 2020 07:20:06 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com BBDF9299AC7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1594995606;\n bh=F1/M5t7hT+JCoNlfFLaEixXAhZ+0pZjD+uJ9HneGfzA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=IpUCKquOpKKD+CsZmsa6rOw3geQ6X3te56sSNXSVYYTx0PohJOI7h1Jhk05O/UreN\n 5yESb1P3DnuIOjRa6aj7agfvpLaRRwJOk9P5iJyFOFgPiJupOz2v8qsqVMv2geItUp\n davz1M14rrJA4mEJaeBP/Wkf5I+gaPE8117fcnQA=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Fri, 17 Jul 2020 19:44:41 +0530", "Message-Id": "<20200717141451.11705-5-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200717141451.11705-1-somnath.kotur@broadcom.com>", "References": "<20200717094935.9337-1-somnath.kotur@broadcom.com>\n <20200717141451.11705-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 04/14] net/bnxt: fix to avoid accumulation of\n\tflow counters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "OVS-DPDK is accumulating the flow counters that are returned as part\nof the flow_query API and it is being issued at least 3 times every second.\nSo there is no need to accumulate the counts internally in the driver.\n\nFixes: 306c2d28e247 (\"net/bnxt: add support for flow query with action_type COUNT\")\n\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\nindex 34a6ec3..febda94 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n@@ -315,8 +315,8 @@ static int ulp_get_single_flow_stat(struct tf *tfp,\n \t/* TBD - Get PKT/BYTE COUNT SHIFT/MASK from Template */\n \tsw_cntr_indx = hw_cntr_id - fc_info->shadow_hw_tbl[dir].start_idx;\n \tsw_acc_tbl_entry = &fc_info->sw_acc_tbl[dir][sw_cntr_indx];\n-\tsw_acc_tbl_entry->pkt_count += FLOW_CNTR_PKTS(stats, dparms);\n-\tsw_acc_tbl_entry->byte_count += FLOW_CNTR_BYTES(stats, dparms);\n+\tsw_acc_tbl_entry->pkt_count = FLOW_CNTR_PKTS(stats, dparms);\n+\tsw_acc_tbl_entry->byte_count = FLOW_CNTR_BYTES(stats, dparms);\n \n \treturn rc;\n }\n", "prefixes": [ "04/14" ] }