Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74319/?format=api
{ "id": 74319, "url": "http://patches.dpdk.org/api/patches/74319/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1594980877-26540-4-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594980877-26540-4-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594980877-26540-4-git-send-email-phil.yang@arm.com", "date": "2020-07-17T10:14:37", "name": "[v10,3/3] devtools: prevent use of rte atomic APIs in future patches", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6fdcd03d24b26c2374c7d88f8048f26954df9cd0", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1594980877-26540-4-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 11124, "url": "http://patches.dpdk.org/api/series/11124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11124", "date": "2020-07-17T10:14:34", "name": "generic rte atomic APIs deprecate proposal", "version": 10, "mbox": "http://patches.dpdk.org/series/11124/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74319/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74319/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A210BA053D;\n\tFri, 17 Jul 2020 12:15:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 332B21BFFF;\n\tFri, 17 Jul 2020 12:15:27 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 0AC601BFD4\n for <dev@dpdk.org>; Fri, 17 Jul 2020 12:15:25 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C001D6E;\n Fri, 17 Jul 2020 03:15:24 -0700 (PDT)", "from phil-VirtualBox.shanghai.arm.com\n (phil-VirtualBox.shanghai.arm.com [10.169.108.167])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DAF8E3F66E;\n Fri, 17 Jul 2020 03:15:20 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net,\n\tdev@dpdk.org", "Cc": "david.marchand@redhat.com, john.mcnamara@intel.com,\n Honnappa.Nagarahalli@arm.com, drc@linux.vnet.ibm.com, jerinj@marvell.com,\n konstantin.ananyev@intel.com, Ola.Liljedahl@arm.com,\n bruce.richardson@intel.com, Ruifeng.Wang@arm.com, nd@arm.com", "Date": "Fri, 17 Jul 2020 18:14:37 +0800", "Message-Id": "<1594980877-26540-4-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1594980877-26540-1-git-send-email-phil.yang@arm.com>", "References": "<1594962519-20619-1-git-send-email-phil.yang@arm.com>\n <1594980877-26540-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH v10 3/3] devtools: prevent use of rte atomic APIs\n\tin future patches", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In order to deprecate the rte_atomic and rte_smp barrier APIs[1], prevent\nthe patches from using these APIs and __sync builtins in new code. Please\nuse __atomic builtins instead of __sync builtins, rte_atomicNN_xxx and\nrte_smp_[r/w]mb APIs.\n\nOn x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite expensive for\nSMP case. Flag the new code which use __atomic_thread_fence API. Please\nuse rte_thread_fence API instead of __atomic_thread_fence builtins.\n\n1. Refer to the locks-and-atomic-operations section in\nhttps://doc.dpdk.org/guides/prog_guide/writing_efficient_code.html.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n devtools/checkpatches.sh | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex 58021aa..990a4d0 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -77,6 +77,41 @@ check_forbidden_additions() { # <patch>\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n+\t# refrain from new additions of 16/32/64 bits rte_atomic_xxx()\n+\t# multiple folders and expressions are separated by spaces\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS=\"rte_atomic[0-9][0-9]_.*\\\\\\(\" \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using rte_atomicNN_xxx' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n+\t# refrain from new additions of rte_smp_XXmb()\n+\t# multiple folders and expressions are separated by spaces\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS=\"rte_smp_(r|w)?mb\\\\\\(\" \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using rte_smp_[r/w]mb' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n+\t# refrain from using compiler __sync builtins\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS=\"__sync_.*\\\\\\(\" \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using __sync_xxx builtins' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n+\t# refrain from using compiler __atomic_thread_fence()\n+\t# It should be avoided on x86 for SMP case.\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS=\"__atomic_thread_fence\\\\\\(\" \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using __atomic_thread_fence' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n \t# svg figures must be included with wildcard extension\n \t# because of png conversion for pdf docs\n \tawk -v FOLDERS='doc' \\\n", "prefixes": [ "v10", "3/3" ] }