Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74318/?format=api
{ "id": 74318, "url": "http://patches.dpdk.org/api/patches/74318/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1594980877-26540-3-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594980877-26540-3-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594980877-26540-3-git-send-email-phil.yang@arm.com", "date": "2020-07-17T10:14:36", "name": "[v10,2/3] eal/atomic: add wrapper for C11 atomic thread fence", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "44ac8566294e0146489f81abf317998ae81f78f7", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1594980877-26540-3-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 11124, "url": "http://patches.dpdk.org/api/series/11124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11124", "date": "2020-07-17T10:14:34", "name": "generic rte atomic APIs deprecate proposal", "version": 10, "mbox": "http://patches.dpdk.org/series/11124/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74318/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A7C7A053D;\n\tFri, 17 Jul 2020 12:15:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D308B1BFF9;\n\tFri, 17 Jul 2020 12:15:21 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 832FA1BFEE\n for <dev@dpdk.org>; Fri, 17 Jul 2020 12:15:20 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16337D6E;\n Fri, 17 Jul 2020 03:15:20 -0700 (PDT)", "from phil-VirtualBox.shanghai.arm.com\n (phil-VirtualBox.shanghai.arm.com [10.169.108.167])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D864D3F66E;\n Fri, 17 Jul 2020 03:15:15 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net,\n\tdev@dpdk.org", "Cc": "david.marchand@redhat.com, john.mcnamara@intel.com,\n Honnappa.Nagarahalli@arm.com, drc@linux.vnet.ibm.com, jerinj@marvell.com,\n konstantin.ananyev@intel.com, Ola.Liljedahl@arm.com,\n bruce.richardson@intel.com, Ruifeng.Wang@arm.com, nd@arm.com,\n Jan Viktorin <viktorin@rehivetech.com>, Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Fri, 17 Jul 2020 18:14:36 +0800", "Message-Id": "<1594980877-26540-3-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1594980877-26540-1-git-send-email-phil.yang@arm.com>", "References": "<1594962519-20619-1-git-send-email-phil.yang@arm.com>\n <1594980877-26540-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH v10 2/3] eal/atomic: add wrapper for C11 atomic\n\tthread fence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Provide a wrapper for __atomic_thread_fence builtins to support\noptimized code for __ATOMIC_SEQ_CST memory order for x86 platforms.\n\nSuggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ola Liljedahl <Ola.Liljedahl@arm.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_eal/arm/include/rte_atomic_32.h | 6 ++++++\n lib/librte_eal/arm/include/rte_atomic_64.h | 6 ++++++\n lib/librte_eal/include/generic/rte_atomic.h | 6 ++++++\n lib/librte_eal/ppc/include/rte_atomic.h | 6 ++++++\n lib/librte_eal/x86/include/rte_atomic.h | 17 +++++++++++++++++\n 5 files changed, 41 insertions(+)", "diff": "diff --git a/lib/librte_eal/arm/include/rte_atomic_32.h b/lib/librte_eal/arm/include/rte_atomic_32.h\nindex 7dc0d06..dbe7cc6 100644\n--- a/lib/librte_eal/arm/include/rte_atomic_32.h\n+++ b/lib/librte_eal/arm/include/rte_atomic_32.h\n@@ -37,6 +37,12 @@ extern \"C\" {\n \n #define rte_cio_rmb() rte_rmb()\n \n+static __rte_always_inline void\n+rte_atomic_thread_fence(int mo)\n+{\n+\t__atomic_thread_fence(mo);\n+}\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/arm/include/rte_atomic_64.h b/lib/librte_eal/arm/include/rte_atomic_64.h\nindex e42f69e..bf885ad 100644\n--- a/lib/librte_eal/arm/include/rte_atomic_64.h\n+++ b/lib/librte_eal/arm/include/rte_atomic_64.h\n@@ -41,6 +41,12 @@ extern \"C\" {\n \n #define rte_cio_rmb() rte_rmb()\n \n+static __rte_always_inline void\n+rte_atomic_thread_fence(int mo)\n+{\n+\t__atomic_thread_fence(mo);\n+}\n+\n /*------------------------ 128 bit atomic operations -------------------------*/\n \n #if defined(__ARM_FEATURE_ATOMICS) || defined(RTE_ARM_FEATURE_ATOMICS)\ndiff --git a/lib/librte_eal/include/generic/rte_atomic.h b/lib/librte_eal/include/generic/rte_atomic.h\nindex e6ab15a..5b941db 100644\n--- a/lib/librte_eal/include/generic/rte_atomic.h\n+++ b/lib/librte_eal/include/generic/rte_atomic.h\n@@ -158,6 +158,12 @@ static inline void rte_cio_rmb(void);\n \tasm volatile (\"\" : : : \"memory\");\t\\\n } while(0)\n \n+/**\n+ * Synchronization fence between threads based on the specified\n+ * memory order.\n+ */\n+static inline void rte_atomic_thread_fence(int mo);\n+\n /*------------------------- 16 bit atomic operations -------------------------*/\n \n /**\ndiff --git a/lib/librte_eal/ppc/include/rte_atomic.h b/lib/librte_eal/ppc/include/rte_atomic.h\nindex 7e3e131..91c5f30 100644\n--- a/lib/librte_eal/ppc/include/rte_atomic.h\n+++ b/lib/librte_eal/ppc/include/rte_atomic.h\n@@ -40,6 +40,12 @@ extern \"C\" {\n \n #define rte_cio_rmb() rte_rmb()\n \n+static __rte_always_inline void\n+rte_atomic_thread_fence(int mo)\n+{\n+\t__atomic_thread_fence(mo);\n+}\n+\n /*------------------------- 16 bit atomic operations -------------------------*/\n /* To be compatible with Power7, use GCC built-in functions for 16 bit\n * operations */\ndiff --git a/lib/librte_eal/x86/include/rte_atomic.h b/lib/librte_eal/x86/include/rte_atomic.h\nindex b9dcd30..bd256e7 100644\n--- a/lib/librte_eal/x86/include/rte_atomic.h\n+++ b/lib/librte_eal/x86/include/rte_atomic.h\n@@ -83,6 +83,23 @@ rte_smp_mb(void)\n \n #define rte_cio_rmb() rte_compiler_barrier()\n \n+/**\n+ * Synchronization fence between threads based on the specified\n+ * memory order.\n+ *\n+ * On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) generates\n+ * full 'mfence' which is quite expensive. The optimized\n+ * implementation of rte_smp_mb is used instead.\n+ */\n+static __rte_always_inline void\n+rte_atomic_thread_fence(int mo)\n+{\n+\tif (mo == __ATOMIC_SEQ_CST)\n+\t\trte_smp_mb();\n+\telse\n+\t\t__atomic_thread_fence(mo);\n+}\n+\n /*------------------------- 16 bit atomic operations -------------------------*/\n \n #ifndef RTE_FORCE_INTRINSICS\n", "prefixes": [ "v10", "2/3" ] }