Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74266/?format=api
{ "id": 74266, "url": "http://patches.dpdk.org/api/patches/74266/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200716153600.66071-2-david.coyle@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200716153600.66071-2-david.coyle@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200716153600.66071-2-david.coyle@intel.com", "date": "2020-07-16T15:35:59", "name": "[v1,1/2] crypto/qat: improve security instance setup", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ec2a845068df5b12a65c1f56af905ba1e60cd9b9", "submitter": { "id": 961, "url": "http://patches.dpdk.org/api/people/961/?format=api", "name": "Coyle, David", "email": "david.coyle@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200716153600.66071-2-david.coyle@intel.com/mbox/", "series": [ { "id": 11108, "url": "http://patches.dpdk.org/api/series/11108/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11108", "date": "2020-07-16T15:35:58", "name": "improve security instance setup", "version": 1, "mbox": "http://patches.dpdk.org/series/11108/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74266/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74266/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 159DAA0546;\n\tThu, 16 Jul 2020 18:00:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F97F1BF7F;\n\tThu, 16 Jul 2020 18:00:14 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 46D5A1BE9C\n for <dev@dpdk.org>; Thu, 16 Jul 2020 18:00:11 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Jul 2020 09:00:09 -0700", "from silpixa00399912.ir.intel.com (HELO\n silpixa00399912.ger.corp.intel.com) ([10.237.223.64])\n by fmsmga006.fm.intel.com with ESMTP; 16 Jul 2020 09:00:07 -0700" ], "IronPort-SDR": [ "\n Wk6G3tM2MsgOmuYNsIv/57V5ghTNq2mFJcBHL0u8xOwRJRglM5b2Tk4Iod9fE9aRHUDuRPe2qc\n 7eCBv4F2/rHA==", "\n JZAHLdtbTKfV4lVFMQgy+qAkni5VnMzYuRk3Mv549a7hMM4iVB93v95qUXh4fe+YBKmhJeWY1t\n 60bay3AQMSRg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9684\"; a=\"234275715\"", "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"234275715\"", "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"486152272\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "David Coyle <david.coyle@intel.com>", "To": "akhil.goyal@nxp.com, declan.doherty@intel.com,\n pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com", "Cc": "dev@dpdk.org, brendan.ryan@intel.com, mairtin.oloingsigh@intel.com,\n David Coyle <david.coyle@intel.com>", "Date": "Thu, 16 Jul 2020 16:35:59 +0100", "Message-Id": "<20200716153600.66071-2-david.coyle@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200716153600.66071-1-david.coyle@intel.com>", "References": "<20200716153600.66071-1-david.coyle@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 1/2] crypto/qat: improve security instance\n\tsetup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch makes some minor improvements to the security instance setup\nfor the QAT SYM PMD. All of this setup code is now in one '#ifdef\nRTE_LIBRTE_SECURITY' block. Enabling the RTE_CRYPTODEV_FF_SECURITY\nfeature for the device is also moved to this block.\n\nFixes: 6f0ef237404b (\"crypto/qat: support DOCSIS protocol\")\n\nSigned-off-by: David Coyle <david.coyle@intel.com>\n---\n drivers/crypto/qat/qat_sym_pmd.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex c7e323cce..7c760f9d2 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -346,10 +346,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \t\t}\n \t}\n \n-#ifdef RTE_LIBRTE_SECURITY\n-\tstruct rte_security_ctx *security_instance;\n-#endif\n-\n \tsnprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, \"%s_%s\",\n \t\t\tqat_pci_dev->name, \"sym\");\n \tQAT_LOG(DEBUG, \"Creating QAT SYM device %s\", name);\n@@ -381,8 +377,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \t\t\tRTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |\n-\t\t\tRTE_CRYPTODEV_FF_DIGEST_ENCRYPTED |\n-\t\t\tRTE_CRYPTODEV_FF_SECURITY;\n+\t\t\tRTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -392,6 +387,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \t\t\tqat_pci_dev->qat_dev_gen);\n \n #ifdef RTE_LIBRTE_SECURITY\n+\tstruct rte_security_ctx *security_instance;\n \tsecurity_instance = rte_malloc(\"qat_sec\",\n \t\t\t\tsizeof(struct rte_security_ctx),\n \t\t\t\tRTE_CACHE_LINE_SIZE);\n@@ -405,6 +401,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n \tsecurity_instance->ops = &security_qat_ops;\n \tsecurity_instance->sess_cnt = 0;\n \tcryptodev->security_ctx = security_instance;\n+\tcryptodev->feature_flags |= RTE_CRYPTODEV_FF_SECURITY;\n #endif\n \n \tinternals = cryptodev->data->dev_private;\n", "prefixes": [ "v1", "1/2" ] }