Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 74257,
    "url": "http://patches.dpdk.org/api/patches/74257/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200716152952.65107-2-david.coyle@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200716152952.65107-2-david.coyle@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200716152952.65107-2-david.coyle@intel.com",
    "date": "2020-07-16T15:29:51",
    "name": "[v1,1/2] test/crypto: enable security feature for security tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "936247242eb67c82ef5935a7772f429b399040f0",
    "submitter": {
        "id": 961,
        "url": "http://patches.dpdk.org/api/people/961/?format=api",
        "name": "Coyle, David",
        "email": "david.coyle@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200716152952.65107-2-david.coyle@intel.com/mbox/",
    "series": [
        {
            "id": 11103,
            "url": "http://patches.dpdk.org/api/series/11103/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11103",
            "date": "2020-07-16T15:29:50",
            "name": "enable security feature for security tests",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/11103/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/74257/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/74257/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0CE42A0546;\n\tThu, 16 Jul 2020 17:54:10 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB1B51BEAC;\n\tThu, 16 Jul 2020 17:54:05 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 4992A2C58\n for <dev@dpdk.org>; Thu, 16 Jul 2020 17:54:02 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Jul 2020 08:54:01 -0700",
            "from silpixa00399912.ir.intel.com (HELO\n silpixa00399912.ger.corp.intel.com) ([10.237.223.64])\n by fmsmga004.fm.intel.com with ESMTP; 16 Jul 2020 08:54:00 -0700"
        ],
        "IronPort-SDR": [
            "\n lf2O/QBsYbMrL6uVdexebT4MDKghSFeD5gy7aU00BOcHRuqmC8hs3GQgQD5CGGoagI/D2td699\n tSb6jp47FLgQ==",
            "\n qO/QuWJaoQYb8TXqLA6bQ/IBfPjFshiBOHD8CvplwCiRr2lVJ70LeS9rmgvbbVzrEbCt82Wgnm\n t14Hf4ReVZ4w=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9684\"; a=\"150793859\"",
            "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"150793859\"",
            "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"308680193\""
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "David Coyle <david.coyle@intel.com>",
        "To": "akhil.goyal@nxp.com, declan.doherty@intel.com,\n pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com",
        "Cc": "dev@dpdk.org, brendan.ryan@intel.com, mairtin.oloingsigh@intel.com,\n David Coyle <david.coyle@intel.com>",
        "Date": "Thu, 16 Jul 2020 16:29:51 +0100",
        "Message-Id": "<20200716152952.65107-2-david.coyle@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200716152952.65107-1-david.coyle@intel.com>",
        "References": "<20200716152952.65107-1-david.coyle@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for\n\tsecurity tests",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the\nff_disable device configuration option for all cryptodev tests,\nincluding security related tests. This patch updates the cryptodev unit\ntests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP\nsecurity tests.\n\nFixes: ea31f2b4f547 (\"test/crypto: add DOCSIS security cases\")\n\nSigned-off-by: David Coyle <david.coyle@intel.com>\n---\n app/test/test_cryptodev.c | 22 ++++++++++++++++++----\n 1 file changed, 18 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 42e47059a..3d3548bb4 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -631,7 +631,7 @@ testsuite_teardown(void)\n }\n \n static int\n-ut_setup(void)\n+dev_configure_and_start(uint64_t ff_disable)\n {\n \tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n \tstruct crypto_unittest_params *ut_params = &unittest_params;\n@@ -643,7 +643,7 @@ ut_setup(void)\n \n \t/* Reconfigure device to default parameters */\n \tts_params->conf.socket_id = SOCKET_ID_ANY;\n-\tts_params->conf.ff_disable = RTE_CRYPTODEV_FF_SECURITY;\n+\tts_params->conf.ff_disable = ff_disable;\n \tts_params->qp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT;\n \tts_params->qp_conf.mp_session = ts_params->session_mpool;\n \tts_params->qp_conf.mp_session_private = ts_params->session_priv_mpool;\n@@ -673,6 +673,20 @@ ut_setup(void)\n \treturn TEST_SUCCESS;\n }\n \n+static int\n+ut_setup(void)\n+{\n+\t/* Configure and start the device with security feature disabled */\n+\treturn dev_configure_and_start(RTE_CRYPTODEV_FF_SECURITY);\n+}\n+\n+static int\n+ut_setup_security(void)\n+{\n+\t/* Configure and start the device with no features disabled */\n+\treturn dev_configure_and_start(0);\n+}\n+\n static void\n ut_teardown(void)\n {\n@@ -12533,9 +12547,9 @@ static struct unit_test_suite cryptodev_testsuite  = {\n \t\t\ttest_verify_auth_aes_cmac_cipher_null_test_case_1),\n \n #ifdef RTE_LIBRTE_SECURITY\n-\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\tTEST_CASE_ST(ut_setup_security, ut_teardown,\n \t\t\ttest_PDCP_PROTO_all),\n-\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\tTEST_CASE_ST(ut_setup_security, ut_teardown,\n \t\t\ttest_DOCSIS_PROTO_all),\n #endif\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n",
    "prefixes": [
        "v1",
        "1/2"
    ]
}