Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74096/?format=api
{ "id": 74096, "url": "http://patches.dpdk.org/api/patches/74096/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1594818621-438919-2-git-send-email-suanmingm@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594818621-438919-2-git-send-email-suanmingm@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594818621-438919-2-git-send-email-suanmingm@mellanox.com", "date": "2020-07-15T13:10:20", "name": "[1/2] common/mlx5: add scatter FCS with decap capability query", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2953500b58691c282022300e9e15bc7b614ceabb", "submitter": { "id": 1358, "url": "http://patches.dpdk.org/api/people/1358/?format=api", "name": "Suanming Mou", "email": "suanmingm@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1594818621-438919-2-git-send-email-suanmingm@mellanox.com/mbox/", "series": [ { "id": 11050, "url": "http://patches.dpdk.org/api/series/11050/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11050", "date": "2020-07-15T13:10:19", "name": "net/mlx5: scatter FCS with decapsulation", "version": 1, "mbox": "http://patches.dpdk.org/series/11050/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74096/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 897AAA0547;\n\tWed, 15 Jul 2020 15:10:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB00C1BED7;\n\tWed, 15 Jul 2020 15:10:31 +0200 (CEST)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id C02971BEA8\n for <dev@dpdk.org>; Wed, 15 Jul 2020 15:10:28 +0200 (CEST)" ], "From": "Suanming Mou <suanmingm@mellanox.com>", "To": "viacheslavo@mellanox.com,\n\tmatan@mellanox.com", "Cc": "orika@mellanox.com,\n\trasland@mellanox.com,\n\tdev@dpdk.org", "Date": "Wed, 15 Jul 2020 21:10:20 +0800", "Message-Id": "<1594818621-438919-2-git-send-email-suanmingm@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1594818621-438919-1-git-send-email-suanmingm@mellanox.com>", "References": "<1594818621-438919-1-git-send-email-suanmingm@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 1/2] common/mlx5: add scatter FCS with decap\n\tcapability query", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As scatter FCS might be not supported for decapsulated tunnel\npackets in some NIC HW, an new capability bit which indicates\nif scatter FCS works with decap is added.\n\nSigned-off-by: Suanming Mou <suanmingm@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n doc/guides/nics/mlx5.rst | 5 +++++\n drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++\n drivers/common/mlx5/mlx5_devx_cmds.h | 1 +\n drivers/common/mlx5/mlx5_prm.h | 4 +++-\n 4 files changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 4b6d8fb..97261d6 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -279,6 +279,11 @@ Limitations\n \n Other TCP packets (e.g. with MPLS label) received on Rx queue with LRO enabled, will be received with bad checksum.\n \n+- KEEP_CRC:\n+\n+ - KEEP_CRC offload cannot be supported with decapsulation for some NICs(such as ConnectX-6DX and BlueField2).\n+ The new capability bit scatter_fcs_w_decap_disable shows the supporting for the NICs.\n+\n Statistics\n ----------\n \ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 2179a83..4cd92a9 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -467,6 +467,8 @@ struct mlx5_devx_obj *\n \tattr->vdpa.queue_counters_valid = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n \t\t\t\t\t\t\tgeneral_obj_types) &\n \t\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_VIRTIO_Q_COUNTERS);\n+\tattr->scatter_fcs_w_decap_disable =\n+\t\tMLX5_GET(cmd_hca_cap, hcattr, scatter_fcs_w_decap_disable);\n \tif (attr->qos.sup) {\n \t\tMLX5_SET(query_hca_cap_in, in, op_mod,\n \t\t\t MLX5_GET_HCA_CAP_OP_MOD_QOS_CAP |\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h\nindex 25704ef..930f78f 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.h\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.h\n@@ -90,6 +90,7 @@ struct mlx5_hca_attr {\n \tuint32_t vhca_id:16;\n \tuint32_t relaxed_ordering_write:1;\n \tuint32_t relaxed_ordering_read:1;\n+\tuint32_t scatter_fcs_w_decap_disable:1;\n \tstruct mlx5_hca_qos_attr qos;\n \tstruct mlx5_hca_vdpa_attr vdpa;\n };\ndiff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex c63795f..d157457 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -996,7 +996,9 @@ struct mlx5_ifc_cmd_hca_cap_bits {\n \tu8 log_max_qp[0x5];\n \tu8 reserved_at_a0[0xb];\n \tu8 log_max_srq[0x5];\n-\tu8 reserved_at_b0[0x10];\n+\tu8 reserved_at_b0[0xb];\n+\tu8 scatter_fcs_w_decap_disable[0x1];\n+\tu8 reserved_at_bc[0x4];\n \tu8 reserved_at_c0[0x8];\n \tu8 log_max_cq_sz[0x8];\n \tu8 reserved_at_d0[0xb];\n", "prefixes": [ "1/2" ] }