Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73990/?format=api
{ "id": 73990, "url": "http://patches.dpdk.org/api/patches/73990/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1594707369-36270-5-git-send-email-xavier.huwei@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594707369-36270-5-git-send-email-xavier.huwei@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594707369-36270-5-git-send-email-xavier.huwei@huawei.com", "date": "2020-07-14T06:16:09", "name": "[v3,4/4] net/hns3: fix RSS configuration when empty RSS type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c0acd4c7c7ac5b77f563b37d542651ba4e5c7f5e", "submitter": { "id": 1405, "url": "http://patches.dpdk.org/api/people/1405/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1594707369-36270-5-git-send-email-xavier.huwei@huawei.com/mbox/", "series": [ { "id": 11011, "url": "http://patches.dpdk.org/api/series/11011/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11011", "date": "2020-07-14T06:16:07", "name": "updates for hns3 PMD driver", "version": 3, "mbox": "http://patches.dpdk.org/series/11011/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73990/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/73990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C43DA0540;\n\tTue, 14 Jul 2020 08:18:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2DBE71D57F;\n\tTue, 14 Jul 2020 08:18:12 +0200 (CEST)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by dpdk.org (Postfix) with ESMTP id 3569F1D56E\n for <dev@dpdk.org>; Tue, 14 Jul 2020 08:18:09 +0200 (CEST)", "from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60])\n by Forcepoint Email with ESMTP id 618D031D4539B3B9FAD2\n for <dev@dpdk.org>; Tue, 14 Jul 2020 14:18:07 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id\n 14.3.487.0; Tue, 14 Jul 2020 14:17:57 +0800" ], "From": "\"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<xavier.huwei@huawei.com>", "Date": "Tue, 14 Jul 2020 14:16:09 +0800", "Message-ID": "<1594707369-36270-5-git-send-email-xavier.huwei@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1594707369-36270-1-git-send-email-xavier.huwei@huawei.com>", "References": "<1594462703-21448-2-git-send-email-xavier.huwei@huawei.com>\n <1594707369-36270-1-git-send-email-xavier.huwei@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 4/4] net/hns3: fix RSS configuration when\n\tempty RSS type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lijun Ou <oulijun@huawei.com>\n\nAccording to the definition of RSS types of action attributes from\ntestpmd, the driver will not disable RSS but instead requests the\nunspecified \"best-effort\" settings when upper application call\nrte_flow_create API function to create flow using empty RSS types.\n\nAs a result, here use the default RSS types when RSS types is empty.\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 1e58ad7..7ec46ae 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1486,7 +1486,9 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t}\n \n \t/* Filter the unsupported flow types */\n-\tflow_types = rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT;\n+\tflow_types = conf->conf.types ?\n+\t\t rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT :\n+\t\t hw->rss_info.conf.types;\n \tif (flow_types != rss_flow_conf.types)\n \t\thns3_warn(hw, \"modified RSS types based on hardware support, \"\n \t\t\t \"requested:%\" PRIx64 \" configured:%\" PRIx64,\n@@ -1494,9 +1496,6 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t/* Update the useful flow types */\n \trss_flow_conf.types = flow_types;\n \n-\tif ((rss_flow_conf.types & ETH_RSS_PROTO_MASK) == 0)\n-\t\treturn hns3_disable_rss(hw);\n-\n \trss_info = &hw->rss_info;\n \tif (!add) {\n \t\tif (hns3_action_rss_same(&rss_info->conf, &rss_flow_conf)) {\n", "prefixes": [ "v3", "4/4" ] }