Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73980/?format=api
{ "id": 73980, "url": "http://patches.dpdk.org/api/patches/73980/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200714053919.5609-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200714053919.5609-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200714053919.5609-5-stephen@networkplumber.org", "date": "2020-07-14T05:39:12", "name": "[v4,04/11] eal: replace usage of blacklist/whitelist in enum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f3e1515e344cfbfbef480f9e19886c35938f7a3b", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200714053919.5609-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 11009, "url": "http://patches.dpdk.org/api/series/11009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11009", "date": "2020-07-14T05:39:08", "name": "rename blacklist/whitelist to exclude/include", "version": 4, "mbox": "http://patches.dpdk.org/series/11009/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73980/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/73980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 766ABA0540;\n\tTue, 14 Jul 2020 07:40:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 54BAF1D404;\n\tTue, 14 Jul 2020 07:39:39 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id A80061D154\n for <dev@dpdk.org>; Tue, 14 Jul 2020 07:39:35 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id q17so6549508pls.9\n for <dev@dpdk.org>; Mon, 13 Jul 2020 22:39:35 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id h9sm15810259pfk.155.2020.07.13.22.39.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Jul 2020 22:39:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=FQBMd78c12cOo2xDuErCrmDo7p14HJg2vlqZ1TAFvV0=;\n b=o8CEAiJKz28K9ruoVk9Fb7mjVeEDhA6rgTrMVE5oKCj994wvhTnwCgFTPwLS3Srmqz\n CIu0hdPYes7FYSX0Kg9wnJvqWYaqMhTOu4POt3xHh+fO1QDCNytZK6tQMK1W1ZSTz7YZ\n olr0zVPGNOcE6GWCskqPqvZ7iLtE2vKBWKA48gM0zx3eoj0F+F/I6WufOwz9ttKZRLgc\n W+nfByvjpK5SQHBNH5mMhRbxb+apXOIqJg6i5I5pU/Wn/XBXzKgoFmbz7HxwLGLGsIQu\n 0ISCAbZjD5WcC+xC/umhCbfcv80FJ8lUrzAquAcbXpsRJLsgbIPZZyCZ8hp+T+kNgGQ3\n zbBw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=FQBMd78c12cOo2xDuErCrmDo7p14HJg2vlqZ1TAFvV0=;\n b=r6ZD9+z2sYz5Hi3Fahpy4HY5e0ZAP/PdsxelJY7/r8HNm4RV8xjP7PYtVHuh6zaQ+R\n uA2esg18LdSqsEazWTOKwV7fcFqeS4qXaP/aTlqmRHTPsfnp0P3a+D0JCakvOUBCE5DU\n +yeZtkN6NRVvzj9AZCO88zbGTtu6F9vBbripKig9uuN/AifPMLbnp92U12hSE84GAuRr\n J5N8oe61d7o8NgEcCVybBr1vBBkE3li0YH1KpyJaSK8St0Pg5ZPnoE26iAY08m6oGRSN\n 056Ee4QwUe6zFdSEZhuHGiF6Op7EFKhmZ7YTs52yGZrH84c4A44c5Xw4HfwhOQ7Hvp6x\n s9vA==", "X-Gm-Message-State": "AOAM532DfZvdA+kB8CB0Ojm4QoChy4Vu5ee+XXhlsZ6jvwpLk+bBat48\n 8NkYc4iQJcMzfoYexNow/ZGMUuhpTkargg==", "X-Google-Smtp-Source": "\n ABdhPJx23wobrQQKn2B+WFeL03NjvXGR0mfd5+6X4eLNB86VBx161o7RKpYtfm8jXySa4ORj1ymQEw==", "X-Received": "by 2002:a17:90a:2367:: with SMTP id\n f94mr3003987pje.20.1594705174376;\n Mon, 13 Jul 2020 22:39:34 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Luca Boccassi <bluca@debian.org>, Gaetan Rivet <grive@u256.net>", "Date": "Mon, 13 Jul 2020 22:39:12 -0700", "Message-Id": "<20200714053919.5609-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200714053919.5609-1-stephen@networkplumber.org>", "References": "<20200613000055.7909-1-stephen@networkplumber.org>\n <20200714053919.5609-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 04/11] eal: replace usage of\n\tblacklist/whitelist in enum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The terms blacklist and whitelist are often seen as reminders\nof the divisions in society. Instead, use more exact terms for\nhandling of which devices are used in DPDK.\n\nThis patch renames the enum values in the EAL include files.\nAs a backward compatible temporary migration tool, define\na replacement mapping for old values.\n\nThe old names relating to blacklist and whitelist are replaced\nby block list and allow list, but applications may be using the\nolder compatibility macros. To help with conversion to new names\ncause a message when the compatibility names are used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Luca Boccassi <bluca@debian.org>\nAcked-by: Gaetan Rivet <grive@u256.net>\n---\n lib/librte_eal/common/eal_common_devargs.c | 14 +++++++-------\n lib/librte_eal/include/rte_bus.h | 8 ++++++--\n lib/librte_eal/include/rte_dev.h | 8 ++++++--\n lib/librte_eal/include/rte_devargs.h | 8 ++++++--\n 4 files changed, 25 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 2123773ef840..d0d58358fee1 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -296,7 +296,7 @@ rte_devargs_insert(struct rte_devargs **da)\n \treturn 0;\n }\n \n-/* store a whitelist parameter for later parsing */\n+/* store an allowlist parameter for later parsing */\n int\n rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n {\n@@ -313,13 +313,13 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \t\tgoto fail;\n \tdevargs->type = devtype;\n \tbus = devargs->bus;\n-\tif (devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI)\n-\t\tdevargs->policy = RTE_DEV_BLACKLISTED;\n+\tif (devargs->type == RTE_DEVTYPE_BLOCKED_PCI)\n+\t\tdevargs->policy = RTE_DEV_BLOCKED;\n \tif (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) {\n-\t\tif (devargs->policy == RTE_DEV_WHITELISTED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_WHITELIST;\n-\t\telse if (devargs->policy == RTE_DEV_BLACKLISTED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_BLACKLIST;\n+\t\tif (devargs->policy == RTE_DEV_ALLOWED)\n+\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_ALLOWLIST;\n+\t\telse if (devargs->policy == RTE_DEV_BLOCKED)\n+\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_BLOCKLIST;\n \t}\n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\ndiff --git a/lib/librte_eal/include/rte_bus.h b/lib/librte_eal/include/rte_bus.h\nindex d3034d0edf77..19309ad2ddd7 100644\n--- a/lib/librte_eal/include/rte_bus.h\n+++ b/lib/librte_eal/include/rte_bus.h\n@@ -215,10 +215,14 @@ typedef int (*rte_bus_sigbus_handler_t)(const void *failure_addr);\n */\n enum rte_bus_scan_mode {\n \tRTE_BUS_SCAN_UNDEFINED,\n-\tRTE_BUS_SCAN_WHITELIST,\n-\tRTE_BUS_SCAN_BLACKLIST,\n+\tRTE_BUS_SCAN_ALLOWLIST,\n+\tRTE_BUS_SCAN_BLOCKLIST,\n };\n \n+/* Backwards compatibility will be deprecated */\n+#define RTE_BUS_SCAN_WHITELIST RTE_BUS_SCAN_ALLOWLIST\n+#define RTE_BUS_SCAN_BLACKLIST\tRTE_BUS_SCAN_BLOCKLIST\n+\n /**\n * A structure used to configure bus operations.\n */\ndiff --git a/lib/librte_eal/include/rte_dev.h b/lib/librte_eal/include/rte_dev.h\nindex c8d985fb5cf9..1208b1e99b05 100644\n--- a/lib/librte_eal/include/rte_dev.h\n+++ b/lib/librte_eal/include/rte_dev.h\n@@ -70,10 +70,14 @@ enum rte_kernel_driver {\n * Device policies.\n */\n enum rte_dev_policy {\n-\tRTE_DEV_WHITELISTED,\n-\tRTE_DEV_BLACKLISTED,\n+\tRTE_DEV_ALLOWED,\n+\tRTE_DEV_BLOCKED,\n };\n \n+/* Backwards compatiablity will be deprecated */\n+#define RTE_DEV_WHITELISTED RTE_DEV_ALLOWED\n+#define RTE_DEV_BLACKLISTED RTE_DEV_BLOCKED\n+\n /**\n * A generic memory resource representation.\n */\ndiff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h\nindex 898efa0d667b..e1a4277ff167 100644\n--- a/lib/librte_eal/include/rte_devargs.h\n+++ b/lib/librte_eal/include/rte_devargs.h\n@@ -29,11 +29,15 @@ extern \"C\" {\n * Type of generic device\n */\n enum rte_devtype {\n-\tRTE_DEVTYPE_WHITELISTED_PCI,\n-\tRTE_DEVTYPE_BLACKLISTED_PCI,\n+\tRTE_DEVTYPE_ALLOWED_PCI,\n+\tRTE_DEVTYPE_BLOCKED_PCI,\n \tRTE_DEVTYPE_VIRTUAL,\n };\n \n+/* Backwards compatiablity will be removed later */\n+#define RTE_DEVTYPE_WHITELISTED_PCI RTE_DEVTYPE_ALLOWED_PCI\n+#define RTE_DEVTYPE_BLACKLISTED_PCI RTE_DEVTYPE_BLOCKED_PCI\n+\n /**\n * Structure that stores a device given by the user with its arguments\n *\n", "prefixes": [ "v4", "04/11" ] }