Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73781/?format=api
{ "id": 73781, "url": "http://patches.dpdk.org/api/patches/73781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200710214343.1407419-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710214343.1407419-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710214343.1407419-1-ferruh.yigit@intel.com", "date": "2020-07-10T21:43:41", "name": "[v7,1/3] drivers/net: fix build with internal API usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e1ec82cad6da0f8a088b80a7e42882d16eaeffd9", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200710214343.1407419-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 10960, "url": "http://patches.dpdk.org/api/series/10960/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10960", "date": "2020-07-10T21:43:41", "name": "[v7,1/3] drivers/net: fix build with internal API usage", "version": 7, "mbox": "http://patches.dpdk.org/series/10960/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73781/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/73781/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8553CA052A;\n\tFri, 10 Jul 2020 23:43:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A5BB61DB78;\n\tFri, 10 Jul 2020 23:43:52 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id F16011DB6C;\n Fri, 10 Jul 2020 23:43:50 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jul 2020 14:43:49 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga005.jf.intel.com with ESMTP; 10 Jul 2020 14:43:46 -0700" ], "IronPort-SDR": [ "\n LqPvPZLxEpiN6IGXAr0bmNtVU9VOjb4mjmJpteus+CGvOiGf9r+SY/8v505UiP1a6dXI5Y3ANT\n rGhkqAwrbFWA==", "\n /HCP01vz9pH3lvQEhrIBh0E71QeGjgFefggiuUMOMMAP7nOvPVvIwLPPPUipo9XLa9wXVbWZgH\n BzG/GGFSlwQQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9678\"; a=\"213173753\"", "E=Sophos;i=\"5.75,336,1589266800\"; d=\"scan'208\";a=\"213173753\"", "E=Sophos;i=\"5.75,336,1589266800\"; d=\"scan'208\";a=\"458406642\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Igor Russkikh <igor.russkikh@aquantia.com>,\n Pavel Belous <pavel.belous@aquantia.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>, Beilei Xing <beilei.xing@intel.com>,\n Jeff Guo <jia.guo@intel.com>, Wei Zhao <wei.zhao1@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Shreyansh Jain <shreyansh.jain@nxp.com>", "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org,\n David Marchand <david.marchand@redhat.com>", "Date": "Fri, 10 Jul 2020 22:43:41 +0100", "Message-Id": "<20200710214343.1407419-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200710144208.499544-1-ferruh.yigit@intel.com>", "References": "<20200710144208.499544-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API\n\tusage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error\nfor applications and examples. Because they don't define\n'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error.\nThis patch is preparation for future '__rte_internal' usage.\n\nAt first place, applications/examples should not include\n'rte_ethdev_driver.h', this is happening because of PMD public header\nfiles include 'rte_ethdev_driver.h' by mistake.\n\nUpdated PMD public header files to not include internal header files.\n\nBut for unit test application, 'app/test', enable accessing internal\nAPIs, since some unit tests need them.\n\nFixes: ffc905f3b856 (\"ethdev: separate driver APIs\")\nFixes: ec0dec44ecb9 (\"net/atlantic: enable MACsec configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: David Marchand <david.marchand@redhat.com>\n---\n app/test/meson.build | 3 +++\n drivers/net/atlantic/rte_pmd_atlantic.h | 2 +-\n drivers/net/bnxt/rte_pmd_bnxt.h | 3 ++-\n drivers/net/dpaa/rte_pmd_dpaa.h | 2 --\n drivers/net/i40e/rte_pmd_i40e.h | 4 +++-\n drivers/net/ixgbe/rte_pmd_ixgbe.h | 4 +++-\n 6 files changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex e0d33ea5ef..786a213972 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -396,6 +396,9 @@ cflags += '-D_GNU_SOURCE'\n # Strict-aliasing rules are violated by uint8_t[] to context size casts.\n cflags += '-fno-strict-aliasing'\n \n+# Enable using internal APIs in unit tests\n+cflags += ['-DALLOW_INTERNAL_API']\n+\n test_dep_objs = []\n if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')\n \tcompress_test_dep = dependency('zlib', required: false)\ndiff --git a/drivers/net/atlantic/rte_pmd_atlantic.h b/drivers/net/atlantic/rte_pmd_atlantic.h\nindex c0208569b6..0100fc16e5 100644\n--- a/drivers/net/atlantic/rte_pmd_atlantic.h\n+++ b/drivers/net/atlantic/rte_pmd_atlantic.h\n@@ -11,7 +11,7 @@\n #ifndef _PMD_ATLANTIC_H_\n #define _PMD_ATLANTIC_H_\n \n-#include <rte_ethdev_driver.h>\n+#include <rte_compat.h>\n \n /**\n * @warning\ndiff --git a/drivers/net/bnxt/rte_pmd_bnxt.h b/drivers/net/bnxt/rte_pmd_bnxt.h\nindex 2e893cc7bf..81d0d0e032 100644\n--- a/drivers/net/bnxt/rte_pmd_bnxt.h\n+++ b/drivers/net/bnxt/rte_pmd_bnxt.h\n@@ -6,7 +6,8 @@\n #ifndef _PMD_BNXT_H_\n #define _PMD_BNXT_H_\n \n-#include <rte_ethdev_driver.h>\n+#include <rte_ethdev.h>\n+#include <rte_ether.h>\n \n /*\n * Response sent back to the caller after callback\ndiff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd_dpaa.h\nindex 37eea9b032..8d244bb491 100644\n--- a/drivers/net/dpaa/rte_pmd_dpaa.h\n+++ b/drivers/net/dpaa/rte_pmd_dpaa.h\n@@ -15,8 +15,6 @@\n *\n */\n \n-#include <rte_ethdev_driver.h>\n-\n /**\n * Enable/Disable TX loopback\n *\ndiff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h\nindex 0f6715efc8..fc3560c28c 100644\n--- a/drivers/net/i40e/rte_pmd_i40e.h\n+++ b/drivers/net/i40e/rte_pmd_i40e.h\n@@ -14,7 +14,9 @@\n *\n */\n \n-#include <rte_ethdev_driver.h>\n+#include <rte_compat.h>\n+#include <rte_ethdev.h>\n+#include <rte_ether.h>\n \n /**\n * Response sent back to i40e driver from user app after callback\ndiff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h\nindex 8b6bb99a58..90fc8160b1 100644\n--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h\n+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h\n@@ -11,7 +11,9 @@\n #ifndef _PMD_IXGBE_H_\n #define _PMD_IXGBE_H_\n \n-#include <rte_ethdev_driver.h>\n+#include <rte_compat.h>\n+#include <rte_ethdev.h>\n+#include <rte_ether.h>\n \n /**\n * Notify VF when PF link status changes.\n", "prefixes": [ "v7", "1/3" ] }