Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73610/?format=api
{ "id": 73610, "url": "http://patches.dpdk.org/api/patches/73610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-14-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709080046.65879-14-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709080046.65879-14-guinanx.sun@intel.com", "date": "2020-07-09T08:00:40", "name": "[v3,13/19] net/ixgbe/base: initialize data field in struct buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "47eb735d45956a16f1e5f4555e51aa6f10ea94e3", "submitter": { "id": 1476, "url": "http://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-14-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10915, "url": "http://patches.dpdk.org/api/series/10915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10915", "date": "2020-07-09T08:00:27", "name": "update ixgbe base code", "version": 3, "mbox": "http://patches.dpdk.org/series/10915/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73610/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/73610/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44623A0526;\n\tThu, 9 Jul 2020 10:16:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B8251DFE7;\n\tThu, 9 Jul 2020 10:14:31 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 8D5371DECC\n for <dev@dpdk.org>; Thu, 9 Jul 2020 10:14:19 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:14:19 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:14:17 -0700" ], "IronPort-SDR": [ "\n 4NIaNbttXAHPf7yA5IwYySuS9WoFWwrRUeuf/XgdMS027K8CXunAOL7cj+BNUYpwZK5+oomM4x\n x4A983mTeNvw==", "\n 0a/UuUKMsLfAWbx9coW+xsGDzFfYRdl9Vz/tte7OGgg3vkI80nQHeP2GhYxeT7WKGjsI904Eo+\n /duSd0xtiRvQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"212869387\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"212869387\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"297989278\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>,\n Krzysztof Galazka <krzysztof.galazka@intel.com>,\n Piotr Pietruszewski <piotr.pietruszewski@intel.com>", "Date": "Thu, 9 Jul 2020 08:00:40 +0000", "Message-Id": "<20200709080046.65879-14-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200709080046.65879-1-guinanx.sun@intel.com>", "References": "<20200702031329.4495-1-guinanx.sun@intel.com>\n <20200709080046.65879-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 13/19] net/ixgbe/base: initialize data field\n\tin struct buffer", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While sending request using ixgbe_hic_unlocked() the data field in\nbuffer struct is not used. It is set when the struct is overwritten by\nFW to deliver the response. To not pass random data to FW the whole\nstructure should be zeroed before use.\n\nSigned-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>\nSigned-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex d3363ff1d..8343efbc2 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -3126,6 +3126,7 @@ s32 ixgbe_read_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset, u16 *data)\n \t/* one word */\n \tbuffer.length = IXGBE_CPU_TO_BE16(sizeof(u16));\n \tbuffer.pad2 = 0;\n+\tbuffer.data = 0;\n \tbuffer.pad3 = 0;\n \n \tstatus = hw->mac.ops.acquire_swfw_sync(hw, mask);\n@@ -3186,6 +3187,7 @@ s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw,\n \t\tbuffer.address = IXGBE_CPU_TO_BE32((offset + current_word) * 2);\n \t\tbuffer.length = IXGBE_CPU_TO_BE16(words_to_read * 2);\n \t\tbuffer.pad2 = 0;\n+\t\tbuffer.data = 0;\n \t\tbuffer.pad3 = 0;\n \n \t\tstatus = ixgbe_hic_unlocked(hw, (u32 *)&buffer, sizeof(buffer),\n", "prefixes": [ "v3", "13/19" ] }