Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73220/?format=api
{ "id": 73220, "url": "http://patches.dpdk.org/api/patches/73220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200706093705.65323-1-shougangx.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706093705.65323-1-shougangx.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706093705.65323-1-shougangx.wang@intel.com", "date": "2020-07-06T09:37:05", "name": "net/ice: fix incorrect error log in generic flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fdf5e085d4e4d727940c3754c0e6590e4c1fbb74", "submitter": { "id": 1418, "url": "http://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200706093705.65323-1-shougangx.wang@intel.com/mbox/", "series": [ { "id": 10807, "url": "http://patches.dpdk.org/api/series/10807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10807", "date": "2020-07-06T09:37:05", "name": "net/ice: fix incorrect error log in generic flow", "version": 1, "mbox": "http://patches.dpdk.org/series/10807/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73220/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/73220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6ABDFA00C5;\n\tMon, 6 Jul 2020 11:57:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4D8581DA23;\n\tMon, 6 Jul 2020 11:57:55 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id B90A41DA0F;\n Mon, 6 Jul 2020 11:57:53 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2020 02:57:52 -0700", "from intel.sh.intel.com ([10.239.255.20])\n by orsmga002.jf.intel.com with ESMTP; 06 Jul 2020 02:57:50 -0700" ], "IronPort-SDR": [ "\n Htvg6/cUgXOV7l/dLzxIhHbUkehY1a7nmQSIz+NqRBROPZYkaQ35ks6Y3NSrSX/ClKYaVHNeat\n lHN0F5uqKHjA==", "\n CW6+C0+vDll+jnYl05YGpbNsvZw6BasFlM6f1pIW33ImEUnhT/SoxnFIxisFMgIcFgSO6dyor4\n RwCC5+Z0VDNg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9673\"; a=\"127457087\"", "E=Sophos;i=\"5.75,318,1589266800\"; d=\"scan'208\";a=\"127457087\"", "E=Sophos;i=\"5.75,318,1589266800\"; d=\"scan'208\";a=\"296951107\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Shougang Wang <shougangx.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "Qi Zhang <qi.z.zhang@intel.com>, Yang Qiming <qiming.yang@intel.com>,\n Shougang Wang <shougangx.wang@intel.com>, stable@dpdk.org", "Date": "Mon, 6 Jul 2020 09:37:05 +0000", "Message-Id": "<20200706093705.65323-1-shougangx.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When create a rss rule with void action, the error log is \"Invalid\ninput set\". This patch fix the issue by adding check for the type of\nfirst actions item.\n\nFixes: 7615a6895009 (\"net/ice: rework for generic flow enabling\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shougang Wang <shougangx.wang@intel.com>\n---\n drivers/net/ice/ice_generic_flow.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c\nindex ad103d0e8..80ef0e323 100644\n--- a/drivers/net/ice/ice_generic_flow.c\n+++ b/drivers/net/ice/ice_generic_flow.c\n@@ -1873,7 +1873,7 @@ ice_flow_process_filter(struct rte_eth_dev *dev,\n \t\treturn -rte_errno;\n \t}\n \n-\tif (!actions) {\n+\tif (!actions || actions->type == RTE_FLOW_ACTION_TYPE_END) {\n \t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n \t\t\t\t NULL, \"NULL action.\");\n", "prefixes": [] }