Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73184/?format=api
http://patches.dpdk.org/api/patches/73184/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200706081222.19279-20-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706081222.19279-20-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706081222.19279-20-guinanx.sun@intel.com", "date": "2020-07-06T08:12:14", "name": "[v3,19/27] net/e1000/base: modify flow control setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9da58f2a9f2b95f365b1251abe11a4822504e03d", "submitter": { "id": 1476, "url": "http://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200706081222.19279-20-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10803, "url": "http://patches.dpdk.org/api/series/10803/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10803", "date": "2020-07-06T08:11:55", "name": "update e1000 base code", "version": 3, "mbox": "http://patches.dpdk.org/series/10803/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73184/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/73184/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4606FA00C5;\n\tMon, 6 Jul 2020 10:26:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5DF6E1D9A4;\n\tMon, 6 Jul 2020 10:24:33 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 306321D9A4\n for <dev@dpdk.org>; Mon, 6 Jul 2020 10:24:31 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2020 01:24:30 -0700", "from intel.sh.intel.com ([10.239.255.48])\n by fmsmga001.fm.intel.com with ESMTP; 06 Jul 2020 01:24:28 -0700" ], "IronPort-SDR": [ "\n H21VyrieEGtQbGuUf7ixf6Ry3Knu2qi2fKDRtQMX8XC6UTepRUzMHlkuzMl3jI4RjGrfxjDzJM\n gxlJKkCQAAxQ==", "\n /a9wdeLHSY2fwH7oC+OyCud94PVghKRh4x2xHYo2LvhaJ4c6lO+AjxTbr8+wFrMLK8Iw6hFNeQ\n zOA6AI+bqZEA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9673\"; a=\"147379318\"", "E=Sophos;i=\"5.75,318,1589266800\"; d=\"scan'208\";a=\"147379318\"", "E=Sophos;i=\"5.75,318,1589266800\"; d=\"scan'208\";a=\"388128961\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>, Efrati Nir <nir.efrati@intel.com>", "Date": "Mon, 6 Jul 2020 08:12:14 +0000", "Message-Id": "<20200706081222.19279-20-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200706081222.19279-1-guinanx.sun@intel.com>", "References": "<20200622064634.70941-1-guinanx.sun@intel.com>\n <20200706081222.19279-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 19/27] net/e1000/base: modify flow control\n\tsetup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Customers had a problem with large pings after connected standby.\nThis is due to the requirement of maintaining link after CS - the driver\nblocks resets during \"AdapterStart\" and skips flow control setup.\nAdded condition in e1000_setup_link_ich8lan.c function that always setup\nflow control, and setup physical interface only when no need to block\nresets.\n\nSigned-off-by: Efrati Nir <nir.efrati@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/e1000/base/e1000_ich8lan.c | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c\nindex 9b9cc7d90..85344ebeb 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.c\n+++ b/drivers/net/e1000/base/e1000_ich8lan.c\n@@ -5200,9 +5200,6 @@ STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw)\n \n \tDEBUGFUNC(\"e1000_setup_link_ich8lan\");\n \n-\tif (hw->phy.ops.check_reset_block(hw))\n-\t\treturn E1000_SUCCESS;\n-\n \t/* ICH parts do not have a word in the NVM to determine\n \t * the default flow control setting, so we explicitly\n \t * set it to full.\n@@ -5218,10 +5215,12 @@ STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw)\n \tDEBUGOUT1(\"After fix-ups FlowControl is now = %x\\n\",\n \t\thw->fc.current_mode);\n \n-\t/* Continue to configure the copper link. */\n-\tret_val = hw->mac.ops.setup_physical_interface(hw);\n-\tif (ret_val)\n-\t\treturn ret_val;\n+\tif (!hw->phy.ops.check_reset_block(hw)) {\n+\t\t/* Continue to configure the copper link. */\n+\t\tret_val = hw->mac.ops.setup_physical_interface(hw);\n+\t\tif (ret_val)\n+\t\t\treturn ret_val;\n+\t}\n \n \tE1000_WRITE_REG(hw, E1000_FCTTV, hw->fc.pause_time);\n \tif ((hw->phy.type == e1000_phy_82578) ||\n", "prefixes": [ "v3", "19/27" ] }{ "id": 73184, "url": "