Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73020/?format=api
{ "id": 73020, "url": "http://patches.dpdk.org/api/patches/73020/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200703102829.52581-3-gordon.noonan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200703102829.52581-3-gordon.noonan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200703102829.52581-3-gordon.noonan@intel.com", "date": "2020-07-03T10:28:23", "name": "[RFC,2/8] net/iavf: support 64 queues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "27a4aa99a802609226a9d06cc4d52628b6252d78", "submitter": { "id": 1810, "url": "http://patches.dpdk.org/api/people/1810/?format=api", "name": null, "email": "Gordon@dpdk.org, Noonan@dpdk.org, gordon.noonan@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200703102829.52581-3-gordon.noonan@intel.com/mbox/", "series": [ { "id": 10778, "url": "http://patches.dpdk.org/api/series/10778/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10778", "date": "2020-07-03T10:28:21", "name": "net/iavf: Enable 256 queues", "version": 1, "mbox": "http://patches.dpdk.org/series/10778/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73020/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/73020/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F13C6A0519;\n\tFri, 3 Jul 2020 16:37:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 72D681DC27;\n\tFri, 3 Jul 2020 16:37:43 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 7CD761DB1A\n for <dev@dpdk.org>; Fri, 3 Jul 2020 12:28:53 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jul 2020 03:28:52 -0700", "from silpixa00400380.ir.intel.com ([10.237.213.188])\n by fmsmga004.fm.intel.com with ESMTP; 03 Jul 2020 03:28:51 -0700" ], "IronPort-SDR": [ "\n EX8jNGbvxXmqnpHdohYrq4GG1tWsE/o5hTzonQ/OeqZbjn29GiODeelgfKsieQnlJObTzaMF6m\n Bx0EPUtT3o2A==", "\n 5jmvzgPKt7dReCLCCOAYwG2QHbnYQeLO26zS+R9XDRhqmtBQr39mf048y6K1SHpCVevGBbXUqD\n UR9t9PtggTuQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9670\"; a=\"208641900\"", "E=Sophos;i=\"5.75,307,1589266800\"; d=\"scan'208\";a=\"208641900\"", "E=Sophos;i=\"5.75,308,1589266800\"; d=\"scan'208\";a=\"304548475\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Gordon@dpdk.org, Noonan@dpdk.org, gordon.noonan@intel.com", "To": "dev@dpdk.org", "Cc": "gordon.noonan@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Fri, 3 Jul 2020 11:28:23 +0100", "Message-Id": "<20200703102829.52581-3-gordon.noonan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200703102829.52581-1-gordon.noonan@intel.com>", "References": "<20200703102829.52581-1-gordon.noonan@intel.com>", "X-Mailman-Approved-At": "Fri, 03 Jul 2020 16:37:41 +0200", "Subject": "[dpdk-dev] [PATCH RFC 2/8] net/iavf: support 64 queues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Qi Zhang <qi.z.zhang@intel.com>\n\nEnlarge max queue number from 16 to 64 by using \"large\" vc ops.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/iavf/iavf.h | 4 ++--\n drivers/net/iavf/iavf_vchnl.c | 35 ++++++++++++++++++-----------------\n 2 files changed, 20 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h\nindex 9be8a2381..039517af9 100644\n--- a/drivers/net/iavf/iavf.h\n+++ b/drivers/net/iavf/iavf.h\n@@ -19,7 +19,7 @@\n #define IAVF_FRAME_SIZE_MAX 9728\n #define IAVF_QUEUE_BASE_ADDR_UNIT 128\n \n-#define IAVF_MAX_NUM_QUEUES 16\n+#define IAVF_MAX_NUM_QUEUES 64\n \n #define IAVF_NUM_MACADDR_MAX 64\n \n@@ -138,7 +138,7 @@ struct iavf_info {\n \tuint16_t nb_msix; /* number of MSI-X interrupts on Rx */\n \tuint16_t msix_base; /* msix vector base from */\n \t/* queue bitmask for each vector */\n-\tuint16_t rxq_map[IAVF_MAX_MSIX_VECTORS];\n+\tuint64_t rxq_map[IAVF_MAX_MSIX_VECTORS];\n \tstruct iavf_flow_list flow_list;\n \trte_spinlock_t flow_ops_lock;\n \tstruct iavf_parser_list rss_parser_list;\ndiff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 33acea54a..2b28d0577 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -383,7 +383,8 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)\n \tcaps = IAVF_BASIC_OFFLOAD_CAPS | VIRTCHNL_VF_CAP_ADV_LINK_SPEED |\n \t\tVIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC |\n \t\tVIRTCHNL_VF_OFFLOAD_FDIR_PF |\n-\t\tVIRTCHNL_VF_OFFLOAD_ADV_RSS_PF;\n+\t\tVIRTCHNL_VF_OFFLOAD_ADV_RSS_PF |\n+\t\tVIRTCHNL_VF_OFFLOAD_LARGE_VF;\n \n \targs.in_args = (uint8_t *)∩︀\n \targs.in_args_size = sizeof(caps);\n@@ -450,7 +451,7 @@ int\n iavf_enable_queues(struct iavf_adapter *adapter)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_queue_select queue_select;\n+\tstruct virtchnl_large_queue_select queue_select;\n \tstruct iavf_cmd_info args;\n \tint err;\n \n@@ -460,7 +461,7 @@ iavf_enable_queues(struct iavf_adapter *adapter)\n \tqueue_select.rx_queues = BIT(adapter->eth_dev->data->nb_rx_queues) - 1;\n \tqueue_select.tx_queues = BIT(adapter->eth_dev->data->nb_tx_queues) - 1;\n \n-\targs.ops = VIRTCHNL_OP_ENABLE_QUEUES;\n+\targs.ops = VIRTCHNL_OP_ENABLE_LARGE_QUEUES;\n \targs.in_args = (u8 *)&queue_select;\n \targs.in_args_size = sizeof(queue_select);\n \targs.out_buffer = vf->aq_resp;\n@@ -468,7 +469,7 @@ iavf_enable_queues(struct iavf_adapter *adapter)\n \terr = iavf_execute_vf_cmd(adapter, &args);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Failed to execute command of OP_ENABLE_QUEUES\");\n+\t\t\t \"Failed to execute command of OP_ENABLE_LARGE_QUEUES\");\n \t\treturn err;\n \t}\n \treturn 0;\n@@ -478,7 +479,7 @@ int\n iavf_disable_queues(struct iavf_adapter *adapter)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_queue_select queue_select;\n+\tstruct virtchnl_large_queue_select queue_select;\n \tstruct iavf_cmd_info args;\n \tint err;\n \n@@ -488,7 +489,7 @@ iavf_disable_queues(struct iavf_adapter *adapter)\n \tqueue_select.rx_queues = BIT(adapter->eth_dev->data->nb_rx_queues) - 1;\n \tqueue_select.tx_queues = BIT(adapter->eth_dev->data->nb_tx_queues) - 1;\n \n-\targs.ops = VIRTCHNL_OP_DISABLE_QUEUES;\n+\targs.ops = VIRTCHNL_OP_DISABLE_LARGE_QUEUES;\n \targs.in_args = (u8 *)&queue_select;\n \targs.in_args_size = sizeof(queue_select);\n \targs.out_buffer = vf->aq_resp;\n@@ -496,7 +497,7 @@ iavf_disable_queues(struct iavf_adapter *adapter)\n \terr = iavf_execute_vf_cmd(adapter, &args);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Failed to execute command of OP_DISABLE_QUEUES\");\n+\t\t\t \"Failed to execute command of OP_DISABLE_LARGE_QUEUES\");\n \t\treturn err;\n \t}\n \treturn 0;\n@@ -507,7 +508,7 @@ iavf_switch_queue(struct iavf_adapter *adapter, uint16_t qid,\n \t\t bool rx, bool on)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_queue_select queue_select;\n+\tstruct virtchnl_large_queue_select queue_select;\n \tstruct iavf_cmd_info args;\n \tint err;\n \n@@ -519,9 +520,9 @@ iavf_switch_queue(struct iavf_adapter *adapter, uint16_t qid,\n \t\tqueue_select.tx_queues |= 1 << qid;\n \n \tif (on)\n-\t\targs.ops = VIRTCHNL_OP_ENABLE_QUEUES;\n+\t\targs.ops = VIRTCHNL_OP_ENABLE_LARGE_QUEUES;\n \telse\n-\t\targs.ops = VIRTCHNL_OP_DISABLE_QUEUES;\n+\t\targs.ops = VIRTCHNL_OP_DISABLE_LARGE_QUEUES;\n \targs.in_args = (u8 *)&queue_select;\n \targs.in_args_size = sizeof(queue_select);\n \targs.out_buffer = vf->aq_resp;\n@@ -529,7 +530,7 @@ iavf_switch_queue(struct iavf_adapter *adapter, uint16_t qid,\n \terr = iavf_execute_vf_cmd(adapter, &args);\n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"Failed to execute command of %s\",\n-\t\t\t on ? \"OP_ENABLE_QUEUES\" : \"OP_DISABLE_QUEUES\");\n+\t\t\t on ? \"OP_ENABLE_LARGE_QUEUES\" : \"OP_DISABLE_LARGE_QUEUES\");\n \treturn err;\n }\n \n@@ -686,13 +687,13 @@ int\n iavf_config_irq_map(struct iavf_adapter *adapter)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_irq_map_info *map_info;\n-\tstruct virtchnl_vector_map *vecmap;\n+\tstruct virtchnl_large_irq_map_info *map_info;\n+\tstruct virtchnl_large_vector_map *vecmap;\n \tstruct iavf_cmd_info args;\n \tint len, i, err;\n \n-\tlen = sizeof(struct virtchnl_irq_map_info) +\n-\t sizeof(struct virtchnl_vector_map) * vf->nb_msix;\n+\tlen = sizeof(struct virtchnl_large_irq_map_info) +\n+\t sizeof(struct virtchnl_large_vector_map) * vf->nb_msix;\n \n \tmap_info = rte_zmalloc(\"map_info\", len, 0);\n \tif (!map_info)\n@@ -708,14 +709,14 @@ iavf_config_irq_map(struct iavf_adapter *adapter)\n \t\tvecmap->rxq_map = vf->rxq_map[vf->msix_base + i];\n \t}\n \n-\targs.ops = VIRTCHNL_OP_CONFIG_IRQ_MAP;\n+\targs.ops = VIRTCHNL_OP_CONFIG_LARGE_IRQ_MAP;\n \targs.in_args = (u8 *)map_info;\n \targs.in_args_size = len;\n \targs.out_buffer = vf->aq_resp;\n \targs.out_size = IAVF_AQ_BUF_SZ;\n \terr = iavf_execute_vf_cmd(adapter, &args);\n \tif (err)\n-\t\tPMD_DRV_LOG(ERR, \"fail to execute command OP_CONFIG_IRQ_MAP\");\n+\t\tPMD_DRV_LOG(ERR, \"fail to execute command OP_CONFIG_LARGE_IRQ_MAP\");\n \n \trte_free(map_info);\n \treturn err;\n", "prefixes": [ "RFC", "2/8" ] }