Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7274/?format=api
http://patches.dpdk.org/api/patches/7274/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1443537175-13809-12-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1443537175-13809-12-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1443537175-13809-12-git-send-email-harry.van.haaren@intel.com", "date": "2015-09-29T14:32:55", "name": "[dpdk-dev,11/11] fm10k: add xstats() implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dfdd9004762e91743fc7380cb26290fb1a38c517", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1443537175-13809-12-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/7274/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/7274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6E3228E8D;\n\tTue, 29 Sep 2015 16:33:43 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 4D2958E8D\n\tfor <dev@dpdk.org>; Tue, 29 Sep 2015 16:33:41 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP; 29 Sep 2015 07:33:42 -0700", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2015 07:33:40 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,608,1437462000\"; d=\"scan'208\";a=\"570543189\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 29 Sep 2015 15:32:55 +0100", "Message-Id": "<1443537175-13809-12-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1443537175-13809-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1443537175-13809-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH 11/11] fm10k: add xstats() implementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add xstats() functions and statistic strings.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 82 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 82 insertions(+)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex a69c990..5ef3553 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -68,6 +68,37 @@ fm10k_MACVLAN_remove_all(struct rte_eth_dev *dev);\n static void fm10k_tx_queue_release(void *queue);\n static void fm10k_rx_queue_release(void *queue);\n \n+struct rte_fm10k_xstats_name_off {\n+\tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n+\tunsigned offset;\n+};\n+\n+struct rte_fm10k_xstats_name_off rte_fm10k_hw_stats_strings[] = {\n+\t{\"completion_timeout_count\", offsetof(struct fm10k_hw_stats, timeout)},\n+\t{\"unsupported_requests_count\", offsetof(struct fm10k_hw_stats, ur)},\n+\t{\"completer_abort_count\", offsetof(struct fm10k_hw_stats, ca)},\n+\t{\"unsupported_message_count\", offsetof(struct fm10k_hw_stats, um)},\n+\t{\"checksum_error_count\", offsetof(struct fm10k_hw_stats, xec)},\n+\t{\"vlan_drops\", offsetof(struct fm10k_hw_stats, vlan_drop)},\n+\t{\"loopback_drops\", offsetof(struct fm10k_hw_stats, loopback_drop)},\n+\t{\"no_descriptor_drops\", offsetof(struct fm10k_hw_stats, nodesc_drop)},\n+};\n+\n+struct rte_fm10k_xstats_name_off rte_fm10k_hw_stats_q_strings[] = {\n+\t{\"tx_q_bytes\", offsetof(struct fm10k_hw_stats_q, tx_bytes)},\n+\t{\"tx_q_packets\", offsetof(struct fm10k_hw_stats_q, tx_packets)},\n+\t{\"rx_q_bytes\", offsetof(struct fm10k_hw_stats_q, rx_bytes)},\n+\t{\"rx_q_packets\", offsetof(struct fm10k_hw_stats_q, rx_packets)},\n+\t{\"rx_q_dropped\", offsetof(struct fm10k_hw_stats_q, rx_drops)},\n+};\n+\n+#define FM10K_NB_HW_XSTATS (sizeof(rte_fm10k_hw_stats_strings) / \\\n+\t\tsizeof(rte_fm10k_hw_stats_strings[0]))\n+#define FM10K_NB_Q_XSTATS (sizeof(rte_fm10k_hw_stats_q_strings) / \\\n+\t\tsizeof(rte_fm10k_hw_stats_q_strings[0]))\n+#define FM10K_NB_XSTATS (FM10K_NB_HW_XSTATS + FM10K_NB_Q_XSTATS * \\\n+\t\tFM10K_MAX_QUEUES_PF)\n+\n static void\n fm10k_mbx_initlock(struct fm10k_hw *hw)\n {\n@@ -867,6 +898,55 @@ fm10k_link_update(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static int\n+fm10k_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n+\t\t unsigned n)\n+{\n+\tstruct fm10k_hw_stats *hw_stats =\n+\t\tFM10K_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n+\tunsigned i, q, count = 0;\n+\n+\tif(n < FM10K_NB_XSTATS)\n+\t\treturn FM10K_NB_XSTATS;\n+\n+\t/* Global stats */\n+\tfor(i = 0; i < FM10K_NB_HW_XSTATS; i++) {\n+\t\tsnprintf(xstats[count].name, sizeof(xstats[count].name),\n+\t\t\t \"%s\", rte_fm10k_hw_stats_strings[count].name);\n+\t\txstats[count].value = *(uint64_t *)(((char *)hw_stats) +\n+\t\t\trte_fm10k_hw_stats_strings[count].offset);\n+\t\tcount++;\n+\t}\n+\n+\t/* PF queue stats */\n+\tfor(q = 0; q < FM10K_MAX_QUEUES_PF; q++) {\n+\t\tfor(i = 0; i < FM10K_NB_Q_XSTATS; i++) {\n+\t\t\tmemcpy(xstats[count].name, rte_fm10k_hw_stats_q_strings,\n+\t\t\t sizeof(char) * 4);\n+\t\t\tsnprintf(&xstats[count].name[4],\n+\t\t\t\t sizeof(xstats[count].name) - 4,\n+\t\t\t\t \"%d%s\", q,\n+\t\t\t\t &rte_fm10k_hw_stats_q_strings[i].name[4]);\n+\t\t\txstats[count].value =\n+\t\t\t\t*(uint64_t *)(((char *)&hw_stats->q[q]) +\n+\t\t\t\trte_fm10k_hw_stats_q_strings[i].offset);\n+\t\t\tcount++;\n+\t\t}\n+\t}\n+\n+\t/* Stats per queue */\n+\tfor(q = 0; q < FM10K_MAX_QUEUES; q++) {\n+\t\tmemcpy(xstats[count].name, rte_fm10k_hw_stats_q_strings[i].name,\n+\t\t sizeof(char) * 4);\n+\t\tsnprintf(&xstats[count].name[4], 36, \"%d%s\", q,\n+\t\t\t &rte_fm10k_hw_stats_q_strings[i].name[4]);\n+\t\tcount++;\n+\t\t/* TODO: more stats - do we want to present them this way? */\n+\t}\n+\n+\treturn FM10K_NB_XSTATS;\n+}\n+\n static void\n fm10k_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n@@ -2034,7 +2114,9 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {\n \t.allmulticast_enable = fm10k_dev_allmulticast_enable,\n \t.allmulticast_disable = fm10k_dev_allmulticast_disable,\n \t.stats_get\t\t= fm10k_stats_get,\n+\t.xstats_get\t\t= fm10k_xstats_get,\n \t.stats_reset\t\t= fm10k_stats_reset,\n+\t.xstats_reset\t\t= fm10k_stats_reset,\n \t.link_update\t\t= fm10k_link_update,\n \t.dev_infos_get\t\t= fm10k_dev_infos_get,\n \t.vlan_filter_set\t= fm10k_vlan_filter_set,\n", "prefixes": [ "dpdk-dev", "11/11" ] }{ "id": 7274, "url": "