Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72522/?format=api
{ "id": 72522, "url": "http://patches.dpdk.org/api/patches/72522/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-13-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701064828.4097247-13-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701064828.4097247-13-jerinj@marvell.com", "date": "2020-07-01T06:48:27", "name": "[v3,12/13] drivers/baseband: use log register macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9900c65da71b17d633f104326a71bcf9f52e7a56", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-13-jerinj@marvell.com/mbox/", "series": [ { "id": 10702, "url": "http://patches.dpdk.org/api/series/10702/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10702", "date": "2020-07-01T06:48:15", "name": "rte_log registration usage improvement", "version": 3, "mbox": "http://patches.dpdk.org/series/10702/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/72522/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/72522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2629EA0350;\n\tWed, 1 Jul 2020 08:50:50 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F0E5B1C115;\n\tWed, 1 Jul 2020 08:50:00 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 30EE01C114\n for <dev@dpdk.org>; Wed, 1 Jul 2020 08:50:00 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0616eNwS000798; Tue, 30 Jun 2020 23:49:59 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 31x5mnq88y-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 30 Jun 2020 23:49:59 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 30 Jun 2020 23:49:57 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 30 Jun 2020 23:49:57 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 2EE133F703F;\n Tue, 30 Jun 2020 23:49:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=F2h0aL816HguQM/YjcxCEFL9c1Hmh8llOzU9rMxmsDQ=;\n b=nKBbuABebdOePrWSR9NLzf0Sr9pclPc1zald1xLzN3+aq3vleCwKatmg6TsCqzo9NGVi\n PcmD4fFFraR0kA8/mT93yczz6BWv0qL4XNP6xhscvqZu13YDNWW3m1S4tuywUAle6DRv\n Qvyjumj9An7wwHOlfOLjlH9LsZRXwm5Pdpe6E2HubXtKcfrkyisRb2reGRfQhsn2tVoA\n 03bKkkeIZ1yXISk/AX/8rGN65+yxIukSXeUdI/ZdL4UsJQJ3GJV+UmGX5yeWJ2heWdgu\n Cd1uR5sb6cIsnOUf6oj8Bmzug0+RWWn1GozmQTUYpLAux4LDGwMrmAd6uvWk5m0xdTXd Iw==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Nicolas Chautru <nicolas.chautru@intel.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, <sachin.saxena@oss.nxp.com>,\n <adamx.dybkowski@intel.com>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 1 Jul 2020 12:18:27 +0530", "Message-ID": "<20200701064828.4097247-13-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701064828.4097247-1-jerinj@marvell.com>", "References": "<20200701035840.4028056-1-jerinj@marvell.com>\n <20200701064828.4097247-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-07-01_03:2020-07-01,\n 2020-07-01 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 12/13] drivers/baseband: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n .../baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 17 +++++------------\n drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 18 +++++-------------\n drivers/baseband/null/bbdev_null.c | 9 +--------\n .../baseband/turbo_sw/bbdev_turbo_software.c | 9 +--------\n 4 files changed, 12 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\nindex e152b206e..aca0ca999 100644\n--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n@@ -23,8 +23,11 @@\n #include \"fpga_5gnr_fec.h\"\n #include \"rte_pmd_fpga_5gnr_fec.h\"\n \n-/* 5GNR SW PMD logging ID */\n-static int fpga_5gnr_fec_logtype;\n+#ifdef RTE_LIBRTE_BBDEV_DEBUG\n+RTE_LOG_REGISTER(fpga_5gnr_fec_logtype, pmd.bb.fpga_5gnr_fec, DEBUG);\n+#else\n+RTE_LOG_REGISTER(fpga_5gnr_fec_logtype, pmd.bb.fpga_5gnr_fec, NOTICE);\n+#endif\n \n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \n@@ -2175,13 +2178,3 @@ RTE_PMD_REGISTER_PCI(FPGA_5GNR_FEC_VF_DRIVER_NAME, fpga_5gnr_fec_pci_vf_driver);\n RTE_PMD_REGISTER_PCI_TABLE(FPGA_5GNR_FEC_VF_DRIVER_NAME,\n \t\tpci_id_fpga_5gnr_fec_vf_map);\n \n-RTE_INIT(fpga_5gnr_fec_init_log)\n-{\n-\tfpga_5gnr_fec_logtype = rte_log_register(\"pmd.bb.fpga_5gnr_fec\");\n-\tif (fpga_5gnr_fec_logtype >= 0)\n-#ifdef RTE_LIBRTE_BBDEV_DEBUG\n-\t\trte_log_set_level(fpga_5gnr_fec_logtype, RTE_LOG_DEBUG);\n-#else\n-\t\trte_log_set_level(fpga_5gnr_fec_logtype, RTE_LOG_NOTICE);\n-#endif\n-}\ndiff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\nindex abc5a1bf6..6be9131e7 100644\n--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\n+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\n@@ -22,8 +22,11 @@\n \n #include \"fpga_lte_fec.h\"\n \n-/* Turbo SW PMD logging ID */\n-static int fpga_lte_fec_logtype;\n+#ifdef RTE_LIBRTE_BBDEV_DEBUG\n+RTE_LOG_REGISTER(fpga_lte_fec_logtype, pmd.bb.fpga_lte_fec, DEBUG);\n+#else\n+RTE_LOG_REGISTER(fpga_lte_fec_logtype, pmd.bb.fpga_lte_fec, NOTICE);\n+#endif\n \n /* Helper macro for logging */\n #define rte_bbdev_log(level, fmt, ...) \\\n@@ -2662,14 +2665,3 @@ RTE_PMD_REGISTER_PCI_TABLE(FPGA_LTE_FEC_PF_DRIVER_NAME,\n RTE_PMD_REGISTER_PCI(FPGA_LTE_FEC_VF_DRIVER_NAME, fpga_lte_fec_pci_vf_driver);\n RTE_PMD_REGISTER_PCI_TABLE(FPGA_LTE_FEC_VF_DRIVER_NAME,\n \t\tpci_id_fpga_lte_fec_vf_map);\n-\n-RTE_INIT(fpga_lte_fec_init_log)\n-{\n-\tfpga_lte_fec_logtype = rte_log_register(\"pmd.bb.fpga_lte_fec\");\n-\tif (fpga_lte_fec_logtype >= 0)\n-#ifdef RTE_LIBRTE_BBDEV_DEBUG\n-\t\trte_log_set_level(fpga_lte_fec_logtype, RTE_LOG_DEBUG);\n-#else\n-\t\trte_log_set_level(fpga_lte_fec_logtype, RTE_LOG_NOTICE);\n-#endif\n-}\ndiff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c\nindex 2f2515101..dd11cd31c 100644\n--- a/drivers/baseband/null/bbdev_null.c\n+++ b/drivers/baseband/null/bbdev_null.c\n@@ -15,8 +15,7 @@\n \n #define DRIVER_NAME baseband_null\n \n-/* NULL BBDev logging ID */\n-static int bbdev_null_logtype;\n+RTE_LOG_REGISTER(bbdev_null_logtype, pmd.bb.null, NOTICE);\n \n /* Helper macro for logging */\n #define rte_bbdev_log(level, fmt, ...) \\\n@@ -348,9 +347,3 @@ RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,\n \tBBDEV_NULL_SOCKET_ID_ARG\"=<int>\");\n RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_null);\n \n-RTE_INIT(null_bbdev_init_log)\n-{\n-\tbbdev_null_logtype = rte_log_register(\"pmd.bb.null\");\n-\tif (bbdev_null_logtype >= 0)\n-\t\trte_log_set_level(bbdev_null_logtype, RTE_LOG_NOTICE);\n-}\ndiff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\nindex bb62276b9..daecfd21a 100644\n--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n@@ -34,8 +34,7 @@\n \n #define DRIVER_NAME baseband_turbo_sw\n \n-/* Turbo SW PMD logging ID */\n-static int bbdev_turbo_sw_logtype;\n+RTE_LOG_REGISTER(bbdev_turbo_sw_logtype, pmd.bb.turbo_sw, NOTICE);\n \n /* Helper macro for logging */\n #define rte_bbdev_log(level, fmt, ...) \\\n@@ -1991,9 +1990,3 @@ RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,\n \tTURBO_SW_SOCKET_ID_ARG\"=<int>\");\n RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, turbo_sw);\n \n-RTE_INIT(turbo_sw_bbdev_init_log)\n-{\n-\tbbdev_turbo_sw_logtype = rte_log_register(\"pmd.bb.turbo_sw\");\n-\tif (bbdev_turbo_sw_logtype >= 0)\n-\t\trte_log_set_level(bbdev_turbo_sw_logtype, RTE_LOG_NOTICE);\n-}\n", "prefixes": [ "v3", "12/13" ] }