Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72520/?format=api
{ "id": 72520, "url": "http://patches.dpdk.org/api/patches/72520/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-11-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701064828.4097247-11-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701064828.4097247-11-jerinj@marvell.com", "date": "2020-07-01T06:48:25", "name": "[v3,10/13] drivers/common: use log register macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "83dae4c19bdf48e70e68182ed90bae95f9882cef", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-11-jerinj@marvell.com/mbox/", "series": [ { "id": 10702, "url": "http://patches.dpdk.org/api/series/10702/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10702", "date": "2020-07-01T06:48:15", "name": "rte_log registration usage improvement", "version": 3, "mbox": "http://patches.dpdk.org/series/10702/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/72520/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/72520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC622A0350;\n\tWed, 1 Jul 2020 08:50:31 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DC8491C0DA;\n\tWed, 1 Jul 2020 08:49:52 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 44A281C0D0\n for <dev@dpdk.org>; Wed, 1 Jul 2020 08:49:51 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0616eN1s000791; Tue, 30 Jun 2020 23:49:50 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 31x5mnq881-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 30 Jun 2020 23:49:50 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 30 Jun 2020 23:49:48 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 30 Jun 2020 23:49:48 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 3454A3F703F;\n Tue, 30 Jun 2020 23:49:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=03Ks3uN8Tn9pDg4ZLBxJteFSp3aqXvXtBNi0dyL0V00=;\n b=euCmXhUZlCCG9dXxnXXvfw6my7qCHgls5cI5mCXzoxUYIMA1KtM3udKWtUV2IWKtKfwB\n 5Ljjoo7pqlOOGcYAW9sLu5YHvfSXqhTsH01UdizB6Tb1kszdA6q+3VfHCwtdCv0inHi0\n QNSj2vpfmAsUNXck3Ri38l4poaZYNAt5BIqUsZcfqd5TnBogr/Ng/0gDw7loILgy/Ph3\n ZQu5n+XAlHtMSy6jo3YQqNy8WyLCGyn99xjcczLyU46bgB25omdnNo0K2V1UGmH3k65n\n wohk/lVdG2k0kZQiQHs2oUnCaJbYUY1qCaBKfqC0NR9zLJlf9vE2CoB1nQC4ZKGPOtPG 2w==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena\n <sachin.saxena@nxp.com>, Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing\n <beilei.xing@intel.com>, Harman Kalra <hkalra@marvell.com>, Jerin Jacob\n <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"John\n Griffin\" <john.griffin@intel.com>, Fiona Trahe <fiona.trahe@intel.com>,\n \"Deepak Kumar Jain\" <deepak.k.jain@intel.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, <sachin.saxena@oss.nxp.com>,\n <adamx.dybkowski@intel.com>", "Date": "Wed, 1 Jul 2020 12:18:25 +0530", "Message-ID": "<20200701064828.4097247-11-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701064828.4097247-1-jerinj@marvell.com>", "References": "<20200701035840.4028056-1-jerinj@marvell.com>\n <20200701064828.4097247-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-07-01_03:2020-07-01,\n 2020-07-01 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 10/13] drivers/common: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n drivers/common/dpaax/dpaax_iova_table.c | 10 +--\n drivers/common/iavf/iavf_impl.c | 9 +--\n drivers/common/octeontx/octeontx_mbox.c | 9 +--\n drivers/common/octeontx2/otx2_common.c | 96 +++----------------------\n drivers/common/qat/qat_logs.c | 17 +----\n 5 files changed, 15 insertions(+), 126 deletions(-)", "diff": "diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c\nindex 98b076e09..5ba8ed193 100644\n--- a/drivers/common/dpaax/dpaax_iova_table.c\n+++ b/drivers/common/dpaax/dpaax_iova_table.c\n@@ -7,9 +7,6 @@\n #include \"dpaax_iova_table.h\"\n #include \"dpaax_logs.h\"\n \n-/* Global dpaax logger identifier */\n-int dpaax_logger;\n-\n /* Global table reference */\n struct dpaax_iova_table *dpaax_iova_table_p;\n \n@@ -463,9 +460,4 @@ dpaax_handle_memevents(void)\n \t\t\t\t\t dpaax_memevent_cb, NULL);\n }\n \n-RTE_INIT(dpaax_log)\n-{\n-\tdpaax_logger = rte_log_register(\"pmd.common.dpaax\");\n-\tif (dpaax_logger >= 0)\n-\t\trte_log_set_level(dpaax_logger, RTE_LOG_ERR);\n-}\n+RTE_LOG_REGISTER(dpaax_logger, pmd.common.dpaax, ERR);\ndiff --git a/drivers/common/iavf/iavf_impl.c b/drivers/common/iavf/iavf_impl.c\nindex 6174a9144..fc0da3175 100644\n--- a/drivers/common/iavf/iavf_impl.c\n+++ b/drivers/common/iavf/iavf_impl.c\n@@ -13,8 +13,6 @@\n #include \"iavf_type.h\"\n #include \"iavf_prototype.h\"\n \n-int iavf_common_logger;\n-\n enum iavf_status\n iavf_allocate_dma_mem_d(__rte_unused struct iavf_hw *hw,\n \t\t\tstruct iavf_dma_mem *mem,\n@@ -87,9 +85,4 @@ iavf_free_virt_mem_d(__rte_unused struct iavf_hw *hw,\n \treturn IAVF_SUCCESS;\n }\n \n-RTE_INIT(iavf_common_init_log)\n-{\n-\tiavf_common_logger = rte_log_register(\"pmd.common.iavf\");\n-\tif (iavf_common_logger >= 0)\n-\t\trte_log_set_level(iavf_common_logger, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(iavf_common_logger, pmd.common.iavf, NOTICE);\ndiff --git a/drivers/common/octeontx/octeontx_mbox.c b/drivers/common/octeontx/octeontx_mbox.c\nindex effe0b267..f414267e4 100644\n--- a/drivers/common/octeontx/octeontx_mbox.c\n+++ b/drivers/common/octeontx/octeontx_mbox.c\n@@ -68,14 +68,7 @@ struct mbox_intf_ver {\n \tuint32_t minor:10;\n };\n \n-int octeontx_logtype_mbox;\n-\n-RTE_INIT(otx_init_log)\n-{\n-\tocteontx_logtype_mbox = rte_log_register(\"pmd.octeontx.mbox\");\n-\tif (octeontx_logtype_mbox >= 0)\n-\t\trte_log_set_level(octeontx_logtype_mbox, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(octeontx_logtype_mbox, pmd.octeontx.mbox, NOTICE);\n \n static inline void\n mbox_msgcpy(volatile uint8_t *d, volatile const uint8_t *s, uint16_t size)\ndiff --git a/drivers/common/octeontx2/otx2_common.c b/drivers/common/octeontx2/otx2_common.c\nindex 5e7272f69..b292e999a 100644\n--- a/drivers/common/octeontx2/otx2_common.c\n+++ b/drivers/common/octeontx2/otx2_common.c\n@@ -203,89 +203,13 @@ void otx2_parse_common_devargs(struct rte_kvargs *kvlist)\n \tidev->npa_lock_mask = npa_lock_mask;\n }\n \n-/**\n- * @internal\n- */\n-int otx2_logtype_base;\n-/**\n- * @internal\n- */\n-int otx2_logtype_mbox;\n-/**\n- * @internal\n- */\n-int otx2_logtype_npa;\n-/**\n- * @internal\n- */\n-int otx2_logtype_nix;\n-/**\n- * @internal\n- */\n-int otx2_logtype_npc;\n-/**\n- * @internal\n- */\n-int otx2_logtype_tm;\n-/**\n- * @internal\n- */\n-int otx2_logtype_sso;\n-/**\n- * @internal\n- */\n-int otx2_logtype_tim;\n-/**\n- * @internal\n- */\n-int otx2_logtype_dpi;\n-/**\n- * @internal\n- */\n-int otx2_logtype_ep;\n-\n-RTE_INIT(otx2_log_init);\n-static void\n-otx2_log_init(void)\n-{\n-\totx2_logtype_base = rte_log_register(\"pmd.octeontx2.base\");\n-\tif (otx2_logtype_base >= 0)\n-\t\trte_log_set_level(otx2_logtype_base, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_mbox = rte_log_register(\"pmd.octeontx2.mbox\");\n-\tif (otx2_logtype_mbox >= 0)\n-\t\trte_log_set_level(otx2_logtype_mbox, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_npa = rte_log_register(\"pmd.mempool.octeontx2\");\n-\tif (otx2_logtype_npa >= 0)\n-\t\trte_log_set_level(otx2_logtype_npa, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_nix = rte_log_register(\"pmd.net.octeontx2\");\n-\tif (otx2_logtype_nix >= 0)\n-\t\trte_log_set_level(otx2_logtype_nix, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_npc = rte_log_register(\"pmd.net.octeontx2.flow\");\n-\tif (otx2_logtype_npc >= 0)\n-\t\trte_log_set_level(otx2_logtype_npc, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_tm = rte_log_register(\"pmd.net.octeontx2.tm\");\n-\tif (otx2_logtype_tm >= 0)\n-\t\trte_log_set_level(otx2_logtype_tm, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_sso = rte_log_register(\"pmd.event.octeontx2\");\n-\tif (otx2_logtype_sso >= 0)\n-\t\trte_log_set_level(otx2_logtype_sso, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_tim = rte_log_register(\"pmd.event.octeontx2.timer\");\n-\tif (otx2_logtype_tim >= 0)\n-\t\trte_log_set_level(otx2_logtype_tim, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_dpi = rte_log_register(\"pmd.raw.octeontx2.dpi\");\n-\tif (otx2_logtype_dpi >= 0)\n-\t\trte_log_set_level(otx2_logtype_dpi, RTE_LOG_NOTICE);\n-\n-\totx2_logtype_ep = rte_log_register(\"pmd.raw.octeontx2.ep\");\n-\tif (otx2_logtype_ep >= 0)\n-\t\trte_log_set_level(otx2_logtype_ep, RTE_LOG_NOTICE);\n-\n-}\n+RTE_LOG_REGISTER(otx2_logtype_base, pmd.octeontx2.base, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_mbox, pmd.octeontx2.mbox, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_npa, pmd.mempool.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_nix, pmd.net.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_npc, pmd.net.octeontx2.flow, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_tm, pmd.net.octeontx2.tm, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_sso, pmd.event.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_tim, pmd.event.octeontx2.timer, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_dpi, pmd.raw.octeontx2.dpi, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_ep, pmd.raw.octeontx2.ep, NOTICE);\ndiff --git a/drivers/common/qat/qat_logs.c b/drivers/common/qat/qat_logs.c\nindex dfd0cbe5d..fa48be53c 100644\n--- a/drivers/common/qat/qat_logs.c\n+++ b/drivers/common/qat/qat_logs.c\n@@ -7,9 +7,6 @@\n \n #include \"qat_logs.h\"\n \n-int qat_gen_logtype;\n-int qat_dp_logtype;\n-\n int\n qat_hexdump_log(uint32_t level, uint32_t logtype, const char *title,\n \t\tconst void *buf, unsigned int len)\n@@ -20,15 +17,5 @@ qat_hexdump_log(uint32_t level, uint32_t logtype, const char *title,\n \treturn 0;\n }\n \n-RTE_INIT(qat_pci_init_log)\n-{\n-\t/* Non-data-path logging for pci device and all services */\n-\tqat_gen_logtype = rte_log_register(\"pmd.qat_general\");\n-\tif (qat_gen_logtype >= 0)\n-\t\trte_log_set_level(qat_gen_logtype, RTE_LOG_NOTICE);\n-\n-\t/* data-path logging for all services */\n-\tqat_dp_logtype = rte_log_register(\"pmd.qat_dp\");\n-\tif (qat_dp_logtype >= 0)\n-\t\trte_log_set_level(qat_dp_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(qat_gen_logtype, pmd.qat_general, NOTICE);\n+RTE_LOG_REGISTER(qat_dp_logtype, pmd.qat_dp, NOTICE);\n", "prefixes": [ "v3", "10/13" ] }