Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72513/?format=api
{ "id": 72513, "url": "http://patches.dpdk.org/api/patches/72513/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-4-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200701064828.4097247-4-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200701064828.4097247-4-jerinj@marvell.com", "date": "2020-07-01T06:48:18", "name": "[v3,03/13] drivers/vdpa: use log register macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7e2929d6da3eabe8a506cdc95eb1a3a81240ec76", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200701064828.4097247-4-jerinj@marvell.com/mbox/", "series": [ { "id": 10702, "url": "http://patches.dpdk.org/api/series/10702/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10702", "date": "2020-07-01T06:48:15", "name": "rte_log registration usage improvement", "version": 3, "mbox": "http://patches.dpdk.org/series/10702/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/72513/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/72513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1661FA0350;\n\tWed, 1 Jul 2020 08:49:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1E5CE1C044;\n\tWed, 1 Jul 2020 08:48:59 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7AFFC1C00E\n for <dev@dpdk.org>; Wed, 1 Jul 2020 08:48:55 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0616eNi3000789; Tue, 30 Jun 2020 23:48:54 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0b-0016f401.pphosted.com with ESMTP id 31x5mnq846-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 30 Jun 2020 23:48:54 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 30 Jun 2020 23:48:53 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 30 Jun 2020 23:48:53 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 270243F703F;\n Tue, 30 Jun 2020 23:48:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=lvlDxc5T5D1JOR5qEvSwSi61topliF2i07NYI4Hv/Mw=;\n b=LApOr2s6NtI/1AZD2Yc2Ijpa/pXgQRz8TVBBvDMSnMZ/udGMwbbsOEcXSPIEfmzZQqDC\n SEM80nrk6n7kCv0cPHbg6kPx0PWH7otM960L/V3MnzgyhY4h02NSlKX0DmXeeRNDMA1s\n 48xTLeYAZC1vGwGfMaWUB3ugbF5AXv7urv1vyLb+zVovofXEXCCPQ65Y0tkj9MvfOQHq\n dVR0u7RvsynPT9hfldP0/GeIt/6rRz1dkS/7mO+5ZjANPqxDYlcCpQwVSUuJ4lbK8ERF\n Atq85HootTYPJ1hmmXwQ+O8ev273+majcgFh6g22jwSWl1ZFHoxjmgalF+aOhFrh9XcT QA==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Xiao Wang <xiao.w.wang@intel.com>, Matan Azrad\n <matan@mellanox.com>, Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, <sachin.saxena@oss.nxp.com>,\n <adamx.dybkowski@intel.com>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 1 Jul 2020 12:18:18 +0530", "Message-ID": "<20200701064828.4097247-4-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701064828.4097247-1-jerinj@marvell.com>", "References": "<20200701035840.4028056-1-jerinj@marvell.com>\n <20200701064828.4097247-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-07-01_03:2020-07-01,\n 2020-07-01 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 03/13] drivers/vdpa: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 10 +---------\n drivers/vdpa/mlx5/mlx5_vdpa.c | 7 +++----\n 2 files changed, 4 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex ec97178dc..78299fa67 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -24,6 +24,7 @@\n \n #include \"base/ifcvf.h\"\n \n+RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE);\n #define DRV_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \\\n \t\t\"IFCVF %s(): \" fmt \"\\n\", __func__, ##args)\n@@ -44,8 +45,6 @@ static const char * const ifcvf_valid_arguments[] = {\n \tNULL\n };\n \n-static int ifcvf_vdpa_logtype;\n-\n struct ifcvf_internal {\n \tstruct rte_vdpa_dev_addr dev_addr;\n \tstruct rte_pci_device *pdev;\n@@ -1271,10 +1270,3 @@ static struct rte_pci_driver rte_ifcvf_vdpa = {\n RTE_PMD_REGISTER_PCI(net_ifcvf, rte_ifcvf_vdpa);\n RTE_PMD_REGISTER_PCI_TABLE(net_ifcvf, pci_id_ifcvf_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_ifcvf, \"* vfio-pci\");\n-\n-RTE_INIT(ifcvf_vdpa_init_log)\n-{\n-\tifcvf_vdpa_logtype = rte_log_register(\"pmd.net.ifcvf_vdpa\");\n-\tif (ifcvf_vdpa_logtype >= 0)\n-\t\trte_log_set_level(ifcvf_vdpa_logtype, RTE_LOG_NOTICE);\n-}\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 1113d6cef..b166207c4 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -608,15 +608,14 @@ static struct rte_pci_driver mlx5_vdpa_driver = {\n \t.drv_flags = 0,\n };\n \n+\n+RTE_LOG_REGISTER(mlx5_vdpa_logtype, pmd.vdpa.mlx5, NOTICE);\n+\n /**\n * Driver initialization routine.\n */\n RTE_INIT(rte_mlx5_vdpa_init)\n {\n-\t/* Initialize common log type. */\n-\tmlx5_vdpa_logtype = rte_log_register(\"pmd.vdpa.mlx5\");\n-\tif (mlx5_vdpa_logtype >= 0)\n-\t\trte_log_set_level(mlx5_vdpa_logtype, RTE_LOG_NOTICE);\n \tif (mlx5_glue)\n \t\trte_pci_register(&mlx5_vdpa_driver);\n }\n", "prefixes": [ "v3", "03/13" ] }