Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72254/?format=api
{ "id": 72254, "url": "http://patches.dpdk.org/api/patches/72254/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200626140441.1441763-9-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200626140441.1441763-9-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200626140441.1441763-9-maxime.coquelin@redhat.com", "date": "2020-06-26T14:04:35", "name": "[v3,08/14] vhost: remove useless vDPA API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cc613716db6d5d3caca0ae1fd6a4cec055c1c201", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200626140441.1441763-9-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 10634, "url": "http://patches.dpdk.org/api/series/10634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10634", "date": "2020-06-26T14:04:28", "name": "vDPA API and framework rework", "version": 3, "mbox": "http://patches.dpdk.org/series/10634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/72254/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/72254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A908BA051C;\n\tFri, 26 Jun 2020 16:06:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 28D7A1C042;\n\tFri, 26 Jun 2020 16:05:52 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 812591BFC8\n for <dev@dpdk.org>; Fri, 26 Jun 2020 16:05:50 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-14-eIgOwVdINgmZsfya9ZTjXg-1; Fri, 26 Jun 2020 10:05:48 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89F90107ACCA;\n Fri, 26 Jun 2020 14:05:46 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.7])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 05F3B8476F;\n Fri, 26 Jun 2020 14:05:36 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1593180350;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=q1XSETQVDQnGniiRePqT4QGY/XDWt4QmYXIv+adPXPM=;\n b=eEsI5UV2CdH+4zBlG028B280tU7ojJN4SETJ9ryHxYMMansq8qDDi+N7VT+k1GYEGq+PjM\n ce5/OSDbFx+yfy3/db/7rIYJy5Ykm0ahp3cSoYWmhAKXX5vLOhO7nEqDgSBwfBC8vDxyRa\n UeJ2dpuxi2GYJ+WKMKjILHS3mZPtoy0=", "X-MC-Unique": "eIgOwVdINgmZsfya9ZTjXg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "matan@mellanox.com, xiao.w.wang@intel.com, zhihong.wang@intel.com,\n chenbo.xia@intel.com, david.marchand@redhat.com, amorenoz@redhat.com,\n viacheslavo@mellanox.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com,\n grive@u256.net, dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 26 Jun 2020 16:04:35 +0200", "Message-Id": "<20200626140441.1441763-9-maxime.coquelin@redhat.com>", "In-Reply-To": "<20200626140441.1441763-1-maxime.coquelin@redhat.com>", "References": "<20200626140441.1441763-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 08/14] vhost: remove useless vDPA API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "vDPA is no more used outside of the vDPA internals,\nso remove rte_vdpa_get_device() API that is now useless.\n\nAcked-by: Adrián Moreno <amorenoz@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/rte_vdpa.h | 30 -----------------\n lib/librte_vhost/rte_vhost_version.map | 1 -\n lib/librte_vhost/vdpa.c | 46 ++++++--------------------\n 3 files changed, 10 insertions(+), 67 deletions(-)", "diff": "diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h\nindex 549b0a2cb0..da8ee33ab1 100644\n--- a/lib/librte_vhost/rte_vdpa.h\n+++ b/lib/librte_vhost/rte_vdpa.h\n@@ -174,36 +174,6 @@ __rte_experimental\n struct rte_device *\n rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);\n \n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n- * Find the device id of a vdpa device\n- *\n- * @param addr\n- * the vdpa device address\n- * @return\n- * device id on success, -1 on failure\n- */\n-__rte_experimental\n-int\n-rte_vdpa_find_device_id(struct rte_vdpa_device *dev);\n-\n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n- * Find a vdpa device based on device id\n- *\n- * @param did\n- * device id\n- * @return\n- * rte_vdpa_device on success, NULL on failure\n- */\n-__rte_experimental\n-struct rte_vdpa_device *\n-rte_vdpa_get_device(int did);\n-\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice\ndiff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map\nindex ba55f6f421..d9124d0462 100644\n--- a/lib/librte_vhost/rte_vhost_version.map\n+++ b/lib/librte_vhost/rte_vhost_version.map\n@@ -36,7 +36,6 @@ EXPERIMENTAL {\n \trte_vdpa_register_device;\n \trte_vdpa_unregister_device;\n \trte_vdpa_find_device_id;\n-\trte_vdpa_get_device;\n \trte_vdpa_get_device_num;\n \trte_vdpa_get_stats_names;\n \trte_vdpa_get_stats;\ndiff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c\nindex cececc3098..bed20a3103 100644\n--- a/lib/librte_vhost/vdpa.c\n+++ b/lib/librte_vhost/vdpa.c\n@@ -19,27 +19,6 @@ static struct rte_vdpa_device vdpa_devices[MAX_VHOST_DEVICE];\n static uint32_t vdpa_device_num;\n \n \n-int\n-rte_vdpa_find_device_id(struct rte_vdpa_device *dev)\n-{\n-\tstruct rte_vdpa_device *tmp_dev;\n-\tint i;\n-\n-\tif (dev == NULL)\n-\t\treturn -1;\n-\n-\tfor (i = 0; i < MAX_VHOST_DEVICE; ++i) {\n-\t\ttmp_dev = &vdpa_devices[i];\n-\t\tif (tmp_dev->ops == NULL)\n-\t\t\tcontinue;\n-\n-\t\tif (tmp_dev == dev)\n-\t\t\treturn i;\n-\t}\n-\n-\treturn -1;\n-}\n-\n struct rte_vdpa_device *\n rte_vdpa_find_device_by_name(const char *name)\n {\n@@ -70,15 +49,6 @@ rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev)\n \treturn vdpa_dev->device;\n }\n \n-struct rte_vdpa_device *\n-rte_vdpa_get_device(int did)\n-{\n-\tif (did < 0 || did >= MAX_VHOST_DEVICE)\n-\t\treturn NULL;\n-\n-\treturn &vdpa_devices[did];\n-}\n-\n struct rte_vdpa_device *\n rte_vdpa_register_device(struct rte_device *rte_dev,\n \t\tstruct rte_vdpa_dev_ops *ops)\n@@ -117,15 +87,19 @@ rte_vdpa_register_device(struct rte_device *rte_dev,\n int\n rte_vdpa_unregister_device(struct rte_vdpa_device *vdev)\n {\n-\tint did = rte_vdpa_find_device_id(vdev);\n+\tint i;\n \n-\tif (did < 0 || vdpa_devices[did].ops == NULL)\n-\t\treturn -1;\n+\tfor (i = 0; i < MAX_VHOST_DEVICE; i++) {\n+\t\tif (vdev != &vdpa_devices[i])\n+\t\t\tcontinue;\n \n-\tmemset(&vdpa_devices[did], 0, sizeof(struct rte_vdpa_device));\n-\tvdpa_device_num--;\n+\t\tmemset(vdev, 0, sizeof(struct rte_vdpa_device));\n+\t\tvdpa_device_num--;\n \n-\treturn 0;\n+\t\treturn 0;\n+\t}\n+\n+\treturn -1;\n }\n \n int\n", "prefixes": [ "v3", "08/14" ] }