Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72104/?format=api
{ "id": 72104, "url": "http://patches.dpdk.org/api/patches/72104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200624082847.21344-8-talshn@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200624082847.21344-8-talshn@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200624082847.21344-8-talshn@mellanox.com", "date": "2020-06-24T08:28:44", "name": "[v9,07/10] drivers: fix incorrect meson import folder for Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "84913585bbdac4c9c43ec66a6fa8d2606163aa00", "submitter": { "id": 1669, "url": "http://patches.dpdk.org/api/people/1669/?format=api", "name": "Tal Shnaiderman", "email": "talshn@mellanox.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200624082847.21344-8-talshn@mellanox.com/mbox/", "series": [ { "id": 10579, "url": "http://patches.dpdk.org/api/series/10579/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10579", "date": "2020-06-24T08:28:37", "name": "Windows bus/pci support", "version": 9, "mbox": "http://patches.dpdk.org/series/10579/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/72104/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/72104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AF3FA0350;\n\tWed, 24 Jun 2020 12:19:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B44D51D450;\n\tWed, 24 Jun 2020 12:19:09 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id CEF2F1D450\n for <dev@dpdk.org>; Wed, 24 Jun 2020 12:19:07 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@mellanox.com) with SMTP; 24 Jun 2020 13:19:03 +0300", "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 05O8TGKN012156;\n Wed, 24 Jun 2020 11:29:18 +0300" ], "From": "talshn@mellanox.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,\n david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com,\n navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com,\n ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com,\n bruce.richardson@intel.com, Tal Shnaiderman <talshn@mellanox.com>", "Date": "Wed, 24 Jun 2020 11:28:44 +0300", "Message-Id": "<20200624082847.21344-8-talshn@mellanox.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20200624082847.21344-1-talshn@mellanox.com>", "References": "<20200622075529.24180-2-talshn@mellanox.com>\n <20200624082847.21344-1-talshn@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v9 07/10] drivers: fix incorrect meson import\n\tfolder for Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tal Shnaiderman <talshn@mellanox.com>\n\nimport library (/IMPLIB) in meson.build should use\nthe 'drivers' and not 'libs' folder.\n\nThe error is: fatal error LNK1149: output filename matches input filename.\nThe fix uses the correct folder.\n\nFixes: 5ed3766981 (\"drivers: process shared link dependencies as for libs\")\n\nSigned-off-by: Tal Shnaiderman <talshn@mellanox.com>\n---\n drivers/meson.build | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex f4b6cbf3a6..dea0ba2cca 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -153,7 +153,7 @@ foreach class:dpdk_driver_classes\n \t\t\tversion_map = '@0@/@1@/@2@_version.map'.format(\n \t\t\t\t\tmeson.current_source_dir(),\n \t\t\t\t\tdrv_path, lib_name)\n-\t\t\timplib = dir_name + '.dll.a'\n+\t\t\timplib = 'lib' + lib_name + '.dll.a'\n \n \t\t\tdef_file = custom_target(lib_name + '_def',\n \t\t\t\tcommand: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'],\n@@ -161,8 +161,12 @@ foreach class:dpdk_driver_classes\n \t\t\t\toutput: '@0@_exports.def'.format(lib_name))\n \t\t\tlk_deps = [version_map, def_file]\n \t\t\tif is_windows\n-\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n-\t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n+\t\t\t\tif is_ms_linker\n+\t\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n+\t\t\t\t\t\t'-Wl,/implib:drivers\\\\' + implib]\n+\t\t\t\telse\n+\t\t\t\t\tlk_args = []\n+\t\t\t\tendif\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n \t\t\t\t# on unix systems check the output of the\n", "prefixes": [ "v9", "07/10" ] }