Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71653/?format=api
{ "id": 71653, "url": "http://patches.dpdk.org/api/patches/71653/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200617063047.1555518-5-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200617063047.1555518-5-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200617063047.1555518-5-jerinj@marvell.com", "date": "2020-06-17T06:30:38", "name": "[04/13] drivers/raw: use log register macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a01bae1999c0aa1c99a24fc07e82231804f62128", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200617063047.1555518-5-jerinj@marvell.com/mbox/", "series": [ { "id": 10476, "url": "http://patches.dpdk.org/api/series/10476/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10476", "date": "2020-06-17T06:30:34", "name": "rte_log registration usage improvement", "version": 1, "mbox": "http://patches.dpdk.org/series/10476/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71653/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/71653/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4769A04A5;\n\tWed, 17 Jun 2020 08:30:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 43CF31BEDD;\n\tWed, 17 Jun 2020 08:30:40 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8CC541B6B4\n for <dev@dpdk.org>; Wed, 17 Jun 2020 08:30:38 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 05H6Q4pj010591; Tue, 16 Jun 2020 23:30:37 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 31q658jmty-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 16 Jun 2020 23:30:37 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 16 Jun 2020 23:30:36 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 16 Jun 2020 23:30:36 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 8E3733F703F;\n Tue, 16 Jun 2020 23:30:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=8sIlrEPiXCY2bf7XzOPbmILmwFDha52BOI2oNr1OiEE=;\n b=Jmj/J5YzBjwKOuCTmNsWxmRVSyuiGQRq+3NpB1Rxe1HJWGwmlgnpwp7p5M+2w9RSUn2q\n 2J8IT7D1sKR2A24z3AuQ6D8LgPF9PnKsu+2qd5kqLbuibtEt6jiZaPIetqB6nNPmR+NV\n j3WcO/s0HzxqcJUXzisV73i2Bfg5tYecQ/aKAPrWmpQbA3ntv/beRPgGtI8XLk+OBgY5\n BjLIi98CgrjJlty33IMdqJbLxYvx0nhRxUzXnnNbDTMq5O0z+yaBySdubX0YUnyp96ol\n UU8WNdNtYU7UWP7wMZ43xftF9TsFltIkH+PESoj+6y8I+cB0Zgxwx3qUWkw192zytAG5 2g==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Nipun Gupta <nipun.gupta@nxp.com>, Rosen Xu\n <rosen.xu@intel.com>, Tianfei zhang <tianfei.zhang@intel.com>, \"Bruce\n Richardson\" <bruce.richardson@intel.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 17 Jun 2020 12:00:38 +0530", "Message-ID": "<20200617063047.1555518-5-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200617063047.1555518-1-jerinj@marvell.com>", "References": "<20200617063047.1555518-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687\n definitions=2020-06-16_13:2020-06-16,\n 2020-06-16 signatures=0", "Subject": "[dpdk-dev] [PATCH 04/13] drivers/raw: use log register macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nUse log register macro to avoid the code duplication\nin the log registration process.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 11 +----------\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 11 +----------\n drivers/raw/ifpga/ifpga_rawdev.c | 10 +---------\n drivers/raw/ioat/ioat_rawdev.c | 12 ++----------\n drivers/raw/ioat/rte_ioat_rawdev.h | 2 --\n drivers/raw/ntb/ntb.c | 10 +---------\n drivers/raw/skeleton/skeleton_rawdev.c | 11 +----------\n 7 files changed, 7 insertions(+), 60 deletions(-)", "diff": "diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\nindex 7c21c6a52..c7bddbc6c 100644\n--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n@@ -20,9 +20,6 @@\n #include \"dpaa2_cmdif_logs.h\"\n #include \"rte_pmd_dpaa2_cmdif.h\"\n \n-/* Dynamic log type identifier */\n-int dpaa2_cmdif_logtype;\n-\n /* CMDIF driver name */\n #define DPAA2_CMDIF_PMD_NAME dpaa2_dpci\n \n@@ -291,10 +288,4 @@ static struct rte_vdev_driver dpaa2_cmdif_drv = {\n };\n \n RTE_PMD_REGISTER_VDEV(DPAA2_CMDIF_PMD_NAME, dpaa2_cmdif_drv);\n-\n-RTE_INIT(dpaa2_cmdif_init_log)\n-{\n-\tdpaa2_cmdif_logtype = rte_log_register(\"pmd.raw.dpaa2.cmdif\");\n-\tif (dpaa2_cmdif_logtype >= 0)\n-\t\trte_log_set_level(dpaa2_cmdif_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(dpaa2_cmdif_logtype, pmd.raw.dpaa2.cmdif, INFO);\ndiff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\nindex 1be1b6ddf..0b9c4e3d7 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n@@ -26,9 +26,6 @@\n \n #define DPAA2_QDMA_NO_PREFETCH \"no_prefetch\"\n \n-/* Dynamic log type identifier */\n-int dpaa2_qdma_logtype;\n-\n uint32_t dpaa2_coherent_no_alloc_cache;\n uint32_t dpaa2_coherent_alloc_cache;\n \n@@ -1495,10 +1492,4 @@ static struct rte_dpaa2_driver rte_dpaa2_qdma_pmd = {\n RTE_PMD_REGISTER_DPAA2(dpaa2_qdma, rte_dpaa2_qdma_pmd);\n RTE_PMD_REGISTER_PARAM_STRING(dpaa2_qdma,\n \t\"no_prefetch=<int> \");\n-\n-RTE_INIT(dpaa2_qdma_init_log)\n-{\n-\tdpaa2_qdma_logtype = rte_log_register(\"pmd.raw.dpaa2.qdma\");\n-\tif (dpaa2_qdma_logtype >= 0)\n-\t\trte_log_set_level(dpaa2_qdma_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(dpaa2_qdma_logtype, pmd.raw.dpaa2.qdma, INFO);\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex b8701e155..cc25c662b 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -47,8 +47,6 @@\n #define RTE_PCI_EXT_CAP_ID(header) (int)(header & 0x0000ffff)\n #define RTE_PCI_EXT_CAP_NEXT(header) ((header >> 20) & 0xffc)\n \n-int ifpga_rawdev_logtype;\n-\n #define PCI_VENDOR_ID_INTEL 0x8086\n /* PCI Device ID */\n #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD\n@@ -1597,13 +1595,7 @@ static struct rte_pci_driver rte_ifpga_rawdev_pmd = {\n RTE_PMD_REGISTER_PCI(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, \"* igb_uio | uio_pci_generic | vfio-pci\");\n-\n-RTE_INIT(ifpga_rawdev_init_log)\n-{\n-\tifpga_rawdev_logtype = rte_log_register(\"driver.raw.init\");\n-\tif (ifpga_rawdev_logtype >= 0)\n-\t\trte_log_set_level(ifpga_rawdev_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(ifpga_rawdev_logtype, driver.raw.init, NOTICE);\n \n static const char * const valid_args[] = {\n #define IFPGA_ARG_NAME \"ifpga\"\ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex a8a48f90a..30d9f597e 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -9,9 +9,6 @@\n \n #include \"rte_ioat_rawdev.h\"\n \n-/* Dynamic log type identifier */\n-int ioat_pmd_logtype;\n-\n static struct rte_pci_driver ioat_pmd_drv;\n \n #define IOAT_VENDOR_ID\t\t0x8086\n@@ -28,6 +25,8 @@ static struct rte_pci_driver ioat_pmd_drv;\n #define IOAT_DEVICE_ID_BDXF\t0x6f2F\n #define IOAT_DEVICE_ID_ICX\t0x0b00\n \n+RTE_LOG_REGISTER(ioat_pmd_logtype, rawdev.ioat, INFO);\n+\n #define IOAT_PMD_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \\\n \tioat_pmd_logtype, \"%s(): \" fmt \"\\n\", __func__, ##args)\n \n@@ -386,10 +385,3 @@ static struct rte_pci_driver ioat_pmd_drv = {\n RTE_PMD_REGISTER_PCI(IOAT_PMD_RAWDEV_NAME, ioat_pmd_drv);\n RTE_PMD_REGISTER_PCI_TABLE(IOAT_PMD_RAWDEV_NAME, pci_id_ioat_map);\n RTE_PMD_REGISTER_KMOD_DEP(IOAT_PMD_RAWDEV_NAME, \"* igb_uio | uio_pci_generic\");\n-\n-RTE_INIT(ioat_pmd_init_log)\n-{\n-\tioat_pmd_logtype = rte_log_register(IOAT_PMD_LOG_NAME);\n-\tif (ioat_pmd_logtype >= 0)\n-\t\trte_log_set_level(ioat_pmd_logtype, RTE_LOG_INFO);\n-}\ndiff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h\nindex 4b271f174..f765a6557 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev.h\n@@ -25,8 +25,6 @@\n #define IOAT_PMD_RAWDEV_NAME rawdev_ioat\n /** String reported as the device driver name by rte_rawdev_info_get() */\n #define IOAT_PMD_RAWDEV_NAME_STR \"rawdev_ioat\"\n-/** Name used to adjust the log level for this driver */\n-#define IOAT_PMD_LOG_NAME \"rawdev.ioat\"\n \n /**\n * Configuration structure for an ioat rawdev instance\ndiff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex dd0b72f8c..e40412bb7 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -23,8 +23,6 @@\n #include \"rte_pmd_ntb.h\"\n #include \"ntb.h\"\n \n-int ntb_logtype;\n-\n static const struct rte_pci_id pci_id_ntb_map[] = {\n \t{ RTE_PCI_DEVICE(NTB_INTEL_VENDOR_ID, NTB_INTEL_DEV_ID_B2B_SKX) },\n \t{ .vendor_id = 0, /* sentinel */ },\n@@ -1504,10 +1502,4 @@ static struct rte_pci_driver rte_ntb_pmd = {\n RTE_PMD_REGISTER_PCI(raw_ntb, rte_ntb_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(raw_ntb, pci_id_ntb_map);\n RTE_PMD_REGISTER_KMOD_DEP(raw_ntb, \"* igb_uio | uio_pci_generic | vfio-pci\");\n-\n-RTE_INIT(ntb_init_log)\n-{\n-\tntb_logtype = rte_log_register(\"pmd.raw.ntb\");\n-\tif (ntb_logtype >= 0)\n-\t\trte_log_set_level(ntb_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(ntb_logtype, pmd.raw.ntb, INFO);\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 586183a5b..72ece887a 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -28,9 +28,6 @@\n \n #include \"skeleton_rawdev.h\"\n \n-/* Dynamic log type identifier */\n-int skeleton_pmd_logtype;\n-\n /* Count of instances */\n static uint16_t skeldev_init_once;\n \n@@ -759,10 +756,4 @@ static struct rte_vdev_driver skeleton_pmd_drv = {\n };\n \n RTE_PMD_REGISTER_VDEV(SKELETON_PMD_RAWDEV_NAME, skeleton_pmd_drv);\n-\n-RTE_INIT(skeleton_pmd_init_log)\n-{\n-\tskeleton_pmd_logtype = rte_log_register(\"rawdev.skeleton\");\n-\tif (skeleton_pmd_logtype >= 0)\n-\t\trte_log_set_level(skeleton_pmd_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(skeleton_pmd_logtype, rawdev.skeleton, INFO);\n", "prefixes": [ "04/13" ] }