Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 71456,
    "url": "http://patches.dpdk.org/api/patches/71456/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200612212434.6852-3-timothy.mcdaniel@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200612212434.6852-3-timothy.mcdaniel@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200612212434.6852-3-timothy.mcdaniel@intel.com",
    "date": "2020-06-12T21:24:09",
    "name": "[02/27] eventdev: do not pass disable_implicit_release bit to trace macro",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "95417c15367c37a62e1d067c8362ce93e516f416",
    "submitter": {
        "id": 826,
        "url": "http://patches.dpdk.org/api/people/826/?format=api",
        "name": "Timothy McDaniel",
        "email": "timothy.mcdaniel@intel.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200612212434.6852-3-timothy.mcdaniel@intel.com/mbox/",
    "series": [
        {
            "id": 10445,
            "url": "http://patches.dpdk.org/api/series/10445/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10445",
            "date": "2020-06-12T21:24:07",
            "name": "V1 event/dlb add Intel DLB PMD",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/10445/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/71456/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/71456/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8780EA00BE;\n\tFri, 12 Jun 2020 23:26:30 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 380A91BF31;\n\tFri, 12 Jun 2020 23:26:22 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id F1D621BED9\n for <dev@dpdk.org>; Fri, 12 Jun 2020 23:26:19 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jun 2020 14:26:19 -0700",
            "from txasoft-yocto.an.intel.com ([10.123.72.192])\n by orsmga003.jf.intel.com with ESMTP; 12 Jun 2020 14:26:18 -0700"
        ],
        "IronPort-SDR": [
            "\n xetu9DQjiHmgD14QV2eaM3J6EPuFSS9XuY/Fp1TqURPYQTr1dnxAJOPOjsFw902gpZ43FmmnMx\n McY62xTNPfnA==",
            "\n qjnrd32dLRqNtAPr+aKDR/7Qp9pPB5HCNvoh8GajSiMuuAPlIenIQKQv3n13EIJfNoulrXW83e\n XEEbcSFGjWHQ=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.73,504,1583222400\"; d=\"scan'208\";a=\"272035764\"",
        "From": "\"McDaniel, Timothy\" <timothy.mcdaniel@intel.com>",
        "To": "jerinj@marvell.com",
        "Cc": "dev@dpdk.org,\n\tgage.eads@intel.com,\n\tharry.van.haaren@intel.com",
        "Date": "Fri, 12 Jun 2020 16:24:09 -0500",
        "Message-Id": "<20200612212434.6852-3-timothy.mcdaniel@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20200612212434.6852-1-timothy.mcdaniel@intel.com>",
        "References": "<20200612212434.6852-1-timothy.mcdaniel@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 02/27] eventdev: do not pass\n\tdisable_implicit_release bit to trace macro",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The disable implicit_release indicator is now a bitfield, so it\n    must be converted to uint8_t when calling the tracepoint macro.\n\nChange-Id: Iab83bbc295de2431a936ce2a73ed6801366d392f\nSigned-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>\n---\n lib/librte_eventdev/rte_event_crypto_adapter.c |  7 ++++++-\n lib/librte_eventdev/rte_event_eth_tx_adapter.c | 14 ++++++++++++--\n lib/librte_eventdev/rte_eventdev.c             | 10 +++++++---\n lib/librte_eventdev/rte_eventdev_trace.h       | 15 +++++++++------\n 4 files changed, 34 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c\nindex 8f2593316..1b56f2eb4 100644\n--- a/lib/librte_eventdev/rte_event_crypto_adapter.c\n+++ b/lib/librte_eventdev/rte_event_crypto_adapter.c\n@@ -205,8 +205,10 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,\n \tstruct rte_event_crypto_adapter *adapter;\n \tchar mem_name[CRYPTO_ADAPTER_NAME_LEN];\n \tstruct rte_event_dev_info dev_info;\n+\tstruct rte_event_port_conf *port_conf = conf_arg;\n \tint socket_id;\n \tuint8_t i;\n+\tuint8_t disable_impl_rel;\n \tint ret;\n \n \tEVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);\n@@ -268,8 +270,11 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,\n \n \tevent_crypto_adapter[id] = adapter;\n \n+\tdisable_impl_rel = !!(port_conf->event_port_cfg &\n+\t\tRTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);\n+\n \trte_eventdev_trace_crypto_adapter_create(id, dev_id, adapter, conf_arg,\n-\t\tmode);\n+\t\tdisable_impl_rel, mode);\n \treturn 0;\n }\n \ndiff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c\nindex 8a72256de..e872f7c8c 100644\n--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c\n+++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c\n@@ -910,6 +910,7 @@ rte_event_eth_tx_adapter_create(uint8_t id, uint8_t dev_id,\n \t\t\t\tstruct rte_event_port_conf *port_conf)\n {\n \tstruct rte_eventdev *dev;\n+\tuint8_t disable_impl_rel;\n \tint ret;\n \n \tif (port_conf == NULL)\n@@ -943,8 +944,12 @@ rte_event_eth_tx_adapter_create(uint8_t id, uint8_t dev_id,\n \t\ttxa_dev_id_array[id] = TXA_INVALID_DEV_ID;\n \t\treturn ret;\n \t}\n+\n+\tdisable_impl_rel = !!(port_conf->event_port_cfg &\n+\t\tRTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);\n+\n \trte_eventdev_trace_eth_tx_adapter_create(id, dev_id, NULL, port_conf,\n-\t\tret);\n+\t\tdisable_impl_rel, ret);\n \ttxa_dev_id_array[id] = dev_id;\n \treturn 0;\n }\n@@ -955,6 +960,8 @@ rte_event_eth_tx_adapter_create_ext(uint8_t id, uint8_t dev_id,\n \t\t\t\tvoid *conf_arg)\n {\n \tstruct rte_eventdev *dev;\n+\tstruct rte_event_port_conf *port_conf = conf_arg;\n+\tuint8_t disable_impl_rel;\n \tint ret;\n \n \tRTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);\n@@ -986,8 +993,11 @@ rte_event_eth_tx_adapter_create_ext(uint8_t id, uint8_t dev_id,\n \t\treturn ret;\n \t}\n \n+\tdisable_impl_rel = !!(port_conf->event_port_cfg &\n+\t\tRTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);\n+\n \trte_eventdev_trace_eth_tx_adapter_create(id, dev_id, conf_cb, conf_arg,\n-\t\tret);\n+\t\tdisable_impl_rel, ret);\n \ttxa_dev_id_array[id] = dev_id;\n \treturn 0;\n }\ndiff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c\nindex 4955ab1a0..67c9c8357 100644\n--- a/lib/librte_eventdev/rte_eventdev.c\n+++ b/lib/librte_eventdev/rte_eventdev.c\n@@ -736,6 +736,7 @@ rte_event_port_setup(uint8_t dev_id, uint8_t port_id,\n {\n \tstruct rte_eventdev *dev;\n \tstruct rte_event_port_conf def_conf;\n+\tuint8_t disable_impl_rel;\n \tint diag;\n \n \tRTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n@@ -812,7 +813,12 @@ rte_event_port_setup(uint8_t dev_id, uint8_t port_id,\n \tif (!diag)\n \t\tdiag = rte_event_port_unlink(dev_id, port_id, NULL, 0);\n \n-\trte_eventdev_trace_port_setup(dev_id, port_id, port_conf, diag);\n+\tdisable_impl_rel = !!(port_conf->event_port_cfg &\n+\t\tRTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);\n+\n+\trte_eventdev_trace_port_setup(dev_id, port_id, port_conf,\n+\t\t\t\t      disable_impl_rel, diag);\n+\n \tif (diag < 0)\n \t\treturn diag;\n \n@@ -1422,10 +1428,8 @@ rte_event_pmd_allocate(const char *name, int socket_id)\n \t\teventdev->data = eventdev_data;\n \n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\n \t\t\tstrlcpy(eventdev->data->name, name,\n \t\t\t\tRTE_EVENTDEV_NAME_MAX_LEN);\n-\n \t\t\teventdev->data->dev_id = dev_id;\n \t\t\teventdev->data->socket_id = socket_id;\n \t\t\teventdev->data->dev_started = 0;\ndiff --git a/lib/librte_eventdev/rte_eventdev_trace.h b/lib/librte_eventdev/rte_eventdev_trace.h\nindex 4de6341ca..f56063976 100644\n--- a/lib/librte_eventdev/rte_eventdev_trace.h\n+++ b/lib/librte_eventdev/rte_eventdev_trace.h\n@@ -53,13 +53,14 @@ RTE_TRACE_POINT(\n RTE_TRACE_POINT(\n \trte_eventdev_trace_port_setup,\n \tRTE_TRACE_POINT_ARGS(uint8_t dev_id, uint8_t port_id,\n-\t\tconst struct rte_event_port_conf *port_conf, int rc),\n+\t\tconst struct rte_event_port_conf *port_conf,\n+\t\tuint8_t disable_impl_rel, int rc),\n \trte_trace_point_emit_u8(dev_id);\n \trte_trace_point_emit_u8(port_id);\n \trte_trace_point_emit_i32(port_conf->new_event_threshold);\n \trte_trace_point_emit_u16(port_conf->dequeue_depth);\n \trte_trace_point_emit_u16(port_conf->enqueue_depth);\n-\trte_trace_point_emit_u8(port_conf->disable_implicit_release);\n+\trte_trace_point_emit_u8(disable_impl_rel);\n \trte_trace_point_emit_int(rc);\n )\n \n@@ -159,13 +160,14 @@ RTE_TRACE_POINT(\n RTE_TRACE_POINT(\n \trte_eventdev_trace_eth_tx_adapter_create,\n \tRTE_TRACE_POINT_ARGS(uint8_t adptr_id, uint8_t dev_id, void *conf_cb,\n-\t\tstruct rte_event_port_conf *port_conf, int rc),\n+\t\tstruct rte_event_port_conf *port_conf, uint8_t disable_impl_rel,\n+\t\tint rc),\n \trte_trace_point_emit_u8(adptr_id);\n \trte_trace_point_emit_u8(dev_id);\n \trte_trace_point_emit_i32(port_conf->new_event_threshold);\n \trte_trace_point_emit_u16(port_conf->dequeue_depth);\n \trte_trace_point_emit_u16(port_conf->enqueue_depth);\n-\trte_trace_point_emit_u8(port_conf->disable_implicit_release);\n+\trte_trace_point_emit_u8(disable_impl_rel);\n \trte_trace_point_emit_ptr(conf_cb);\n \trte_trace_point_emit_int(rc);\n )\n@@ -249,7 +251,8 @@ RTE_TRACE_POINT(\n RTE_TRACE_POINT(\n \trte_eventdev_trace_crypto_adapter_create,\n \tRTE_TRACE_POINT_ARGS(uint8_t adptr_id, uint8_t dev_id, void *adapter,\n-\t\tstruct rte_event_port_conf *port_conf, uint8_t mode),\n+\t\tstruct rte_event_port_conf *port_conf, uint8_t disable_impl_rel,\n+\t\tuint8_t mode),\n \trte_trace_point_emit_u8(adptr_id);\n \trte_trace_point_emit_u8(dev_id);\n \trte_trace_point_emit_ptr(adapter);\n@@ -257,7 +260,7 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_i32(port_conf->new_event_threshold);\n \trte_trace_point_emit_u16(port_conf->dequeue_depth);\n \trte_trace_point_emit_u16(port_conf->enqueue_depth);\n-\trte_trace_point_emit_u8(port_conf->disable_implicit_release);\n+\trte_trace_point_emit_u8(disable_impl_rel);\n )\n \n RTE_TRACE_POINT(\n",
    "prefixes": [
        "02/27"
    ]
}