Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71402/?format=api
{ "id": 71402, "url": "http://patches.dpdk.org/api/patches/71402/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200612132934.16488-11-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200612132934.16488-11-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200612132934.16488-11-somnath.kotur@broadcom.com", "date": "2020-06-12T13:28:54", "name": "[10/50] net/bnxt: modify EM insert and delete to use HWRM direct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b380f3c5416367b34ca8bcdaa61e245f5142cbb", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200612132934.16488-11-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10436, "url": "http://patches.dpdk.org/api/series/10436/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10436", "date": "2020-06-12T13:28:44", "name": "add features for host-based flow management", "version": 1, "mbox": "http://patches.dpdk.org/series/10436/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71402/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/71402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC161A00BE;\n\tFri, 12 Jun 2020 15:38:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A4151BF98;\n\tFri, 12 Jun 2020 15:34:21 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n by dpdk.org (Postfix) with ESMTP id C2FB81BF7A\n for <dev@dpdk.org>; Fri, 12 Jun 2020 15:34:18 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 517BC1BD7A4;\n Fri, 12 Jun 2020 06:34:17 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 517BC1BD7A4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1591968858;\n bh=j6eGA/ehwkKbE1ZwifmPaBsxQ0rZU7TJ43I78cIspAQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=t0qoNrAAX6Puc0jZsteRLCvL0vz87kTTBSJfHQ+fqsqdKY8lPLpd6BZgLtWAZGAY9\n Bwh+ndRQIoNEreZErmJ6DlgPeQXmJ4tGYwJlRCBOTFYs6/DmFIkD1BYDhg0VGQda7t\n 6J+lJI8/vdeGaOrmcwSUDpQezjcov6jtHY7FfmBc=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Fri, 12 Jun 2020 18:58:54 +0530", "Message-Id": "<20200612132934.16488-11-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200612132934.16488-1-somnath.kotur@broadcom.com>", "References": "<20200612132934.16488-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 10/50] net/bnxt: modify EM insert and delete to\n\tuse HWRM direct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pete Spreadborough <peter.spreadborough@broadcom.com>\n\nModify Exact Match insert and delete to use the HWRM messages directly.\nRemove tunneled EM insert and delete message types.\n\nSigned-off-by: Pete Spreadborough <peter.spreadborough@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/tf_core/hwrm_tf.h | 70 +++-----------------------------------\n drivers/net/bnxt/tf_core/tf_msg.c | 66 ++++++++++++++++++++---------------\n 2 files changed, 43 insertions(+), 93 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/hwrm_tf.h b/drivers/net/bnxt/tf_core/hwrm_tf.h\nindex 439950e..d342c69 100644\n--- a/drivers/net/bnxt/tf_core/hwrm_tf.h\n+++ b/drivers/net/bnxt/tf_core/hwrm_tf.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2019-2020 Broadcom\n+ * Copyright(c) 2019 Broadcom\n * All rights reserved.\n */\n #ifndef _HWRM_TF_H_\n@@ -23,8 +23,6 @@ typedef enum tf_subtype {\n \tHWRM_TFT_SESSION_SRAM_RESC_FREE = 727,\n \tHWRM_TFT_SESSION_SRAM_RESC_FLUSH = 728,\n \tHWRM_TFT_TBL_SCOPE_CFG = 731,\n-\tHWRM_TFT_EM_RULE_INSERT = 739,\n-\tHWRM_TFT_EM_RULE_DELETE = 740,\n \tHWRM_TFT_REG_GET = 821,\n \tHWRM_TFT_REG_SET = 822,\n \tHWRM_TFT_TBL_TYPE_SET = 823,\n@@ -83,10 +81,6 @@ struct tf_session_sram_resc_flush_input;\n struct tf_tbl_type_set_input;\n struct tf_tbl_type_get_input;\n struct tf_tbl_type_get_output;\n-struct tf_em_internal_insert_input;\n-struct tf_em_internal_insert_output;\n-struct tf_em_internal_delete_input;\n-struct tf_em_internal_delete_output;\n /* Input params for session attach */\n typedef struct tf_session_attach_input {\n \t/* Firmware session id returned when HWRM_TF_SESSION_OPEN is sent */\n@@ -351,7 +345,7 @@ typedef struct tf_session_hw_resc_alloc_output {\n \tuint16_t\t\t\t range_prof_start;\n \t/* Number range profiles allocated */\n \tuint16_t\t\t\t range_prof_stride;\n-\t/* Starting index of range entries allocated to the session */\n+\t/* Starting index of range enntries allocated to the session */\n \tuint16_t\t\t\t range_entries_start;\n \t/* Number of range entries allocated */\n \tuint16_t\t\t\t range_entries_stride;\n@@ -453,7 +447,7 @@ typedef struct tf_session_hw_resc_free_input {\n \tuint16_t\t\t\t range_prof_start;\n \t/* Number range profiles allocated */\n \tuint16_t\t\t\t range_prof_stride;\n-\t/* Starting index of range entries allocated to the session */\n+\t/* Starting index of range enntries allocated to the session */\n \tuint16_t\t\t\t range_entries_start;\n \t/* Number of range entries allocated */\n \tuint16_t\t\t\t range_entries_stride;\n@@ -555,7 +549,7 @@ typedef struct tf_session_hw_resc_flush_input {\n \tuint16_t\t\t\t range_prof_start;\n \t/* Number range profiles allocated */\n \tuint16_t\t\t\t range_prof_stride;\n-\t/* Starting index of range entries allocated to the session */\n+\t/* Starting index of range enntries allocated to the session */\n \tuint16_t\t\t\t range_entries_start;\n \t/* Number of range entries allocated */\n \tuint16_t\t\t\t range_entries_stride;\n@@ -922,60 +916,4 @@ typedef struct tf_tbl_type_get_output {\n \tuint8_t\t\t\t data[TF_BULK_RECV];\n } tf_tbl_type_get_output_t, *ptf_tbl_type_get_output_t;\n \n-/* Input params for EM internal rule insert */\n-typedef struct tf_em_internal_insert_input {\n-\t/* Firmware Session Id */\n-\tuint32_t\t\t\t fw_session_id;\n-\t/* flags */\n-\tuint16_t\t\t\t flags;\n-\t/* When set to 0, indicates the get apply to RX */\n-#define TF_EM_INTERNAL_INSERT_INPUT_FLAGS_DIR_RX\t (0x0)\n-\t/* When set to 1, indicates the get apply to TX */\n-#define TF_EM_INTERNAL_INSERT_INPUT_FLAGS_DIR_TX\t (0x1)\n-\t/* strength */\n-\tuint16_t\t\t\t strength;\n-\t/* index to action */\n-\tuint32_t\t\t\t action_ptr;\n-\t/* index of em record */\n-\tuint32_t\t\t\t em_record_idx;\n-\t/* EM Key value */\n-\tuint64_t\t\t\t em_key[8];\n-\t/* number of bits in em_key */\n-\tuint16_t\t\t\t em_key_bitlen;\n-} tf_em_internal_insert_input_t, *ptf_em_internal_insert_input_t;\n-\n-/* Output params for EM internal rule insert */\n-typedef struct tf_em_internal_insert_output {\n-\t/* EM record pointer index */\n-\tuint16_t\t\t\t rptr_index;\n-\t/* EM record offset 0~3 */\n-\tuint8_t\t\t\t rptr_entry;\n-\t/* Number of word entries consumed by the key */\n-\tuint8_t\t\t\t num_of_entries;\n-} tf_em_internal_insert_output_t, *ptf_em_internal_insert_output_t;\n-\n-/* Input params for EM INTERNAL rule delete */\n-typedef struct tf_em_internal_delete_input {\n-\t/* Session Id */\n-\tuint32_t\t\t\t tf_session_id;\n-\t/* flags */\n-\tuint16_t\t\t\t flags;\n-\t/* When set to 0, indicates the get apply to RX */\n-#define TF_EM_INTERNAL_DELETE_INPUT_FLAGS_DIR_RX\t (0x0)\n-\t/* When set to 1, indicates the get apply to TX */\n-#define TF_EM_INTERNAL_DELETE_INPUT_FLAGS_DIR_TX\t (0x1)\n-\t/* EM internal flow hanndle */\n-\tuint64_t\t\t\t flow_handle;\n-\t/* EM Key value */\n-\tuint64_t\t\t\t em_key[8];\n-\t/* number of bits in em_key */\n-\tuint16_t\t\t\t em_key_bitlen;\n-} tf_em_internal_delete_input_t, *ptf_em_internal_delete_input_t;\n-\n-/* Input params for EM INTERNAL rule delete */\n-typedef struct tf_em_internal_delete_output {\n-\t/* Original stack allocation index */\n-\tuint16_t\t\t\t em_index;\n-} tf_em_internal_delete_output_t, *ptf_em_internal_delete_output_t;\n-\n #endif /* _HWRM_TF_H_ */\ndiff --git a/drivers/net/bnxt/tf_core/tf_msg.c b/drivers/net/bnxt/tf_core/tf_msg.c\nindex 554a849..c8f6b88 100644\n--- a/drivers/net/bnxt/tf_core/tf_msg.c\n+++ b/drivers/net/bnxt/tf_core/tf_msg.c\n@@ -1023,32 +1023,38 @@ int tf_msg_insert_em_internal_entry(struct tf *tfp,\n \t\t\t\tuint8_t *rptr_entry,\n \t\t\t\tuint8_t *num_of_entries)\n {\n-\tint rc;\n-\tstruct tfp_send_msg_parms parms = { 0 };\n-\tstruct tf_em_internal_insert_input req = { 0 };\n-\tstruct tf_em_internal_insert_output resp = { 0 };\n+\tint rc;\n+\tstruct tfp_send_msg_parms parms = { 0 };\n+\tstruct hwrm_tf_em_insert_input req = { 0 };\n+\tstruct hwrm_tf_em_insert_output resp = { 0 };\n \tstruct tf_session *tfs = (struct tf_session *)(tfp->session->core_data);\n \tstruct tf_em_64b_entry *em_result =\n \t\t(struct tf_em_64b_entry *)em_parms->em_record;\n+\tuint32_t flags;\n \n \treq.fw_session_id =\n \t\ttfp_cpu_to_le_32(tfs->session_id.internal.fw_session_id);\n \tmemcpy(req.em_key, em_parms->key, ((em_parms->key_sz_in_bits + 7) / 8));\n-\treq.flags = tfp_cpu_to_le_16(em_parms->dir);\n+\n+\tflags = (em_parms->dir == TF_DIR_TX ?\n+\t\t HWRM_TF_EM_INSERT_INPUT_FLAGS_DIR_TX :\n+\t\t HWRM_TF_EM_INSERT_INPUT_FLAGS_DIR_RX);\n+\treq.flags = tfp_cpu_to_le_16(flags);\n \treq.strength = (em_result->hdr.word1 & TF_LKUP_RECORD_STRENGTH_MASK) >>\n \t\tTF_LKUP_RECORD_STRENGTH_SHIFT;\n \treq.em_key_bitlen = em_parms->key_sz_in_bits;\n \treq.action_ptr = em_result->hdr.pointer;\n \treq.em_record_idx = *rptr_index;\n \n-\tMSG_PREP(parms,\n-\t\t TF_KONG_MB,\n-\t\t HWRM_TF,\n-\t\t HWRM_TFT_EM_RULE_INSERT,\n-\t\t req,\n-\t\t resp);\n+\tparms.tf_type = HWRM_TF_EM_INSERT;\n+\tparms.req_data = (uint32_t *)&req;\n+\tparms.req_size = sizeof(req);\n+\tparms.resp_data = (uint32_t *)&resp;\n+\tparms.resp_size = sizeof(resp);\n+\tparms.mailbox = TF_KONG_MB;\n \n-\trc = tfp_send_msg_tunneled(tfp, &parms);\n+\trc = tfp_send_msg_direct(tfp,\n+\t\t\t\t &parms);\n \tif (rc)\n \t\treturn rc;\n \n@@ -1056,7 +1062,7 @@ int tf_msg_insert_em_internal_entry(struct tf *tfp,\n \t*rptr_index = resp.rptr_index;\n \t*num_of_entries = resp.num_of_entries;\n \n-\treturn tfp_le_to_cpu_32(parms.tf_resp_code);\n+\treturn 0;\n }\n \n /**\n@@ -1065,32 +1071,38 @@ int tf_msg_insert_em_internal_entry(struct tf *tfp,\n int tf_msg_delete_em_entry(struct tf *tfp,\n \t\t\t struct tf_delete_em_entry_parms *em_parms)\n {\n-\tint rc;\n-\tstruct tfp_send_msg_parms parms = { 0 };\n-\tstruct tf_em_internal_delete_input req = { 0 };\n-\tstruct tf_em_internal_delete_output resp = { 0 };\n+\tint rc;\n+\tstruct tfp_send_msg_parms parms = { 0 };\n+\tstruct hwrm_tf_em_delete_input req = { 0 };\n+\tstruct hwrm_tf_em_delete_output resp = { 0 };\n+\tuint32_t flags;\n \tstruct tf_session *tfs =\n \t\t(struct tf_session *)(tfp->session->core_data);\n \n-\treq.tf_session_id =\n+\treq.fw_session_id =\n \t\ttfp_cpu_to_le_32(tfs->session_id.internal.fw_session_id);\n-\treq.flags = tfp_cpu_to_le_16(em_parms->dir);\n+\n+\tflags = (em_parms->dir == TF_DIR_TX ?\n+\t\t HWRM_TF_EM_DELETE_INPUT_FLAGS_DIR_TX :\n+\t\t HWRM_TF_EM_DELETE_INPUT_FLAGS_DIR_RX);\n+\treq.flags = tfp_cpu_to_le_16(flags);\n \treq.flow_handle = tfp_cpu_to_le_64(em_parms->flow_handle);\n \n-\tMSG_PREP(parms,\n-\t\t TF_KONG_MB,\n-\t\t HWRM_TF,\n-\t\t HWRM_TFT_EM_RULE_DELETE,\n-\t\t req,\n-\t\tresp);\n+\tparms.tf_type = HWRM_TF_EM_DELETE;\n+\tparms.req_data = (uint32_t *)&req;\n+\tparms.req_size = sizeof(req);\n+\tparms.resp_data = (uint32_t *)&resp;\n+\tparms.resp_size = sizeof(resp);\n+\tparms.mailbox = TF_KONG_MB;\n \n-\trc = tfp_send_msg_tunneled(tfp, &parms);\n+\trc = tfp_send_msg_direct(tfp,\n+\t\t\t\t &parms);\n \tif (rc)\n \t\treturn rc;\n \n \tem_parms->index = tfp_le_to_cpu_16(resp.em_index);\n \n-\treturn tfp_le_to_cpu_32(parms.tf_resp_code);\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "10/50" ] }