Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71339/?format=api
{ "id": 71339, "url": "http://patches.dpdk.org/api/patches/71339/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-16-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200612032410.20864-16-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-16-guinanx.sun@intel.com", "date": "2020-06-12T03:24:04", "name": "[15/21] net/ixgbe/base: remove unnecessary log message FC autonego", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fb0c2fe78a636cb7ac59277b910cf5279f12af29", "submitter": { "id": 1476, "url": "http://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-16-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10428, "url": "http://patches.dpdk.org/api/series/10428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10428", "date": "2020-06-12T03:23:49", "name": "update ixgbe base code", "version": 1, "mbox": "http://patches.dpdk.org/series/10428/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71339/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/71339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6D01A00BE;\n\tFri, 12 Jun 2020 05:48:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F0ED11BF53;\n\tFri, 12 Jun 2020 05:46:35 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 098491BEE6\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:32 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:32 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:31 -0700" ], "IronPort-SDR": [ "\n 6HKqCjd6IlIf4omdQiJaR+Gzqzyp3kDjIYhSFQkp2dpvJxPh9F1NC63KV2smLGELHuYaTrVR45\n aFSQW95XjACw==", "\n uNqAKE4wpsdV3R7SiQsO8hlSWa/YEb3gGS+yG4LNqP/0ifm9XZCS+b627sDtf9gEyXZ8ManaA2\n +ngC5efCWprg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759583\"", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n Zalfresso-Jundzillo <marekx.zalfresso-jundzillo@intel.com>", "Date": "Fri, 12 Jun 2020 03:24:04 +0000", "Message-Id": "<20200612032410.20864-16-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>", "References": "<20200612032410.20864-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH 15/21] net/ixgbe/base: remove unnecessary log\n\tmessage FC autonego", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function ixgbe_device_supports_autoneg_fc is checking whether\na particular device and medium configuration is supporting\nFlow Control Autonegotiation. In case of non-support, the message\nis always logged which is confusing.\nThe fix is removing unnecessary log entry.\n\nSigned-off-by: Zalfresso-Jundzillo <marekx.zalfresso-jundzillo@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex c4e99d876..4a3b48b39 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -187,10 +187,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)\n \t\tbreak;\n \t}\n \n-\tif (!supported)\n-\t\tERROR_REPORT2(IXGBE_ERROR_UNSUPPORTED,\n-\t\t\t \"Device %x does not support flow control autoneg\",\n-\t\t\t hw->device_id);\n \treturn supported;\n }\n \n", "prefixes": [ "15/21" ] }