Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71303/?format=api
{ "id": 71303, "url": "http://patches.dpdk.org/api/patches/71303/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200611235817.208091-2-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200611235817.208091-2-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200611235817.208091-2-lance.richardson@broadcom.com", "date": "2020-06-11T23:58:15", "name": "[1/3] net/bnxt: disable vector receive for mark action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2e64adcd76d1bec482408d977a2b6b8e1115f608", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200611235817.208091-2-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 10422, "url": "http://patches.dpdk.org/api/series/10422/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10422", "date": "2020-06-11T23:58:14", "name": "net/bnxt: vector mode enhancements", "version": 1, "mbox": "http://patches.dpdk.org/series/10422/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71303/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/71303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B71DA00BE;\n\tFri, 12 Jun 2020 01:58:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1167D1252;\n\tFri, 12 Jun 2020 01:58:32 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 4332411A4\n for <dev@dpdk.org>; Fri, 12 Jun 2020 01:58:30 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 464D830D80D;\n Thu, 11 Jun 2020 16:58:29 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.150.244])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 8DB90140069;\n Thu, 11 Jun 2020 16:58:28 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 464D830D80D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1591919909;\n bh=1w4lCQwuwR+2ZtzA2Or1LEjbGJPe/7jh4PbNT/wbZlE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RHanXamNwX93J3FFJcBfFKKqJQQYm6NieEEb5kZ6mzWJI+JZmoqV8mTZQfmYSdL3s\n o3EAxWCIFJI7Bmnd3/uU/7Ep6UxXf245FTiKnbiJKiyzpjNSQFxubf031/5meRBFmi\n iYgre/f2dA7ci4O6IZ4qRGtf1iRiQd17UrSvxO9g=", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "dev@dpdk.org,\n\tajit.khaparde@broadcom.com", "Cc": "Thomas Monjalon <thomas@monjalon.net>", "Date": "Thu, 11 Jun 2020 19:58:15 -0400", "Message-Id": "<20200611235817.208091-2-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200611235817.208091-1-lance.richardson@broadcom.com>", "References": "<20200611235817.208091-1-lance.richardson@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/bnxt: disable vector receive for mark\n\taction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The bnxt vector mode receive handler does not support the rte_flow\n'mark' action. Since we cannot know in advance whether this action\nwill be required, add support for dynamically switching from vector\nto non-vector receive when the first flow create request with a\nmark action is processed.\n\nFixes: 94eb699bc82e (\"net/bnxt: support flow mark action\")\nSuggested-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 20 ++++++++------------\n drivers/net/bnxt/bnxt_rxr.c | 18 ++++++++++++++++++\n 2 files changed, 26 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 84a21dba9..19bc66a5a 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -18,6 +18,7 @@\n #include \"bnxt_hwrm.h\"\n #include \"bnxt_ring.h\"\n #include \"bnxt_rxq.h\"\n+#include \"bnxt_rxr.h\"\n #include \"bnxt_vnic.h\"\n #include \"hsi_struct_def_dpdk.h\"\n \n@@ -1403,18 +1404,6 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tbnxt_update_filter_flags_en(filter, filter1, use_ntuple);\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_MARK:\n-\t\tif (bp->flags & BNXT_FLAG_RX_VECTOR_PKT_MODE) {\n-\t\t\tPMD_DRV_LOG(DEBUG,\n-\t\t\t\t \"Disable vector processing for mark\\n\");\n-\t\t\trte_flow_error_set(error,\n-\t\t\t\t\t ENOTSUP,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\t act,\n-\t\t\t\t\t \"Disable vector processing for mark\");\n-\t\t\trc = -rte_errno;\n-\t\t\tgoto ret;\n-\t\t}\n-\n \t\tif (bp->mark_table == NULL) {\n \t\t\trte_flow_error_set(error,\n \t\t\t\t\t ENOMEM,\n@@ -1425,6 +1414,13 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\t\tgoto ret;\n \t\t}\n \n+\t\tif (bp->flags & BNXT_FLAG_RX_VECTOR_PKT_MODE) {\n+\t\t\tPMD_DRV_LOG(DEBUG,\n+\t\t\t\t \"Disabling vector processing for mark\\n\");\n+\t\t\tbp->eth_dev->rx_pkt_burst = bnxt_recv_pkts;\n+\t\t\tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n+\t\t}\n+\n \t\tfilter->valid_flags |= BNXT_FLOW_MARK_FLAG;\n \t\tfilter->mark = ((const struct rte_flow_action_mark *)\n \t\t\t\tact->conf)->id;\ndiff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 91ff72904..eeb0aeefc 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -747,6 +747,24 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t !rte_spinlock_trylock(&rxq->lock)))\n \t\treturn 0;\n \n+#if defined(RTE_ARCH_X86)\n+\t/*\n+\t * Replenish buffers if needed when a transition has been made from\n+\t * vector- to non-vector- receive processing.\n+\t */\n+\twhile (unlikely(rxq->rxrearm_nb)) {\n+\t\tif (!bnxt_alloc_rx_data(rxq, rxr, rxq->rxrearm_start)) {\n+\t\t\trxr->rx_prod = rxq->rxrearm_start;\n+\t\t\tbnxt_db_write(&rxr->rx_db, rxr->rx_prod);\n+\t\t\trxq->rxrearm_start++;\n+\t\t\trxq->rxrearm_nb--;\n+\t\t} else {\n+\t\t\t/* Retry allocation on next call. */\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+#endif\n+\n \t/* Handle RX burst request */\n \twhile (1) {\n \t\tcons = RING_CMP(cpr->cp_ring_struct, raw_cons);\n", "prefixes": [ "1/3" ] }