Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71186/?format=api
{ "id": 71186, "url": "http://patches.dpdk.org/api/patches/71186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200610142730.31376-7-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200610142730.31376-7-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200610142730.31376-7-dmitry.kozliuk@gmail.com", "date": "2020-06-10T14:27:25", "name": "[v8,06/11] trace: add size_t field emitter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7fb11701ff34517a276a8aa57f9f969431d47355", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200610142730.31376-7-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 10386, "url": "http://patches.dpdk.org/api/series/10386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10386", "date": "2020-06-10T14:27:19", "name": "Windows basic memory management", "version": 8, "mbox": "http://patches.dpdk.org/series/10386/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71186/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/71186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0081A051F;\n\tWed, 10 Jun 2020 16:28:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A814C1BF76;\n\tWed, 10 Jun 2020 16:28:00 +0200 (CEST)", "from mail-lj1-f194.google.com (mail-lj1-f194.google.com\n [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id F1C221BF30\n for <dev@dpdk.org>; Wed, 10 Jun 2020 16:27:56 +0200 (CEST)", "by mail-lj1-f194.google.com with SMTP id 9so2743687ljv.5\n for <dev@dpdk.org>; Wed, 10 Jun 2020 07:27:56 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id j12sm5051733ljg.15.2020.06.10.07.27.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 10 Jun 2020 07:27:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=dVcxVkYcX4IdEsRf5bHPXaga+vGMrVzMkh75QGfZRIc=;\n b=mNZZgr479RVbr3AzY+6xtVaQK1fVIyMHgurjB+AexqXpeaUUgfCilQN354rrCnW16l\n S71kNti3o4mxJPWbzajIAK3fIiNApB30KQQbM0Shs1xXg6ckZ6w6RiQPSwCpnhUfeWCg\n 7XrTz70Gnv5yYCBWCVQpVmor9DQQSkdAE8xGKsKJLyLGjtJX0aPclKDJqeAUZh63E0+E\n blnfC+S2t+jbwvBfnRIpte2XrhjQ+jtq7jXbV2QGu0LIPkiop9hNisHIiOJqUsPS+5Do\n DKGLDRZooDRGhHoeLA51oj2++ynfc0emb7F3fHUWcgi7GfC45VyIvUtdpvXXI0ApMjh4\n 656A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=dVcxVkYcX4IdEsRf5bHPXaga+vGMrVzMkh75QGfZRIc=;\n b=c2eVWYvMIRqGDRhPOwxwYNb2jrJ0RsNa7kaSV3G2VmPcZavBjaGV+SeYxqA/tSPrXU\n RMfIblqYpb+2vRMH3OLVdHvmyvRKsbtSK8Oxu6Ry0rYasuNu1EAhsUeE0JUVmOqVqGux\n +YO0jjMc4AbIT5QnzQxEdpPL68HRr62LYChryafJOFZAuSgo8afHnM3wy0xLNzzxLyDI\n Py60rGWz/SHtn9iESyEOz1pLvI3kqaeQg2e5hOBoBzAqTf3Ds3vNdSEyH9PzqH0pTfhk\n sjVv6MNpWlAOTXv1J/OCxy5xYn8qZk4WirRqEqVAgbIIq3HIqaeUhQtgnPp65xUcoJBg\n cOwA==", "X-Gm-Message-State": "AOAM530PAUqvzM5XZzXxNuwhkJxt7AxcoCAKfm4goMuttLMmprMaJ+fE\n Jln9pshjElZ2jTsQ9AoeADZaAILsEwE7MQ==", "X-Google-Smtp-Source": "\n ABdhPJyKMiX3Jx1izDBrtVU5HMgBJebNuqIkRYOX4rStrdjYMqMfvY52I8cLfl4VkgHkGZApbDsTJA==", "X-Received": "by 2002:a2e:9608:: with SMTP id v8mr2040549ljh.172.1591799276196;\n Wed, 10 Jun 2020 07:27:56 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Malloy <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Wed, 10 Jun 2020 17:27:25 +0300", "Message-Id": "<20200610142730.31376-7-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200610142730.31376-1-dmitry.kozliuk@gmail.com>", "References": "<20200608074153.29611-1-dmitry.kozliuk@gmail.com>\n <20200610142730.31376-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 06/11] trace: add size_t field emitter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows,\nsizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs.\nTracepoints using \"long\" field emitter are therefore invalid there.\nAdd dedicated field emitter for size_t and use it to store size_t values\nin all existing tracepoints.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/include/rte_eal_trace.h | 8 ++++----\n lib/librte_eal/include/rte_trace_point.h | 3 +++\n lib/librte_mempool/rte_mempool_trace.h | 10 +++++-----\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/include/rte_eal_trace.h b/lib/librte_eal/include/rte_eal_trace.h\nindex 1ebb2905a..bcfef0cfa 100644\n--- a/lib/librte_eal/include/rte_eal_trace.h\n+++ b/lib/librte_eal/include/rte_eal_trace.h\n@@ -143,7 +143,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(const char *type, size_t size, unsigned int align,\n \t\tint socket, void *ptr),\n \trte_trace_point_emit_string(type);\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -154,7 +154,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(const char *type, size_t size, unsigned int align,\n \t\tint socket, void *ptr),\n \trte_trace_point_emit_string(type);\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -164,7 +164,7 @@ RTE_TRACE_POINT(\n \trte_eal_trace_mem_realloc,\n \tRTE_TRACE_POINT_ARGS(size_t size, unsigned int align, int socket,\n \t\tvoid *ptr),\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -183,7 +183,7 @@ RTE_TRACE_POINT(\n \t\tunsigned int flags, unsigned int align, unsigned int bound,\n \t\tconst void *mz),\n \trte_trace_point_emit_string(name);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_int(socket_id);\n \trte_trace_point_emit_u32(flags);\n \trte_trace_point_emit_u32(align);\ndiff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h\nindex b45171275..377c2414a 100644\n--- a/lib/librte_eal/include/rte_trace_point.h\n+++ b/lib/librte_eal/include/rte_trace_point.h\n@@ -138,6 +138,8 @@ _tp _args \\\n #define rte_trace_point_emit_int(val)\n /** Tracepoint function payload for long datatype */\n #define rte_trace_point_emit_long(val)\n+/** Tracepoint function payload for size_t datatype */\n+#define rte_trace_point_emit_size_t(val)\n /** Tracepoint function payload for float datatype */\n #define rte_trace_point_emit_float(val)\n /** Tracepoint function payload for double datatype */\n@@ -395,6 +397,7 @@ do { \\\n #define rte_trace_point_emit_i8(in) __rte_trace_point_emit(in, int8_t)\n #define rte_trace_point_emit_int(in) __rte_trace_point_emit(in, int32_t)\n #define rte_trace_point_emit_long(in) __rte_trace_point_emit(in, long)\n+#define rte_trace_point_emit_size_t(in) __rte_trace_point_emit(in, size_t)\n #define rte_trace_point_emit_float(in) __rte_trace_point_emit(in, float)\n #define rte_trace_point_emit_double(in) __rte_trace_point_emit(in, double)\n #define rte_trace_point_emit_ptr(in) __rte_trace_point_emit(in, uintptr_t)\ndiff --git a/lib/librte_mempool/rte_mempool_trace.h b/lib/librte_mempool/rte_mempool_trace.h\nindex e776df0a6..087c913c8 100644\n--- a/lib/librte_mempool/rte_mempool_trace.h\n+++ b/lib/librte_mempool/rte_mempool_trace.h\n@@ -72,7 +72,7 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_string(mempool->name);\n \trte_trace_point_emit_ptr(vaddr);\n \trte_trace_point_emit_u64(iova);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_ptr(free_cb);\n \trte_trace_point_emit_ptr(opaque);\n )\n@@ -84,8 +84,8 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_ptr(mempool);\n \trte_trace_point_emit_string(mempool->name);\n \trte_trace_point_emit_ptr(addr);\n-\trte_trace_point_emit_long(len);\n-\trte_trace_point_emit_long(pg_sz);\n+\trte_trace_point_emit_size_t(len);\n+\trte_trace_point_emit_size_t(pg_sz);\n \trte_trace_point_emit_ptr(free_cb);\n \trte_trace_point_emit_ptr(opaque);\n )\n@@ -126,7 +126,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(struct rte_mempool *mempool, size_t pg_sz),\n \trte_trace_point_emit_ptr(mempool);\n \trte_trace_point_emit_string(mempool->name);\n-\trte_trace_point_emit_long(pg_sz);\n+\trte_trace_point_emit_size_t(pg_sz);\n )\n \n RTE_TRACE_POINT(\n@@ -139,7 +139,7 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_u32(max_objs);\n \trte_trace_point_emit_ptr(vaddr);\n \trte_trace_point_emit_u64(iova);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_ptr(obj_cb);\n \trte_trace_point_emit_ptr(obj_cb_arg);\n )\n", "prefixes": [ "v8", "06/11" ] }