Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71050/?format=api
{ "id": 71050, "url": "http://patches.dpdk.org/api/patches/71050/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200609120001.35110-44-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200609120001.35110-44-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200609120001.35110-44-qi.z.zhang@intel.com", "date": "2020-06-09T11:59:52", "name": "[v2,43/52] net/ice/base: adjust scheduler default BW weight", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "852cc8034f5d56bfebd2fc94f6c656858851e14e", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200609120001.35110-44-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 10359, "url": "http://patches.dpdk.org/api/series/10359/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10359", "date": "2020-06-09T11:59:09", "name": "net/ice: base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/10359/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71050/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/71050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C97FEA0516;\n\tTue, 9 Jun 2020 14:03:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 582021C00F;\n\tTue, 9 Jun 2020 13:57:29 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id DB7F81BFF8\n for <dev@dpdk.org>; Tue, 9 Jun 2020 13:57:26 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jun 2020 04:57:26 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by fmsmga005.fm.intel.com with ESMTP; 09 Jun 2020 04:57:24 -0700" ], "IronPort-SDR": [ "\n 36ebDZUSe8T5I7fzOa3mhCdx9h4OYgUok3tN1tmUvQIdWy3RZuUIk7asyZ7XhklAmhKqusPdLN\n XQ+pNcQtwbBw==", "\n 6W/iITbvhd5GZaO4yXFiuWH2uKe3h1Q4mqP5jSZCG2lR4t3ML5ZmMT3PAcP7/6jMxhQWBCkgsZ\n AENlAkFUV4kA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,492,1583222400\"; d=\"scan'208\";a=\"473044254\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tarun Singh <tarun.k.singh@intel.com>,\n \"Paul M . Stillwell Jr\" <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 9 Jun 2020 19:59:52 +0800", "Message-Id": "<20200609120001.35110-44-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200609120001.35110-1-qi.z.zhang@intel.com>", "References": "<20200603024016.30636-1-qi.z.zhang@intel.com>\n <20200609120001.35110-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 43/52] net/ice/base: adjust scheduler default\n\tBW weight", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By default the queues are configured in legacy mode. The default\nBW settings for legacy/advanced modes are different. The existing\ncode was using the advanced mode default value of 1 which was\nincorrect. This caused the unbalanced BW sharing among siblings.\nThe recommneded default value is applied.\n\nSigned-off-by: Tarun Singh <tarun.k.singh@intel.com>\nSigned-off-by: Paul M. Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 13 ++++++++++++-\n drivers/net/ice/base/ice_type.h | 2 +-\n 2 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex d02a047f6..54112e8f2 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -4012,7 +4012,18 @@ ice_ena_vsi_txq(struct ice_port_info *pi, u16 vsi_handle, u8 tc, u16 q_handle,\n \t * Without setting the generic section as valid in valid_sections, the\n \t * Admin queue command will fail with error code ICE_AQ_RC_EINVAL.\n \t */\n-\tbuf->txqs[0].info.valid_sections = ICE_AQC_ELEM_VALID_GENERIC;\n+\tbuf->txqs[0].info.valid_sections =\n+\t\tICE_AQC_ELEM_VALID_GENERIC | ICE_AQC_ELEM_VALID_CIR |\n+\t\tICE_AQC_ELEM_VALID_EIR;\n+\tbuf->txqs[0].info.generic = 0;\n+\tbuf->txqs[0].info.cir_bw.bw_profile_idx =\n+\t\tCPU_TO_LE16(ICE_SCHED_DFLT_RL_PROF_ID);\n+\tbuf->txqs[0].info.cir_bw.bw_alloc =\n+\t\tCPU_TO_LE16(ICE_SCHED_DFLT_BW_WT);\n+\tbuf->txqs[0].info.eir_bw.bw_profile_idx =\n+\t\tCPU_TO_LE16(ICE_SCHED_DFLT_RL_PROF_ID);\n+\tbuf->txqs[0].info.eir_bw.bw_alloc =\n+\t\tCPU_TO_LE16(ICE_SCHED_DFLT_BW_WT);\n \n \t/* add the LAN queue */\n \tstatus = ice_aq_add_lan_txq(hw, num_qgrps, buf, buf_size, cd);\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex a6dece9c1..41a1912bf 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -610,7 +610,7 @@ enum ice_rl_type {\n #define ICE_SCHED_NO_BW_WT\t\t0\n #define ICE_SCHED_DFLT_RL_PROF_ID\t0\n #define ICE_SCHED_NO_SHARED_RL_PROF_ID\t0xFFFF\n-#define ICE_SCHED_DFLT_BW_WT\t\t1\n+#define ICE_SCHED_DFLT_BW_WT\t\t4\n #define ICE_SCHED_INVAL_PROF_ID\t\t0xFFFF\n #define ICE_SCHED_DFLT_BURST_SIZE\t(15 * 1024)\t/* in bytes (15k) */\n \n", "prefixes": [ "v2", "43/52" ] }