Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70969/?format=api
{ "id": 70969, "url": "http://patches.dpdk.org/api/patches/70969/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200608160156.20546-2-getelson@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200608160156.20546-2-getelson@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200608160156.20546-2-getelson@mellanox.com", "date": "2020-06-08T16:01:56", "name": "[1/1] net/mlx5: fix flow memory allocation size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1feb177807cddda87b76f3c794d36d266a912d8", "submitter": { "id": 1773, "url": "http://patches.dpdk.org/api/people/1773/?format=api", "name": "Gregory Etelson", "email": "getelson@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200608160156.20546-2-getelson@mellanox.com/mbox/", "series": [ { "id": 10345, "url": "http://patches.dpdk.org/api/series/10345/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10345", "date": "2020-06-08T16:01:55", "name": "net/mlx5: fix flow memory allocation size", "version": 1, "mbox": "http://patches.dpdk.org/series/10345/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70969/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/70969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36943A04F2;\n\tMon, 8 Jun 2020 18:02:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B0582C23;\n\tMon, 8 Jun 2020 18:02:13 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43])\n by dpdk.org (Postfix) with ESMTP id 539C52BE2\n for <dev@dpdk.org>; Mon, 8 Jun 2020 18:02:11 +0200 (CEST)", "from DB8PR05MB6761.eurprd05.prod.outlook.com (2603:10a6:10:139::21)\n by DB8PR05MB6777.eurprd05.prod.outlook.com (2603:10a6:10:134::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Mon, 8 Jun\n 2020 16:02:10 +0000", "from DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::10cf:d50d:bee:a43]) by DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::10cf:d50d:bee:a43%4]) with mapi id 15.20.3066.023; Mon, 8 Jun 2020\n 16:02:10 +0000", "from mellanox.com (176.230.226.145) by\n AM0PR05CA0090.eurprd05.prod.outlook.com (2603:10a6:208:136::30) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend\n Transport; Mon, 8 Jun 2020 16:02:09 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=OxFNDkiOxudZUKMYWX+8zGo8Vj/A45g9zfBtDULuMbiOIg4f1BwPTNO3WcjhnBYuAKMKOuGmwAym80bu+ihWXQuKLioGaPTAhZf0cZ1cT9m8CBuyzOh/j+rayIXMqnJczzR9QCZ+Y8n4TdnScp/0hlEYzmXNOuSK8FGFuLPWMlrMV1dCP3DWQcyyMTARQWJnBEk7wcT/EzjIxj/dntk59vjzE6i4On07UBbMrFLPqdBtQSEIpjZJ8jHhdVHQ1MR8hPKxmwMFMxP9+4HCL7T7Gv1QCUGHrQ3BnPx24Gl9ZRkRdguwvDx2O3aD8I5eOnb/hUg1MFs9ZDVMJDxigGUhsg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ykTj38soKBgSRyetAKnXjoWmqk+kHpilX/3RXSS2L+4=;\n b=KpNRrrIsaAObnboG1gngHyfPr9W2uXiovkazFirVbljW8yTWsYHhMQVztwqIry8NFJYMIrbV/MlebUk6nseThDz5XJ66jTLhKkmwx7jNJjudy7QpHTQFZwtB8yKof0JMYM8+j955QrFLqMNGGjains/HxV1DJ7F52GyZSw/n26Ju1Gpx3FPv5dpMNmwA9ZKFfJbtiQAsx9sCh9UkFhxrxME57lOBXlmoHbu6WVu6DWNf7Fiv0byCSs4lJMKlJ6JI6wCIBNbm0cYN+k0pBWebB63yjhtyNIvu8yGApqoNOmAkNGYCWctWcfGDcdV0BeCJ8eX6xDp8Dpmh9EcvPw/Tag==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ykTj38soKBgSRyetAKnXjoWmqk+kHpilX/3RXSS2L+4=;\n b=I63wTxqwJWMofhN7j8RMbauzEo4csV5huNyPHgGZhkonKzBzkRCZGXIa4t3wL5TLCGffgucfKehJfuqbP5e3ouHvvOSELMQ71FiontemFLzIdce6CFRWws8ZvNsstrC0fGiQlcAD+TzjspPlr98EpXC2CaQhHljgArgDsovQtzk=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Gregory Etelson <getelson@mellanox.com>", "To": "dev@dpdk.org", "Cc": "getelson@mellanox.com,\n\tmatan@mellanox.com,\n\trasland@mellanox.com", "Date": "Mon, 8 Jun 2020 19:01:56 +0300", "Message-Id": "<20200608160156.20546-2-getelson@mellanox.com>", "X-Mailer": [ "git-send-email 2.25.1", "git-send-email 2.25.1" ], "In-Reply-To": "<20200608160156.20546-1-getelson@mellanox.com>", "References": "<20200608160156.20546-1-getelson@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR05CA0090.eurprd05.prod.outlook.com\n (2603:10a6:208:136::30) To DB8PR05MB6761.eurprd05.prod.outlook.com\n (2603:10a6:10:139::21)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[176.230.226.145]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "42e65b40-6719-46d0-1708-08d80bc54d1a", "X-MS-TrafficTypeDiagnostic": "DB8PR05MB6777:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB8PR05MB6777CCBAB413AA4E0A5C4F1DA8850@DB8PR05MB6777.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4941;", "X-Forefront-PRVS": "042857DBB5", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n PUTclE9GcMipk0L4UWYWqYAAEmn1usedCNhK82pt+8zJR60hMSeTxxSRVrzr08p5DHqJHSS4IMCBAtOAzk/XfOMy64726ociLwrOAtNenMrEGUZMkPuTEBLGuC0hNPuQMuo1fBfCI4bzBhF1CzMgbLSKvnAY8w6Ryqc2OdrJ2RabwRft4yu9paOlTq6glugC5Cu87fxySnYeNcELpga4Ukr9KTVVNQMNPIEcSAQ3x+M3m131FZ94D2qJ/qbbFZdUxNE0QQtm1n0mW2dJS+/WHXCB6XFEeySrISuxTAva8rnP0uw2Xx5utddQMtswlZzmmdyz6gQxWMdxvIHihD9Wxw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB8PR05MB6761.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(83380400001)(2906002)(8936002)(36756003)(5660300002)(316002)(107886003)(4326008)(55016002)(8676002)(26005)(478600001)(86362001)(6666004)(52116002)(7696005)(6916009)(1076003)(956004)(16526019)(186003)(66476007)(66946007)(66556008)(8886007)(2616005);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n K+KvI2UckGJtRKNu6FT8gmqMItOG7c74axhQsMMgJRqz7mr7SP1xeqQMu4OOcWONkGEifHXg4x8UFoin1Rq/UNPDRT1JBS8gKQSueiirFUQD2rqe1HZGUQx6KJhq7r9FFlpXM9KkRah/J6P96WymHFJA4QCfmhTJs+1d56XsDtd402mV9tJQSWwpRcTNVKjuvh5vqNr4xOKnCoI+4XwFk/isMqle8c8Qwsohl6ITUJCFF+GDcXUA2fCnMsTTVW6wI0YCRFAEKLgvzhk9A/U9YIVgmZfFIMpKGQXLtwx4TsYuzXOfzkn2m6FZ2/J1D9Mkj5D5hI96YnGlvzciLsGFiJukp2UaPo2bERXhp68YP32GD5JEme6Bp4YAkteFVhY4j9yt3s4YuFdqWEHEzB4kJVthNZHIUc6gc/mhpDQD+eIUSmUyhFARGorsu/apxDKBeV8A1SxqoXjzOdx8of1F02ya4tYA0hceR+rRsxpSrYs=", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 42e65b40-6719-46d0-1708-08d80bc54d1a", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Jun 2020 16:02:10.5203 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n SJTR5Pb1Y/dQCHzx2CvHLtXDvapXIfzZn6Q8e2dgNgCj5I+z1WJo91+Qn+heSkOf9Tss6+1uhH1gmaj0FlR2gw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB8PR05MB6777", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix flow memory allocation size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In DV enabled MLX5 PMD build mlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW].size\nwas initiated for DV structure. If RTE initialization encountered MLX5\nPCI function with disabled DV support\nmlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW].size was reduced to match legacy\nverbs flow size. Since mlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW] is a\nglobal variable that change reflected on DV enabled MLX5 PCI functions\ntoo.\n\nRunning flow with invalid ipool size crashes PMD.\n\nThe patch adjusts ipool flow size for each active PCI function.\n\nFixes: b88341ca35fc (\"net/mlx5: convert flow dev handle to indexed\")\n\nSigned-off-by: Gregory Etelson <getelson@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 40 +++++++++++++++++++++++++---------------\n 1 file changed, 25 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 5589772eb8..145021ef0f 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -198,7 +198,7 @@ struct mlx5_dev_spawn_data {\n static LIST_HEAD(, mlx5_ibv_shared) mlx5_ibv_list = LIST_HEAD_INITIALIZER();\n static pthread_mutex_t mlx5_ibv_list_mutex = PTHREAD_MUTEX_INITIALIZER;\n \n-static struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = {\n+static const struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = {\n #ifdef HAVE_IBV_FLOW_DV_SUPPORT\n \t{\n \t\t.size = sizeof(struct mlx5_flow_dv_encap_decap_resource),\n@@ -290,7 +290,11 @@ static struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = {\n \t\t.type = \"mlx5_hrxq_ipool\",\n \t},\n \t{\n-\t\t.size = sizeof(struct mlx5_flow_handle),\n+\t\t/*\n+\t\t * MLX5_IPOOL_MLX5_FLOW size varies for DV and VERBS flows.\n+\t\t * It set in run time according to PCI function configuration.\n+\t\t */\n+\t\t.size = 0,\n \t\t.trunk_size = 64,\n \t\t.grow_trunk = 3,\n \t\t.grow_shift = 2,\n@@ -562,22 +566,28 @@ mlx5_flow_counters_mng_close(struct mlx5_ibv_shared *sh)\n */\n static void\n mlx5_flow_ipool_create(struct mlx5_ibv_shared *sh,\n-\t\t const struct mlx5_dev_config *config __rte_unused)\n+\t\t const struct mlx5_dev_config *config)\n {\n \tuint8_t i;\n+\tstruct mlx5_indexed_pool_config cfg;\n \n-#ifdef HAVE_IBV_FLOW_DV_SUPPORT\n-\t/*\n-\t * While DV is supported, user chooses the verbs mode,\n-\t * the mlx5 flow handle size is different with the\n-\t * MLX5_FLOW_HANDLE_VERBS_SIZE.\n-\t */\n-\tif (!config->dv_flow_en)\n-\t\tmlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW].size =\n-\t\t\t\t\tMLX5_FLOW_HANDLE_VERBS_SIZE;\n-#endif\n-\tfor (i = 0; i < MLX5_IPOOL_MAX; ++i)\n-\t\tsh->ipool[i] = mlx5_ipool_create(&mlx5_ipool_cfg[i]);\n+\tfor (i = 0; i < MLX5_IPOOL_MAX; ++i) {\n+\t\tcfg = mlx5_ipool_cfg[i];\n+\t\tswitch (i) {\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t/*\n+\t\t * Set MLX5_IPOOL_MLX5_FLOW ipool size\n+\t\t * according to PCI function flow configuration.\n+\t\t */\n+\t\tcase MLX5_IPOOL_MLX5_FLOW:\n+\t\t\tcfg.size = config->dv_flow_en ?\n+\t\t\t\tsizeof(struct mlx5_flow_handle) :\n+\t\t\t\tMLX5_FLOW_HANDLE_VERBS_SIZE;\n+\t\t\tbreak;\n+\t\t}\n+\t\tsh->ipool[i] = mlx5_ipool_create(&cfg);\n+\t}\n }\n \n /**\n", "prefixes": [ "1/1" ] }