Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70797/?format=api
{ "id": 70797, "url": "http://patches.dpdk.org/api/patches/70797/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200603024016.30636-36-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200603024016.30636-36-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200603024016.30636-36-qi.z.zhang@intel.com", "date": "2020-06-03T02:39:59", "name": "[35/52] net/ice/base: correct return value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "937b556513864eaa8a0e091076268d0dbe5fddfd", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200603024016.30636-36-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 10300, "url": "http://patches.dpdk.org/api/series/10300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10300", "date": "2020-06-03T02:39:24", "name": "net/ice: base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/10300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70797/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/70797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7B48A04EF;\n\tWed, 3 Jun 2020 04:42:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CDC01D534;\n\tWed, 3 Jun 2020 04:37:34 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id D44AF1C0AF\n for <dev@dpdk.org>; Wed, 3 Jun 2020 04:37:32 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Jun 2020 19:37:32 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by orsmga001.jf.intel.com with ESMTP; 02 Jun 2020 19:37:30 -0700" ], "IronPort-SDR": [ "\n AxpEdfboD+P8W35HiJQI27asCEnCoqi/+R8i10itAz5mo96KXDGzRMyj+fRIdDX9qiQJdp6B/V\n NUW2NS2gWwAQ==", "\n qdMhRIUFtqd5gu05AEqH8n5efqRcxO8wbhbuvl4rpBZ3oFkejhdp6J/JUFizv78bbJXTfdInkn\n 9K//vRRqUx8w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,466,1583222400\"; d=\"scan'208\";a=\"347614174\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n Kiran Patil <kiran.patil@intel.com>,\n \"Paul M . Stillwell Jr\" <paul.m.stillwell.jr@intel.com>", "Date": "Wed, 3 Jun 2020 10:39:59 +0800", "Message-Id": "<20200603024016.30636-36-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200603024016.30636-1-qi.z.zhang@intel.com>", "References": "<20200603024016.30636-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 35/52] net/ice/base: correct return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Function ice_rem_adv_rule_id return incorrect error code (ICE_ERR_PARAM)\nwhereas it should have returned ICE_ERR_DOES_NOT_EXIST return code\nif filter list is empty or unable to find \"rule\" in list\n\nSigned-off-by: Kiran Patil <kiran.patil@intel.com>\nSigned-off-by: Paul M. Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 01dcace55..5c53b9ec3 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -7661,7 +7661,8 @@ ice_rem_adv_rule_by_id(struct ice_hw *hw,\n \t\t\t\t\t\tlist_itr->lkups_cnt, &rinfo);\n \t\t}\n \t}\n-\treturn ICE_ERR_PARAM;\n+\t/* either list is empty or unable to find rule */\n+\treturn ICE_ERR_DOES_NOT_EXIST;\n }\n \n /**\n", "prefixes": [ "35/52" ] }